From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E26C4338F for ; Tue, 17 Aug 2021 07:03:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 522096054F for ; Tue, 17 Aug 2021 07:03:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238311AbhHQHD6 (ORCPT ); Tue, 17 Aug 2021 03:03:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234560AbhHQHD4 (ORCPT ); Tue, 17 Aug 2021 03:03:56 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88EF7C061764 for ; Tue, 17 Aug 2021 00:03:23 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id d11so36637397eja.8 for ; Tue, 17 Aug 2021 00:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+6L7SD5xcqr4nFDTKqSIKd3yb4ZJvrBCFNPVbuPjyXg=; b=gy3Z/U6QNI9EQqE5hJlwSl3J2SLOjBOfKOOGkVvYaFkNvKVPGgwPRSHAwMskDfnG1Z gufYNa7zwhBI+hQAXH5NQxUvcY43qLo9h/663tY940EHPU5DPJOmLZbg3vFM75wdnQqq aDh8Lh3pXUUYirMzJEG7VCDiVVd+oPr69YHoBXyZno6M2Y4sGA2gAMV1WUAiJBr62hUA D0dqw24fMdrtCL76inhL9zuWDFSmyC3WQSoU5Cl0OwGevqe5ha8GHGQ5gU8/hSnmtmhT Bd6UtD84dy3XCSvA25cKjApkY15kSFdhLb/V4X3PN6MuscTrQO4Jpz9nNr78SoywZUrF Gc1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+6L7SD5xcqr4nFDTKqSIKd3yb4ZJvrBCFNPVbuPjyXg=; b=WTFkPBRTG7aYQnJrK/170FtmfI5Ue54XWKQHeBH9W5ov0ZvqG1nQ0rfeKjZrYQLlR4 0SQzX1ux/BOeiThICi11wvgLbHSSkLbau4XKxlaC+UA9oQQ7e9klZXILtQnqV67J6PhO BztSdNF4yyl85fhiZUmaueGINDPCr2qyTZrQkrv+G+M5nGzw3FFJv6NOUykhEJSgpy72 S32kw1bIVLV1yr42KTvanY5ZR9J5E1D6E5T+rWIG5ZTPNQwp2kHOENgIkNVW14QSC6gR nn9SE91KRttT1eftIX74onYvYQDVr9v9/fHskD8LauVmbniEaSd2uCryOcIbkKF3lOy2 6DEw== X-Gm-Message-State: AOAM530HX5SQDNJwIk5Q1FB5ltET9PqjAN2ncsPbarwDuVvcWwHoEH/U JM13HlZY9Ygssjca9GYT3RKbOsnELT4= X-Google-Smtp-Source: ABdhPJzIReZpu+4rT4ie4W6HboUY073CsOsJzAsJ7nLqVufwwAohziC5NgXJZiMMg5ZmyowEXd7N3Q== X-Received: by 2002:a17:907:2989:: with SMTP id eu9mr2299070ejc.89.1629183802193; Tue, 17 Aug 2021 00:03:22 -0700 (PDT) Received: from ?IPv6:2a02:8108:96c0:3b88::4058? ([2a02:8108:96c0:3b88::4058]) by smtp.gmail.com with ESMTPSA id b11sm351955eja.104.2021.08.17.00.03.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 00:03:21 -0700 (PDT) Subject: Re: [PATCH v2 2/3] staging: r8188eu: remove unneeded DBG_88E call from rtl8188e_Add_RateATid To: Phillip Potter , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210816234459.132239-1-phil@philpotter.co.uk> <20210816234459.132239-3-phil@philpotter.co.uk> From: Michael Straube Message-ID: <7853618d-565f-5c92-678c-e9384c5dc963@gmail.com> Date: Tue, 17 Aug 2021 09:02:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210816234459.132239-3-phil@philpotter.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/17/21 1:44 AM, Phillip Potter wrote: > Remove unneeded DBG_88E macro call from the rtl8188e_Add_RateATid > function in hal/rtl8188e_cmd.c, as it is not particularly clear in my > opinion, and we should strive towards use of existing kernel machinery > for debugging purposes. > > Signed-off-by: Phillip Potter > --- > drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c > index 4302054c6c83..77c057e276a5 100644 > --- a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c > +++ b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c > @@ -173,9 +173,6 @@ void rtl8188e_Add_RateATid(struct adapter *pAdapter, u32 bitmap, u8 arg, u8 rssi > > bitmap &= 0x0fffffff; > > - DBG_88E("%s=> mac_id:%d, raid:%d, ra_bitmap=0x%x, shortGIrate=0x%02x\n", > - __func__, macid, raid, bitmap, shortGIrate); > - > ODM_RA_UpdateRateInfo_8188E(&haldata->odmpriv, macid, raid, bitmap, shortGIrate); > } > > Looks good to me. Acked-by: Michael Straube Thanks, Michael