linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: greg gallagher <greg@embeddedgreg.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Eric Anholt <eric@anholt.net>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging/vc04_services: Fix alignment of function arguments
Date: Wed, 8 Aug 2018 11:25:19 -0400	[thread overview]
Message-ID: <78576030-1fdd-6e40-b6d8-8035b57df9e4@embeddedgreg.com> (raw)
In-Reply-To: <20180808013455.18037-1-greg@embeddedgreg.com>



On 2018-08-07 09:34 PM, Greg Gallagher wrote:
> Fix warnings generated by checkpatch.pl for alignment should match open
> parenthesis.  This is a coding style change only.
>
> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
> ---
>   .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
> index ec468d5719b1..8af303e25036 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
> @@ -94,7 +94,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,
>   }
>   
>   static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol,
> -				struct snd_ctl_elem_value *ucontrol)
> +			       struct snd_ctl_elem_value *ucontrol)
>   {
>   	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
>   	int changed = 0;
> @@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = {
>   };
>   
>   static int snd_bcm2835_spdif_default_info(struct snd_kcontrol *kcontrol,
> -	struct snd_ctl_elem_info *uinfo)
> +					  struct snd_ctl_elem_info *uinfo)
>   {
>   	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
>   	uinfo->count = 1;
> @@ -182,7 +182,7 @@ static int snd_bcm2835_spdif_default_info(struct snd_kcontrol *kcontrol,
>   }
>   
>   static int snd_bcm2835_spdif_default_get(struct snd_kcontrol *kcontrol,
> -	struct snd_ctl_elem_value *ucontrol)
> +					 struct snd_ctl_elem_value *ucontrol)
>   {
>   	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
>   	int i;
> @@ -199,7 +199,7 @@ static int snd_bcm2835_spdif_default_get(struct snd_kcontrol *kcontrol,
>   }
>   
>   static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol,
> -	struct snd_ctl_elem_value *ucontrol)
> +					 struct snd_ctl_elem_value *ucontrol)
>   {
>   	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
>   	unsigned int val = 0;
> @@ -219,7 +219,7 @@ static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol,
>   }
>   
>   static int snd_bcm2835_spdif_mask_info(struct snd_kcontrol *kcontrol,
> -	struct snd_ctl_elem_info *uinfo)
> +				       struct snd_ctl_elem_info *uinfo)
>   {
>   	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
>   	uinfo->count = 1;
> @@ -227,7 +227,7 @@ static int snd_bcm2835_spdif_mask_info(struct snd_kcontrol *kcontrol,
>   }
>   
>   static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
> -	struct snd_ctl_elem_value *ucontrol)
> +				      struct snd_ctl_elem_value *ucontrol)
>   {
>   	/*
>   	 * bcm2835 supports only consumer mode and sets all other format flags
> @@ -238,7 +238,7 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
>   }
>   
>   static int snd_bcm2835_spdif_stream_info(struct snd_kcontrol *kcontrol,
> -	struct snd_ctl_elem_info *uinfo)
> +					 struct snd_ctl_elem_info *uinfo)
>   {
>   	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
>   	uinfo->count = 1;
> @@ -246,7 +246,7 @@ static int snd_bcm2835_spdif_stream_info(struct snd_kcontrol *kcontrol,
>   }
>   
>   static int snd_bcm2835_spdif_stream_get(struct snd_kcontrol *kcontrol,
> -	struct snd_ctl_elem_value *ucontrol)
> +					struct snd_ctl_elem_value *ucontrol)
>   {
>   	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
>   	int i;
> @@ -263,7 +263,7 @@ static int snd_bcm2835_spdif_stream_get(struct snd_kcontrol *kcontrol,
>   }
>   
>   static int snd_bcm2835_spdif_stream_put(struct snd_kcontrol *kcontrol,
> -	struct snd_ctl_elem_value *ucontrol)
> +					struct snd_ctl_elem_value *ucontrol)
>   {
>   	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
>   	unsigned int val = 0;
Please ignore this patch, a new patch with the correct subject line and 
v2 description has been submitted.

-Greg

      reply	other threads:[~2018-08-08 15:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08  1:34 [PATCH v2] staging/vc04_services: Fix alignment of function arguments Greg Gallagher
2018-08-08 15:25 ` greg gallagher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78576030-1fdd-6e40-b6d8-8035b57df9e4@embeddedgreg.com \
    --to=greg@embeddedgreg.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).