* [PATCH] remoteproc: qcom: pas: Add QCS404 remoteprocs
@ 2018-09-20 17:22 Bjorn Andersson
2018-09-25 10:18 ` Sibi Sankar
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2018-09-20 17:22 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Rob Herring, Mark Rutland
Cc: linux-remoteproc, devicetree, linux-kernel, linux-arm-msm
From: Govind Singh <govinds@codeaurora.org>
Add compatibles for the three PAS based remote processors found in
QCS404.
Signed-off-by: Govind Singh <govinds@codeaurora.org>
[bjorn: Added adsp and cdsp to the patch]
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
.../devicetree/bindings/remoteproc/qcom,adsp.txt | 3 +++
drivers/remoteproc/qcom_adsp_pil.c | 12 ++++++++++++
2 files changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
index b7d058228185..9c0cff3a5ed8 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
@@ -10,6 +10,9 @@ on the Qualcomm ADSP Hexagon core.
"qcom,msm8974-adsp-pil"
"qcom,msm8996-adsp-pil"
"qcom,msm8996-slpi-pil"
+ "qcom,qcs404-adsp-pas"
+ "qcom,qcs404-cdsp-pas"
+ "qcom,qcs404-wcss-pas"
"qcom,sdm845-adsp-pas"
"qcom,sdm845-cdsp-pas"
diff --git a/drivers/remoteproc/qcom_adsp_pil.c b/drivers/remoteproc/qcom_adsp_pil.c
index da2254ea1135..fcbb816a9698 100644
--- a/drivers/remoteproc/qcom_adsp_pil.c
+++ b/drivers/remoteproc/qcom_adsp_pil.c
@@ -362,10 +362,22 @@ static const struct adsp_data slpi_resource_init = {
.ssctl_id = 0x16,
};
+static const struct adsp_data wcss_resource_init = {
+ .crash_reason_smem = 421,
+ .firmware_name = "wcnss.mdt",
+ .pas_id = 6,
+ .ssr_name = "mpss",
+ .sysmon_name = "wlan",
+ .ssctl_id = 0x12,
+};
+
static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
{ .compatible = "qcom,msm8996-adsp-pil", .data = &adsp_resource_init},
{ .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init},
+ { .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init },
+ { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init },
+ { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init },
{ .compatible = "qcom,sdm845-adsp-pas", .data = &adsp_resource_init},
{ .compatible = "qcom,sdm845-cdsp-pas", .data = &cdsp_resource_init},
{ },
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] remoteproc: qcom: pas: Add QCS404 remoteprocs
2018-09-20 17:22 [PATCH] remoteproc: qcom: pas: Add QCS404 remoteprocs Bjorn Andersson
@ 2018-09-25 10:18 ` Sibi Sankar
2018-09-25 23:35 ` Bjorn Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Sibi Sankar @ 2018-09-25 10:18 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Ohad Ben-Cohen, Rob Herring, Mark Rutland, linux-remoteproc,
devicetree, linux-kernel, linux-arm-msm, linux-kernel-owner
Hi Bjorn,
On 2018-09-20 22:52, Bjorn Andersson wrote:
> From: Govind Singh <govinds@codeaurora.org>
>
> Add compatibles for the three PAS based remote processors found in
> QCS404.
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> [bjorn: Added adsp and cdsp to the patch]
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> .../devicetree/bindings/remoteproc/qcom,adsp.txt | 3 +++
> drivers/remoteproc/qcom_adsp_pil.c | 12 ++++++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index b7d058228185..9c0cff3a5ed8 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -10,6 +10,9 @@ on the Qualcomm ADSP Hexagon core.
> "qcom,msm8974-adsp-pil"
> "qcom,msm8996-adsp-pil"
> "qcom,msm8996-slpi-pil"
> + "qcom,qcs404-adsp-pas"
> + "qcom,qcs404-cdsp-pas"
> + "qcom,qcs404-wcss-pas"
> "qcom,sdm845-adsp-pas"
> "qcom,sdm845-cdsp-pas"
>
> diff --git a/drivers/remoteproc/qcom_adsp_pil.c
> b/drivers/remoteproc/qcom_adsp_pil.c
> index da2254ea1135..fcbb816a9698 100644
> --- a/drivers/remoteproc/qcom_adsp_pil.c
> +++ b/drivers/remoteproc/qcom_adsp_pil.c
> @@ -362,10 +362,22 @@ static const struct adsp_data slpi_resource_init
> = {
> .ssctl_id = 0x16,
> };
>
> +static const struct adsp_data wcss_resource_init = {
> + .crash_reason_smem = 421,
> + .firmware_name = "wcnss.mdt",
> + .pas_id = 6,
> + .ssr_name = "mpss",
> + .sysmon_name = "wlan",
Shouldn't the sysmon name be "wcnss" instead of "wlan"?
> + .ssctl_id = 0x12,
> +};
> +
> static const struct of_device_id adsp_of_match[] = {
> { .compatible = "qcom,msm8974-adsp-pil", .data =
> &adsp_resource_init},
> { .compatible = "qcom,msm8996-adsp-pil", .data =
> &adsp_resource_init},
> { .compatible = "qcom,msm8996-slpi-pil", .data =
> &slpi_resource_init},
> + { .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init
> },
> + { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init
> },
> + { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init
> },
> { .compatible = "qcom,sdm845-adsp-pas", .data = &adsp_resource_init},
> { .compatible = "qcom,sdm845-cdsp-pas", .data = &cdsp_resource_init},
> { },
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] remoteproc: qcom: pas: Add QCS404 remoteprocs
2018-09-25 10:18 ` Sibi Sankar
@ 2018-09-25 23:35 ` Bjorn Andersson
2018-09-26 15:48 ` Sibi Sankar
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2018-09-25 23:35 UTC (permalink / raw)
To: Sibi Sankar
Cc: Ohad Ben-Cohen, Rob Herring, Mark Rutland, linux-remoteproc,
devicetree, linux-kernel, linux-arm-msm, linux-kernel-owner
On Tue 25 Sep 03:18 PDT 2018, Sibi Sankar wrote:
> On 2018-09-20 22:52, Bjorn Andersson wrote:
> > diff --git a/drivers/remoteproc/qcom_adsp_pil.c
> > b/drivers/remoteproc/qcom_adsp_pil.c
> > index da2254ea1135..fcbb816a9698 100644
> > --- a/drivers/remoteproc/qcom_adsp_pil.c
> > +++ b/drivers/remoteproc/qcom_adsp_pil.c
> > @@ -362,10 +362,22 @@ static const struct adsp_data slpi_resource_init =
> > {
> > .ssctl_id = 0x16,
> > };
> >
> > +static const struct adsp_data wcss_resource_init = {
> > + .crash_reason_smem = 421,
> > + .firmware_name = "wcnss.mdt",
> > + .pas_id = 6,
> > + .ssr_name = "mpss",
> > + .sysmon_name = "wlan",
>
> Shouldn't the sysmon name be "wcnss" instead of "wlan"?
>
I derived this from the downstream kernel, perhaps I got it wrong?
Regards,
Bjorn
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] remoteproc: qcom: pas: Add QCS404 remoteprocs
2018-09-25 23:35 ` Bjorn Andersson
@ 2018-09-26 15:48 ` Sibi Sankar
0 siblings, 0 replies; 4+ messages in thread
From: Sibi Sankar @ 2018-09-26 15:48 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Ohad Ben-Cohen, Rob Herring, Mark Rutland, linux-remoteproc,
devicetree, linux-kernel, linux-arm-msm, linux-kernel-owner,
linux-remoteproc-owner
On 2018-09-26 05:05, Bjorn Andersson wrote:
> On Tue 25 Sep 03:18 PDT 2018, Sibi Sankar wrote:
>> On 2018-09-20 22:52, Bjorn Andersson wrote:
>> > diff --git a/drivers/remoteproc/qcom_adsp_pil.c
>> > b/drivers/remoteproc/qcom_adsp_pil.c
>> > index da2254ea1135..fcbb816a9698 100644
>> > --- a/drivers/remoteproc/qcom_adsp_pil.c
>> > +++ b/drivers/remoteproc/qcom_adsp_pil.c
>> > @@ -362,10 +362,22 @@ static const struct adsp_data slpi_resource_init =
>> > {
>> > .ssctl_id = 0x16,
>> > };
>> >
>> > +static const struct adsp_data wcss_resource_init = {
>> > + .crash_reason_smem = 421,
>> > + .firmware_name = "wcnss.mdt",
>> > + .pas_id = 6,
>> > + .ssr_name = "mpss",
>> > + .sysmon_name = "wlan",
>>
>> Shouldn't the sysmon name be "wcnss" instead of "wlan"?
>>
>
> I derived this from the downstream kernel, perhaps I got it wrong?
>
I could see that the label is "wcnss" and glink-label is "mpss"
downstream.
> Regards,
> Bjorn
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-26 15:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-20 17:22 [PATCH] remoteproc: qcom: pas: Add QCS404 remoteprocs Bjorn Andersson
2018-09-25 10:18 ` Sibi Sankar
2018-09-25 23:35 ` Bjorn Andersson
2018-09-26 15:48 ` Sibi Sankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).