From: Albert Cahalan <acahalan@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Arjan van de Ven <arjan@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add /proc/*/pmap files
Date: Sun, 22 Jan 2006 15:40:29 -0500 [thread overview]
Message-ID: <787b0d920601221240m1fbe25d9k3b050b4505042d1@mail.gmail.com> (raw)
In-Reply-To: <20060122115856.42231368.akpm@osdl.org>
On 1/22/06, Andrew Morton <akpm@osdl.org> wrote:
> Arjan van de Ven <arjan@infradead.org> wrote:
> >
> > you're making a NEW file
>
> One which, afaict, contains the same thing as /proc/pid/smaps only in a
> different format. If there's a point to this patch, we weren't told what
> it is.
First of all, it isn't just the same. I need to know if
memory is locked or not. I need to know the page size.
Second of all, smaps is surely a parody of bad file
format design. When I first heard of the patch, I was
certain that it would be rejected for that reason.
At the time I was to sick and busy to even comment
on the matter. It was with shock and horror that I
later found the patch in the kernel.
I can't just fix smaps now, because that would break
a rotten ABI. Patching it out should work OK though,
because it is recent enough that apps will still support
kernels without it. I would have done so with this patch,
but you supposedly don't care for big patches.
prev parent reply other threads:[~2006-01-22 20:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 9:50 [PATCH] add /proc/*/pmap files Albert Cahalan
2006-01-22 10:03 ` Arjan van de Ven
2006-01-22 10:38 ` Kyle Moffett
2006-01-22 10:39 ` Willy Tarreau
2006-01-22 14:32 ` Jan Engelhardt
2006-01-22 20:02 ` Albert Cahalan
2006-01-22 14:36 ` Arjan van de Ven
2006-01-22 19:17 ` Albert Cahalan
2006-01-22 19:44 ` Arjan van de Ven
2006-01-22 19:58 ` Andrew Morton
2006-01-22 20:40 ` Albert Cahalan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=787b0d920601221240m1fbe25d9k3b050b4505042d1@mail.gmail.com \
--to=acahalan@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).