From: "Ramkrishna Vepa" <Ramkrishna.Vepa@neterion.com>
To: "Adrian Bunk" <bunk@kernel.org>, <jgarzik@pobox.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Rastapur Santosh" <santosh.rastapur@neterion.com>,
"Sivakumar Subramani" <Sivakumar.Subramani@neterion.com>,
"Sreenivasa Honnur" <Sreenivasa.Honnur@neterion.com>
Subject: RE: [2.6 patch] drivers/net/s2io.c section fixes
Date: Tue, 11 Dec 2007 18:16:51 -0500 [thread overview]
Message-ID: <78C9135A3D2ECE4B8162EBDCE82CAD7702B13B2D@nekter> (raw)
In-Reply-To: <20071211222306.GV14204@stusta.de>
Thanks. Patch looks good. Please accept.
Ram
> -----Original Message-----
> From: Adrian Bunk [mailto:bunk@kernel.org]
> Sent: Tuesday, December 11, 2007 2:23 PM
> To: ram.vepa@neterion.com; Rastapur Santosh; Sivakumar Subramani;
> Sreenivasa Honnur; jgarzik@pobox.com
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [2.6 patch] drivers/net/s2io.c section fixes
>
> Code used by the non-__devinit s2io_open() mustn't be __devinit.
>
> This patch fixes the following section mismatch with CONFIG_HOTPLUG=n:
>
> <-- snip -->
>
> ...
> WARNING: vmlinux.o(.text+0x6f6e3e): Section mismatch: reference to
> .init.text.20:s2io_test_intr (between 's2io_open' and
's2io_ethtool_sset')
> ...
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> drivers/net/s2io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> 50fb761b99d7ee0b234359d02144f84a87e2faff
> diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
> index 121cb10..9d80f1c 100644
> --- a/drivers/net/s2io.c
> +++ b/drivers/net/s2io.c
> @@ -3737,7 +3737,7 @@ static int s2io_enable_msi_x(struct s2io_nic
*nic)
> }
>
> /* Handle software interrupt used during MSI(X) test */
> -static irqreturn_t __devinit s2io_test_intr(int irq, void *dev_id)
> +static irqreturn_t s2io_test_intr(int irq, void *dev_id)
> {
> struct s2io_nic *sp = dev_id;
>
> @@ -3748,7 +3748,7 @@ static irqreturn_t __devinit s2io_test_intr(int
irq,
> void *dev_id)
> }
>
> /* Test interrupt path by forcing a a software IRQ */
> -static int __devinit s2io_test_msi(struct s2io_nic *sp)
> +static int s2io_test_msi(struct s2io_nic *sp)
> {
> struct pci_dev *pdev = sp->pdev;
> struct XENA_dev_config __iomem *bar0 = sp->bar0;
next prev parent reply other threads:[~2007-12-11 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 22:23 [2.6 patch] drivers/net/s2io.c section fixes Adrian Bunk
2007-12-11 23:16 ` Ramkrishna Vepa [this message]
2007-12-14 20:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78C9135A3D2ECE4B8162EBDCE82CAD7702B13B2D@nekter \
--to=ramkrishna.vepa@neterion.com \
--cc=Sivakumar.Subramani@neterion.com \
--cc=Sreenivasa.Honnur@neterion.com \
--cc=bunk@kernel.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh.rastapur@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).