From: Jose Abreu <jose.abreu@synopsys.com>
To: "Leonidas P. Papadakos" <papadakospan@gmail.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: "Jose Abreu" <jose.abreu@synopsys.com>,
"Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Christoph Müllner" <christoph.muellner@theobroma-systems.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Klaus Goger" <klaus.goger@theobroma-systems.com>
Subject: RE: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices
Date: Wed, 3 Apr 2019 07:55:25 +0000 [thread overview]
Message-ID: <78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com> (raw)
In-Reply-To: <1554245296.1271.0@gmail.com>
From: Leonidas P. Papadakos <papadakospan@gmail.com>
Date: Tue, Apr 02, 2019 at 23:48:16
> I can confirm that snps,no-pbl-x8, currently set by uboot for the fdt
> basically fixes the tx-checksumming issue.
> I get 700~800 Mbps myself but that might come down to the setup.
> You could say it affects performance slightly, as I saw in a previous
> email.
>
> Without the setting The rate consistently drops to 0.
> ethtool reports tx-checksumming is on in both cases
>
> Pretty cool!
> Does that give you guys an idea on how to tackle it "officially"?
>
>
>
Thank you all for testing !
It's been on my todo list to cook up a patch that limits PBL according to
FIFO size but I didn't manage to have the time yet so for now it would
be better if you fix it by submitting the DT bindings changes.
Thanks,
Jose Miguel Abreu
next prev parent reply other threads:[~2019-04-03 7:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 18:18 [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices Leonidas P. Papadakos
2019-04-01 18:31 ` Heiko Stübner
2019-04-01 18:54 ` Robin Murphy
2019-04-01 19:06 ` Heiko Stübner
2019-04-01 19:12 ` Philipp Tomsich
2019-04-02 7:59 ` Jose Abreu
2019-04-02 11:49 ` Robin Murphy
2019-04-02 11:53 ` Jose Abreu
2019-04-02 22:08 ` Robin Murphy
2019-04-02 22:48 ` Leonidas P. Papadakos
2019-04-03 7:55 ` Jose Abreu [this message]
2019-04-03 15:35 ` Leonidas P. Papadakos
2019-04-03 15:55 ` Leonidas P. Papadakos
2019-04-03 16:12 ` Robin Murphy
2019-04-05 10:24 ` Jose Abreu
2019-04-05 17:58 ` Leonidas P. Papadakos
2019-04-05 18:14 ` Leonidas P. Papadakos
2019-04-05 18:29 ` Robin Murphy
2019-04-05 18:38 ` Leonidas P. Papadakos
2019-04-11 21:09 ` Leonidas P. Papadakos
2019-04-12 7:35 ` Jose Abreu
2019-04-12 11:13 ` Leonidas P. Papadakos
2019-04-15 8:15 ` Jose Abreu
2019-04-15 21:45 ` Leonidas P. Papadakos
2019-04-15 22:19 ` Leonidas P. Papadakos
2019-04-16 8:01 ` Jose Abreu
2019-04-16 10:03 ` Leonidas P. Papadakos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=papadakospan@gmail.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).