From: Steffen Eiden <seiden@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>, Greg KH <greg@kroah.com>,
Heiko Carstens <hca@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Shuah Khan <shuah@kernel.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Nico Boehr <nrb@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v4 1/2] drivers/s390/char: Add Ultravisor io device
Date: Tue, 17 May 2022 10:42:18 +0200 [thread overview]
Message-ID: <78acfe88-97e3-92f9-29ef-736530179758@linux.ibm.com> (raw)
In-Reply-To: <bae6b9f0-dd4d-f109-b220-f6b118c889ad@linux.ibm.com>
On 5/17/22 10:38, Janosch Frank wrote:
> On 5/10/22 16:47, Steffen Eiden wrote:
>> This patch adds a new miscdevice to expose some Ultravisor functions
>> to userspace. Userspace can send IOCTLs to the uvdevice that will then
>> emit a corresponding Ultravisor Call and hands the result over to
>> userspace. The uvdevice is available if the Ultravisor Call facility is
>> present.
>> Userspace can call the Retrieve Attestation Measurement
>> Ultravisor Call using IOCTLs on the uvdevice.
>>
>> The uvdevice will do some sanity checks first.
>> Then, copy the request data to kernel space, build the UVCB,
>> perform the UV call, and copy the result back to userspace.
>>
>> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
>> Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
>
> I'd like to pick this if I'm allowed to fix the two white space problems
> below.
I am fine with that.
Thank you.
>
>> ---
>> MAINTAINERS | 2 +
>> arch/s390/include/asm/uv.h | 23 ++-
>> arch/s390/include/uapi/asm/uvdevice.h | 51 +++++
>> drivers/s390/char/Kconfig | 10 +
>> drivers/s390/char/Makefile | 1 +
>> drivers/s390/char/uvdevice.c | 264 ++++++++++++++++++++++++++
>> 6 files changed, 350 insertions(+), 1 deletion(-)
>> create mode 100644 arch/s390/include/uapi/asm/uvdevice.h
>> create mode 100644 drivers/s390/char/uvdevice.c
>>
>
>> +#endif /* __S390_ASM_UVDEVICE_H */
>
> There are two spaces between the "endif" and the "/"
>
>> diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
>> index 6cc4b19acf85..e9b9902abbaf 100644
>> --- a/drivers/s390/char/Kconfig
>> +++ b/drivers/s390/char/Kconfig
>> @@ -100,6 +100,16 @@ config SCLP_OFB
>> This option enables the Open-for-Business interface to the s390
>> Service Element.
> [...]
>> + * uvio_attestation() does a Retrieve Attestation Measurement
>> Ultravisor Call.
>
> Double space
>
>> + * It verifies that the given userspace addresses are valid and
>> request sizes
>> + * are sane. Every other check is made by the Ultravisor (UV) and
>> won't result
>> + * in a negative return value. It copies the input to kernelspace,
>> builds the
>> + * request, sends the UV-call, and copies the result to userspace.
>> + *
>
next prev parent reply other threads:[~2022-05-17 8:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 14:47 [PATCH v4 0/2] s390: Ultravisor device Steffen Eiden
2022-05-10 14:47 ` [PATCH v4 1/2] drivers/s390/char: Add Ultravisor io device Steffen Eiden
2022-05-12 14:33 ` Claudio Imbrenda
2022-05-13 7:45 ` Steffen Eiden
2022-05-13 8:37 ` Claudio Imbrenda
2022-05-13 12:35 ` Steffen Eiden
2022-05-16 11:33 ` Steffen Eiden
2022-05-16 14:51 ` Claudio Imbrenda
2022-05-17 8:38 ` Janosch Frank
2022-05-17 8:42 ` Steffen Eiden [this message]
2022-05-17 12:41 ` Janosch Frank
2022-05-18 11:47 ` Heiko Carstens
2022-05-18 13:45 ` Janosch Frank
2022-05-18 13:49 ` Steffen Eiden
2022-05-19 5:37 ` Heiko Carstens
2022-05-19 9:13 ` Janosch Frank
2022-05-10 14:47 ` [PATCH v4 2/2] selftests: drivers/s390x: Add uvdevice tests Steffen Eiden
2022-05-21 13:53 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78acfe88-97e3-92f9-29ef-736530179758@linux.ibm.com \
--to=seiden@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=greg@kroah.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).