From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83004C433F5 for ; Thu, 9 Sep 2021 07:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6036461101 for ; Thu, 9 Sep 2021 07:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352652AbhIIHbr (ORCPT ); Thu, 9 Sep 2021 03:31:47 -0400 Received: from mail-dm6nam12on2059.outbound.protection.outlook.com ([40.107.243.59]:39265 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S242799AbhIIHbp (ORCPT ); Thu, 9 Sep 2021 03:31:45 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mczIAHDYEtHWiHrGVNKl7AzeJTUsEcKG5TNno0xVtkC5jVTbtVn8NS1egVSUgKv6soDmok9QUXHu51gkhhd2rLnYHnOLn+264XhTxaD1rtzV6PpN6/jKo1f/GID1rqZjIGnLUDQxTGgqdFmv4nWSXmMiLYVes6XiwMY/Ka/t1wFJwdA3KGvAG8WkJ/s8JLS+lDr8Svr6ZGqeOT+N/aLOZEknQJLsa+wHG+epnCFNshSVZM6zh/rAYNcl6DMWv8vSZRmv0CC4hTLIUwXrQFmw654+dEbx5Lnndo4+AOID9JLCr3NPiye5bYITbXvWCbxqrgixT6TG4fquCPVYk9c+Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MMhJQGpQHy5NhG+UI3L9OljPFIUxRjeQOPCIjbxwJBU=; b=iL2LWYk/Gcf08j5NYS661YT0UrTLFJUOLMKe6sTaFXbqJm5RsMzi9NvmfEZlPsADRnZKJCPhFslT4fbR0nx2yRZRTVuvrNQLoi0PiaNnAVhZKlE2qiuDGL21S1t4//gs7uJHnsWb0WM/TZETY3Ddq1pbkOLE4fLLcktDnCq7lzlLii4HH4MJ88K+d2tp9wHrlDN6AJEx17aUbbzm+56wP8MrakAoUkklv3rMdaPdXyFh5A/nj7/xBFoLhXZ72yFZwYGgfd1WgvV1REgZTEcaNTVuMov+lXayiNrNERBKjgVu6lGAE0wYdKAjHBV44T7fm8sjDfqsrlbaVM3EaNxRRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MMhJQGpQHy5NhG+UI3L9OljPFIUxRjeQOPCIjbxwJBU=; b=qyD2w5NW5PDd9GfHO0jfbFINHvANy0hoVmq6uA0WWdhlUsLiChzQXqqRa8AhOedBPjNp3OWpjQc9MpFRFn9j+uIoNVYMupt6dSdsBoS5f+WR6TH0PddNI0GAHivdXQoBTG4eAr+g/u5KFQoMiMOGTzaR1M47gQBx44QzfRUEeN4= Authentication-Results: lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) by MN2PR12MB4390.namprd12.prod.outlook.com (2603:10b6:208:26e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 9 Sep 2021 07:30:35 +0000 Received: from MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::dce2:96e5:aba2:66fe]) by MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::dce2:96e5:aba2:66fe%6]) with mapi id 15.20.4500.015; Thu, 9 Sep 2021 07:30:35 +0000 Subject: Re: [PATCH] Enable '-Werror' by default for all kernel builds To: Guenter Roeck , Christoph Hellwig , Marco Elver Cc: Nathan Chancellor , Arnd Bergmann , Linus Torvalds , Linux Kernel Mailing List , llvm@lists.linux.dev, Nick Desaulniers , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrey Konovalov , kasan-dev@googlegroups.com, "Pan, Xinhui" , amd-gfx@lists.freedesktop.org References: <20210906142615.GA1917503@roeck-us.net> <75a10e8b-9f11-64c4-460b-9f3ac09965e2@roeck-us.net> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <78aeab09-de88-966f-9f03-a2d56a0a6064@amd.com> Date: Thu, 9 Sep 2021 09:30:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: PR3P189CA0070.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::15) To MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) MIME-Version: 1.0 Received: from [IPv6:2a02:908:1252:fb60:7140:364b:3af8:f004] (2a02:908:1252:fb60:7140:364b:3af8:f004) by PR3P189CA0070.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.15 via Frontend Transport; Thu, 9 Sep 2021 07:30:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ab3756c1-5750-473d-7ae5-08d97363b649 X-MS-TrafficTypeDiagnostic: MN2PR12MB4390: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C6hXIYx3ypYuXQ/306rkI5/G639bDPeW4AaOlhMXCIw/tveWvoNIDOLLLW0ONptA1MA/HRWPh50fJ2dSFM1gAAOZIySm7qDSYtgGe0Wyu+TjDZS3mnPIqfXKa0iTT3v30IHKfbK8rqwvsHsV/Lojd0Jj5DfTeatUUEwGQhxQBL727c3BVhzvKXGA7uNx0irkeWQ/jrbRfkXQYlZ2nQ/XV5+RkP7VZFq74HUW1foqfVTwxoVPpeiFx4EV8zcwWBrC8DUlHT4d7gYU443lv8HQTm8duT5mQbDHOIvRMu9GDDOO6uQP4M1CNNPlwkb9IzvahKfyNKP0OgMBAcoFINWG4wYuZOE/CJ6ORsnekFB+rg0f34ekbwOQxr13crwBIBK98sreQxIB3fiyvm2YWb2Tc3csRg30QvMvyYXxe3PlyLLfex04bh0MKONdFnAefo3OMflXQBYsCAH6eB7OHbm/sddEPkv4RjP83I1Z1RL7TPwWSZPiAvjTXDvnLsOpawlrQtN4P58bmLS1TBFw5bhGkgeN1p8xamSDGTk7M+X/qnJqcD/Nj/tkOcX4VX0WpztXzqPAmCz/NCwtKrVD4koZ1usZNe/uU2NzdA7lekw0saSfx9oJqFrcmq9RUKl5NXhQR4VVlygFe+dDrXX5t1vgZeAYIvDGXnwd2fSJQ/1uzw1/ueHNJSvfAoc+hR7lbi87WkVS1mOJzonivFwx33bzRBdoGN8HzWyo7LB40jVYNvNnI8mL7bqa3BRV/jpD5hvQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(376002)(366004)(39860400002)(66946007)(6666004)(2906002)(38100700002)(36756003)(53546011)(4326008)(31696002)(186003)(316002)(110136005)(66556008)(66476007)(8936002)(8676002)(54906003)(2616005)(83380400001)(478600001)(86362001)(6486002)(31686004)(5660300002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0tKbFg4Z3NJZWM3N1VKSDBtWXlkM0tYSlVhZS9ZQUZBbWlxV0ZFb1BMMWE3?= =?utf-8?B?eW5rTWpJS1AzbHBTaTJSUXpBTVc1elg5MjF6cUo1Z1Z0QTZTV25zeXBkeXRk?= =?utf-8?B?MUx1RHJCMWVhc1ZOMDRjWll6UVFWMGFFSVZTb3VOKzZHemlIMGl1MTd6blhY?= =?utf-8?B?QXU1TXVZMWZjUGcvSDhwMmZaUUMrY2FXbVpiOUFqb2lERGJaT3dyZWhRSDdI?= =?utf-8?B?V0tNYlgvQnltTnZ3Q1RQZWxlNXRCbHhKbWNyY1JxRDVDMFY3RVE5T2lJU20x?= =?utf-8?B?RlBjcnNvamJoZVhYbzdMRHRlK0VmNFFyNWNSL29ORDVWaitYbVd6dFMwREpk?= =?utf-8?B?Y1pqQ0FOaWVWTGErQnVOZWE3a3U5R1FER29GNWdUYXJvUm9uR3FFNlU4T3B0?= =?utf-8?B?RjlRVng5TUV0QlRWK092S2tqaC81Q0phVWZhTE04ckYxSzFDRGRhZklLYkN0?= =?utf-8?B?NkQ4N1hUNXZzN0ZTQmpXaXR4K0xXeUs5dXRvZTAwWFJ4R1dSV0dCbXlsSzhH?= =?utf-8?B?dzNyZ21UYU9KcitKK2tTczRDZEZ3QWNqRVlOSW9wYVFJT1h1Vm52Rnl0ZEYv?= =?utf-8?B?bDY5c3NiNWkrYmRQVEZPcUpaSmwrRGhuc3ovbzR0cGt6NDJRNHpmRWk3U0hn?= =?utf-8?B?aUlEODJnWDJ3UXdUWWdOLzFpUlZIcXJvdHpwUjJxcVBMMVUrUkc0aTVLTnJW?= =?utf-8?B?VVRIek5aQnUyU1NMNWVMbDBRK1MwQzU4NjNoUkpPQW9PaHAyODA1LzNqTHF6?= =?utf-8?B?VGtSNU1wZ1lEb3JHY1pMR2FFUzFkdnpZNm5Na1lZY3lTMTQ2RlI1SXp1OWlV?= =?utf-8?B?UWxGMWtjYXM2cXpyK1E4OGpDeElycEJRYnRwaktWWGppZ3B6dFk4aGF4VEVs?= =?utf-8?B?RFkyLytjNG04bVllWnhXMm0vVERPT1JlVUtVQjgrcVRQRVoyT2RMSEkzVjJH?= =?utf-8?B?QVZTeGI1VTlIVVJqcmV2T01uTDEzdEVnS0VQRzJGcisrZUZ0cWo1VFZrQmxw?= =?utf-8?B?THQ0cTBmcm0vb2hjVWxxajFGSkNhdlFKaVhzTDNlOC9INmZIRVhkMzU5djk3?= =?utf-8?B?L0VieWdpQ04xZXlmSFk3OFUvbmNRNnNPZE9jYURYbUlmNWZtV2pNNk9jN2VN?= =?utf-8?B?bGQ3Z05wSXBzTWxYdUsxV1NMeHBZY3M5V3BXbGJPUjNaejg0UjBTQnlLNmpp?= =?utf-8?B?UlU1dUtLaVk2R1dMMzhXSmc4Ym1jVzZYQi9tZk85cnZtSVByQndNcDd2Ky9V?= =?utf-8?B?VCtTK1F3dk5kOUtyWmcwejJyb1Rkb1l0NWJCdk13cHNlcW4rLzF3TXhzZFND?= =?utf-8?B?dW13NE5IR2E3VVVvWlN1c3FQNGViQ25sT2RBRW12aUtxU1lwMDFsV0VTTXM3?= =?utf-8?B?WUVkQU9raEpydlVWNjBPaWFRV1VTam84eXhSeFQyVXNmK1dKQkZGQnhKbEIz?= =?utf-8?B?Yi8zVHROU0FkL3R5enk3bTgwcFowRzR2ZEY3ejlIaklMaTdQQWM3a1phMHpi?= =?utf-8?B?U2dXSEN0alZkaTZ0aU1qNW4vM1hOM1lZY3FvakFDTmpOY1JVdVBsZStxRjdW?= =?utf-8?B?Q1ZNNVFIdzJiQmtJL0tKQ1Y2K1ROeFY4cWJlaUxiZ09UOFR5UGtZYXNIY3R5?= =?utf-8?B?QUYvWmcyQ0JXNGRFR0kzUDBISW1DeGdFZSt2UUhKM1BXWStYOWpMK09mYTRW?= =?utf-8?B?T3lZbEhSejFUamcvU0N4TG84KzFZZTlEcDNMVlU1WmZGZVRvVGw2K3pmS2R1?= =?utf-8?B?SUk2dTM1Sk5LRkNMd1N5bVBKV1VIaDB2NmV5elBaNWNwZklQNlBQTUc2TDg5?= =?utf-8?B?d2FIekRzSXB2Y1BPVTkySmlDQ3p2dVoreDRSQXhqMEU0M2JFbW9VMTNqU1Z1?= =?utf-8?Q?ZIpbxes4pKBMl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab3756c1-5750-473d-7ae5-08d97363b649 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 07:30:34.8950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 48jUA9n8Yf9bIegEvZtcDP0iGfwyGcADrWZCTQ6IYGYXHf8xqbxfZnUDbUhAVdez X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4390 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 09.09.21 um 08:07 schrieb Guenter Roeck: > On 9/8/21 10:58 PM, Christoph Hellwig wrote: >> On Wed, Sep 08, 2021 at 11:58:56PM +0200, Marco Elver wrote: >>> It'd be good to avoid. It has helped uncover build issues with KASAN in >>> the past. Or at least make it dependent on the problematic >>> architecture. >>> For example if arm is a problem, something like this: >> >> I'm also seeing quite a few stack size warnings with KASAN on x86_64 >> without COMPILT_TEST using gcc 10.2.1 from Debian.  In fact there are a >> few warnings without KASAN, but with KASAN there are a lot more. >> I'll try to find some time to dig into them. >> >> While we're at it, with -Werror something like this is really futile: >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function >> ‘amdgpu_bo_support_uswc’: >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:493:2: warning: #warning >> Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance >> thanks to write-combining [-Wcpp >>    493 | #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for >> better performance \ >>        |  ^~~~~~~ Ah, yes good point! > > I have been wondering if all those #warning "errors" should either > be removed or be replaced with "#pragma message". Well we started to add those warnings because people compiled their kernel with CONFIG_MTRR and CONFIG_X86_PAT and was then wondering why the performance of the display driver was so crappy. When those warning now generate an error which you have to disable explicitly then that might not be bad at all. It at least points people to this setting and makes it really clear that they are doing something very unusual and need to keep in mind that it might not have the desired result. Regards, Christian. > > Guenter