From: Randy Dunlap <rdunlap@infradead.org>
To: Nick Terrell <terrelln@fb.com>, Helge Deller <deller@gmx.de>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Rob Clark" <robdclark@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Anton Altaparmakov" <anton@tuxera.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Joey Gouly" <joey.gouly@arm.com>,
"Stan Skowronek" <stan@corellium.com>,
"Hector Martin" <marcan@marcan.st>,
"Andrey Ryabinin" <ryabinin.a.a@gmail.com>,
"André Almeida" <andrealmeid@collabora.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Parisc List" <linux-parisc@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
"linux-ntfs-dev@lists.sourceforge.net"
<linux-ntfs-dev@lists.sourceforge.net>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>
Subject: Re: Build regressions/improvements in v5.16-rc1
Date: Tue, 16 Nov 2021 18:05:40 -0800 [thread overview]
Message-ID: <78b2d093-e06c-ba04-9890-69f948bfb937@infradead.org> (raw)
In-Reply-To: <480CE37B-FE60-44EE-B9D2-59A88FDFE809@fb.com>
On 11/16/21 5:59 PM, Nick Terrell wrote:
>
>
>> On Nov 15, 2021, at 8:44 AM, Helge Deller <deller@gmx.de> wrote:
>>
>> On 11/15/21 17:12, Geert Uytterhoeven wrote:
>>> On Mon, Nov 15, 2021 at 4:54 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>>> Below is the list of build error/warning regressions/improvements in
>>>> v5.16-rc1[1] compared to v5.15[2].
>>>>
>>>> Summarized:
>>>> - build errors: +20/-13
>>>> - build warnings: +3/-28
>>>>
>>>> Happy fixing! ;-)
>>>>
>>>> Thanks to the linux-next team for providing the build service.
>>>>
>>>> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf/ (all 90 configs)
>>>> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8bb7eca972ad531c9b149c0a51ab43a417385813/ (all 90 configs)
>>>>
>>>>
>>>> *** ERRORS ***
>>>>
>>>> 20 error regressions:
>>>> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: expected ':' before '__stringify': => 33:4, 18:4
>>>> + /kisskb/src/arch/parisc/include/asm/jump_label.h: error: label 'l_yes' defined but not used [-Werror=unused-label]: => 38:1, 23:1
>>>
>>> due to static_branch_likely() in crypto/api.c
>>>
>>> parisc-allmodconfig
>>
>> fixed now in the parisc for-next git tree.
>>
>>
>>>> + /kisskb/src/drivers/gpu/drm/msm/msm_drv.h: error: "COND" redefined [-Werror]: => 531
>>>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size of 3252 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 47:1
>>>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size of 3360 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 499:1
>>>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size of 5344 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 334:1
>>>> + /kisskb/src/lib/zstd/compress/zstd_double_fast.c: error: the frame size of 5380 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 354:1
>>>> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 1824 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 372:1
>>>> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 2224 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 204:1
>>>> + /kisskb/src/lib/zstd/compress/zstd_fast.c: error: the frame size of 3800 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]: => 476:1
>>>
>>> parisc-allmodconfig
>>
>> parisc needs much bigger frame sizes, so I'm not astonished here.
>> During the v5.15 cycl I increased it to 1536 (from 1280), so I'm simply tempted to
>> increase it this time to 4096, unless someone has a better idea....
>
> This patch set should fix the zstd stack size warnings [0]. I’ve
> verified the fix using the same tooling: gcc-8-hppa-linux-gnu.
>
> I’ll send the PR to Linus tomorrow. I’ve been informed that it
> isn't strictly necessary to send the patches to the mailing list
> for bug fixes, but its already done, so I’ll wait and see if there
> is any feedback.
IMO several (or many more) people would disagree with that.
"strictly?" OK, it's probably possible that almost any patch
could be merged without being on a mailing list, but it's not
desirable (except in the case of "security" patches).
--
~Randy
next prev parent reply other threads:[~2021-11-17 2:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 15:51 Build regressions/improvements in v5.16-rc1 Geert Uytterhoeven
2021-11-15 16:12 ` Geert Uytterhoeven
2021-11-15 16:44 ` Marco Elver
2021-11-16 0:31 ` Kees Cook
2021-11-16 0:35 ` Kees Cook
2021-11-15 16:44 ` Helge Deller
2021-11-16 21:08 ` Nick Terrell
2021-11-16 21:27 ` Nick Terrell
2021-11-17 1:59 ` Nick Terrell
2021-11-17 2:05 ` Randy Dunlap [this message]
2021-11-17 2:19 ` Nick Terrell
2021-11-17 8:24 ` Geert Uytterhoeven
2021-11-17 11:22 ` Helge Deller
2021-11-17 19:39 ` Nick Terrell
2021-11-16 9:15 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78b2d093-e06c-ba04-9890-69f948bfb937@infradead.org \
--to=rdunlap@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andrealmeid@collabora.com \
--cc=anton@tuxera.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.apana.org.au \
--cc=joey.gouly@arm.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcan@marcan.st \
--cc=peterz@infradead.org \
--cc=robdclark@gmail.com \
--cc=ryabinin.a.a@gmail.com \
--cc=sergio.paracuellos@gmail.com \
--cc=stan@corellium.com \
--cc=terrelln@fb.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).