From: Nikolay Borisov <nborisov@suse.com>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
clm@fb.com, David Sterba <dsterba@suse.com>
Cc: Marcos Paulo de Souza <mpdesouza@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
"open list:BTRFS FILE SYSTEM" <linux-btrfs@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] btrfs: ioctl: Try to use btrfs_fs_info instead of *file
Date: Fri, 11 Oct 2019 09:38:09 +0300 [thread overview]
Message-ID: <78c54d95-9f8b-9cfb-6c3c-eac228ccaccf@suse.com> (raw)
In-Reply-To: <20191011002311.12459-1-marcos.souza.org@gmail.com>
On 11.10.19 г. 3:23 ч., Marcos Paulo de Souza wrote:
> Some functions are doing some bikeshedding to reach the btrfs_fs_info
> struct. Change these functions to receive a btrfs_fs_info struct instead
> of a *file.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Changes seems pretty self-explanatory so :
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> The kernel survived btrfs-progs tests with this patch applied.
>
> fs/btrfs/ioctl.c | 36 +++++++++++++++---------------------
> 1 file changed, 15 insertions(+), 21 deletions(-)
>
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index de730e56d3f5..870e5c48b362 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -479,10 +479,9 @@ static int btrfs_ioctl_getversion(struct file *file, int __user *arg)
> return put_user(inode->i_generation, arg);
> }
>
> -static noinline int btrfs_ioctl_fitrim(struct file *file, void __user *arg)
> +static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info,
> + void __user *arg)
> {
> - struct inode *inode = file_inode(file);
> - struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
> struct btrfs_device *device;
> struct request_queue *q;
> struct fstrim_range range;
> @@ -4960,10 +4959,9 @@ static long btrfs_ioctl_quota_rescan(struct file *file, void __user *arg)
> return ret;
> }
>
> -static long btrfs_ioctl_quota_rescan_status(struct file *file, void __user *arg)
> +static long btrfs_ioctl_quota_rescan_status(struct btrfs_fs_info *fs_info,
> + void __user *arg)
> {
> - struct inode *inode = file_inode(file);
> - struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
> struct btrfs_ioctl_quota_rescan_args *qsa;
> int ret = 0;
>
> @@ -4986,11 +4984,9 @@ static long btrfs_ioctl_quota_rescan_status(struct file *file, void __user *arg)
> return ret;
> }
>
> -static long btrfs_ioctl_quota_rescan_wait(struct file *file, void __user *arg)
> +static long btrfs_ioctl_quota_rescan_wait(struct btrfs_fs_info *fs_info,
> + void __user *arg)
> {
> - struct inode *inode = file_inode(file);
> - struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
> -
> if (!capable(CAP_SYS_ADMIN))
> return -EPERM;
>
> @@ -5162,10 +5158,9 @@ static long btrfs_ioctl_set_received_subvol(struct file *file,
> return ret;
> }
>
> -static int btrfs_ioctl_get_fslabel(struct file *file, void __user *arg)
> +static int btrfs_ioctl_get_fslabel(struct btrfs_fs_info *fs_info,
> + void __user *arg)
> {
> - struct inode *inode = file_inode(file);
> - struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
> size_t len;
> int ret;
> char label[BTRFS_LABEL_SIZE];
> @@ -5249,10 +5244,9 @@ int btrfs_ioctl_get_supported_features(void __user *arg)
> return 0;
> }
>
> -static int btrfs_ioctl_get_features(struct file *file, void __user *arg)
> +static int btrfs_ioctl_get_features(struct btrfs_fs_info *fs_info,
> + void __user *arg)
> {
> - struct inode *inode = file_inode(file);
> - struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
> struct btrfs_super_block *super_block = fs_info->super_copy;
> struct btrfs_ioctl_feature_flags features;
>
> @@ -5453,11 +5447,11 @@ long btrfs_ioctl(struct file *file, unsigned int
> case FS_IOC_GETVERSION:
> return btrfs_ioctl_getversion(file, argp);
> case FS_IOC_GETFSLABEL:
> - return btrfs_ioctl_get_fslabel(file, argp);
> + return btrfs_ioctl_get_fslabel(fs_info, argp);
> case FS_IOC_SETFSLABEL:
> return btrfs_ioctl_set_fslabel(file, argp);
> case FITRIM:
> - return btrfs_ioctl_fitrim(file, argp);
> + return btrfs_ioctl_fitrim(fs_info, argp);
> case BTRFS_IOC_SNAP_CREATE:
> return btrfs_ioctl_snap_create(file, argp, 0);
> case BTRFS_IOC_SNAP_CREATE_V2:
> @@ -5562,15 +5556,15 @@ long btrfs_ioctl(struct file *file, unsigned int
> case BTRFS_IOC_QUOTA_RESCAN:
> return btrfs_ioctl_quota_rescan(file, argp);
> case BTRFS_IOC_QUOTA_RESCAN_STATUS:
> - return btrfs_ioctl_quota_rescan_status(file, argp);
> + return btrfs_ioctl_quota_rescan_status(fs_info, argp);
> case BTRFS_IOC_QUOTA_RESCAN_WAIT:
> - return btrfs_ioctl_quota_rescan_wait(file, argp);
> + return btrfs_ioctl_quota_rescan_wait(fs_info, argp);
> case BTRFS_IOC_DEV_REPLACE:
> return btrfs_ioctl_dev_replace(fs_info, argp);
> case BTRFS_IOC_GET_SUPPORTED_FEATURES:
> return btrfs_ioctl_get_supported_features(argp);
> case BTRFS_IOC_GET_FEATURES:
> - return btrfs_ioctl_get_features(file, argp);
> + return btrfs_ioctl_get_features(fs_info, argp);
> case BTRFS_IOC_SET_FEATURES:
> return btrfs_ioctl_set_features(file, argp);
> case FS_IOC_FSGETXATTR:
>
next prev parent reply other threads:[~2019-10-11 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 0:23 [PATCH] btrfs: ioctl: Try to use btrfs_fs_info instead of *file Marcos Paulo de Souza
2019-10-11 6:38 ` Nikolay Borisov [this message]
2019-10-11 17:41 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78c54d95-9f8b-9cfb-6c3c-eac228ccaccf@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=mpdesouza@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).