From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, Chi Song <Song.Chi@microsoft.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
David Miller <davem@davemloft.net>,
Haiyang Zhang <haiyangz@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table
Date: Tue, 21 Jul 2020 12:24:07 -0700 [thread overview]
Message-ID: <78ca93f5-bb3f-96f9-17c5-3c1855b11a40@gmail.com> (raw)
In-Reply-To: <20200721122127.3ce422f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 7/21/20 12:21 PM, Jakub Kicinski wrote:
> On Tue, 21 Jul 2020 04:58:59 +0000 Chi Song wrote:
>> An imbalanced TX indirection table causes netvsc to have low
>> performance. This table is created and managed during runtime. To help
>> better diagnose performance issues caused by imbalanced tables, add
>> device attributes to show the content of TX indirection tables.
>>
>> Signed-off-by: Chi Song <chisong@microsoft.com>
>
> Sorry for waiting until v6 but sysfs feel like a very strange place to
> expose this. Especially under the netdev, not the bus device.
>
> This looks like device specific state, perhaps ethtool -d is a more
> appropriate place?
Agreed, or a devlink resource maybe?
--
Florian
next prev parent reply other threads:[~2020-07-21 19:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 4:58 [PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table Chi Song
2020-07-21 19:21 ` Jakub Kicinski
2020-07-21 19:24 ` Florian Fainelli [this message]
2020-07-22 23:42 ` Chi Song
2020-07-21 21:54 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78ca93f5-bb3f-96f9-17c5-3c1855b11a40@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Song.Chi@microsoft.com \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).