From: Josef Bacik <josef@toxicpanda.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [PATCH][RESEND] Revert "PM: ACPI: reboot: Use S5 for reboot"
Date: Wed, 17 Mar 2021 13:25:51 -0400 [thread overview]
Message-ID: <78dfcd55-442d-dcc0-c37f-5576f65f91b5@toxicpanda.com> (raw)
In-Reply-To: <CAAd53p7eJk9EtMTLjB5i7RdoKA3WS1W4TRjQs08adi7iAux_jQ@mail.gmail.com>
On 3/17/21 12:14 PM, Kai-Heng Feng wrote:
> On Wed, Mar 17, 2021 at 11:19 PM Josef Bacik <josef@toxicpanda.com> wrote:
>>
>> On 3/16/21 10:50 PM, Kai-Heng Feng wrote:
>>> Hi,
>>>
>>> On Wed, Mar 17, 2021 at 10:17 AM Josef Bacik <josef@toxicpanda.com> wrote:
>>>>
>>>> This reverts commit d60cd06331a3566d3305b3c7b566e79edf4e2095.
>>>>
>>>> This patch causes a panic when rebooting my Dell Poweredge r440. I do
>>>> not have the full panic log as it's lost at that stage of the reboot and
>>>> I do not have a serial console. Reverting this patch makes my system
>>>> able to reboot again.
>>>
>>> But this patch also helps many HP laptops, so maybe we should figure
>>> out what's going on on Poweredge r440.
>>> Does it also panic on shutdown?
>>>
>>
>> Sure I'll test whatever to get it fixed, but I just wasted 3 days bisecting and
>> lost a weekend of performance testing on btrfs because of this regression, so
>> until you figure out how it broke it needs to be reverted so people don't have
>> to figure out why reboot suddenly isn't working.
>
> That's unfortunate to hear. However, I've been spending tons of time
> on bisecting kernels. To me it's just a normal part of kernel
> development so I won't call it "wasted".
>
> Feel free to revert the patch though.
>
>>
>> Running "halt" has the same effect with and without your patch, it gets to
>> "system halted" and just sits there without powering off. Not entirely sure why
>> that is, but there's no panic.
>
> What about shutdown? pm_power_off_prepare() is used by shutdown but
> it's not used by halt.
"shutdown now" works fine with and without your patch. Thanks,
Josef
next prev parent reply other threads:[~2021-03-17 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 2:17 [PATCH][RESEND] Revert "PM: ACPI: reboot: Use S5 for reboot" Josef Bacik
2021-03-17 2:50 ` Kai-Heng Feng
2021-03-17 15:19 ` Josef Bacik
2021-03-17 16:14 ` Kai-Heng Feng
2021-03-17 17:25 ` Josef Bacik [this message]
2021-03-18 5:42 ` Kai-Heng Feng
2021-03-18 15:59 ` Rafael J. Wysocki
2021-03-18 19:02 ` Josef Bacik
2021-03-19 16:23 ` Kai-Heng Feng
2021-07-12 17:03 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78dfcd55-442d-dcc0-c37f-5576f65f91b5@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kai.heng.feng@canonical.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).