From: Guenter Roeck <linux@roeck-us.net>
To: Prashant Malani <pmalani@chromium.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: bleung@chromium.org, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 2/2] usb: typec: tcpm: Remove altmode active state updates
Date: Fri, 20 Jan 2023 14:47:23 -0800 [thread overview]
Message-ID: <78e1cc2d-eb67-cf78-bb84-95cdab2bfcf0@roeck-us.net> (raw)
In-Reply-To: <20230120205827.740900-2-pmalani@chromium.org>
On 1/20/23 12:58, Prashant Malani wrote:
> Since the "active" state for partner altmodes is now being taken care of
> by the altmode driver itself (specifically, DisplayPort altmode), we
> no longer need to do so from the port driver. So remove the calls to
> typec_altmode_update_active() from TCPM.
>
> Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Changes since v1:
> - Patch first introduced in v2.
>
> drivers/usb/typec/tcpm/tcpm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 904c7b4ce2f0..0f5a9d4db105 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -1693,14 +1693,11 @@ static int tcpm_pd_svdm(struct tcpm_port *port, struct typec_altmode *adev,
> }
> break;
> case CMD_ENTER_MODE:
> - if (adev && pdev) {
> - typec_altmode_update_active(pdev, true);
> + if (adev && pdev)
> *adev_action = ADEV_QUEUE_VDM_SEND_EXIT_MODE_ON_FAIL;
> - }
> return 0;
> case CMD_EXIT_MODE:
> if (adev && pdev) {
> - typec_altmode_update_active(pdev, false);
> /* Back to USB Operation */
> *adev_action = ADEV_NOTIFY_USB_AND_QUEUE_VDM;
> return 0;
next prev parent reply other threads:[~2023-01-20 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 20:58 [PATCH v2 1/2] usb: typec: altmodes/displayport: Update active state Prashant Malani
2023-01-20 20:58 ` [PATCH v2 2/2] usb: typec: tcpm: Remove altmode active state updates Prashant Malani
2023-01-20 22:47 ` Guenter Roeck [this message]
2023-01-24 11:03 ` Heikki Krogerus
2023-01-24 15:27 ` Benson Leung
2023-01-20 21:01 ` [PATCH v2 1/2] usb: typec: altmodes/displayport: Update active state Guenter Roeck
2023-01-24 11:01 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78e1cc2d-eb67-cf78-bb84-95cdab2bfcf0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bleung@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).