linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* How delete node or property in overlayd dts?
@ 2018-08-14 14:46 张波
  2018-08-15  1:26 ` Frank Rowand
  0 siblings, 1 reply; 5+ messages in thread
From: 张波 @ 2018-08-14 14:46 UTC (permalink / raw)
  To: robh+dt, frowand.list, devicetree, linux-kernel

/delete-node/ /delete-prop/ could be used in dtsi files without device
tree overlay.

but with device tree overlay,  /delete-node/ and  /delete-prop/ are not work.
How to delete property and node in overlay dts?

for example,
in basel.dts have following node
node1 {
    property1;
    property3;
    node2 {
        property2;
    }
}

in overlay.dts as following
 node1 {
    /delete-property/ property1;
    /delete-node/ node2;
}

after overlay, property1 and node2 is not deleted.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: How delete node or property in overlayd dts?
  2018-08-14 14:46 How delete node or property in overlayd dts? 张波
@ 2018-08-15  1:26 ` Frank Rowand
  2018-08-17 17:47   ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Frank Rowand @ 2018-08-15  1:26 UTC (permalink / raw)
  To: 张波, robh+dt, devicetree, linux-kernel

On 08/14/18 07:46, 张波 wrote:
> /delete-node/ /delete-prop/ could be used in dtsi files without device
> tree overlay.
> 
> but with device tree overlay,  /delete-node/ and  /delete-prop/ are not work.
> How to delete property and node in overlay dts?
> 
> for example,
> in basel.dts have following node
> node1 {
>     property1;
>     property3;
>     node2 {
>         property2;
>     }
> }
> 
> in overlay.dts as following
>  node1 {
>     /delete-property/ property1;
>     /delete-node/ node2;
> }
> 
> after overlay, property1 and node2 is not deleted.
> 

The /delete-node/ and /delete-prop/ directives are only used by the
dtc compiler within a single compilation.

There is nothing in the format of a devicetree blob to represent the
notion of deleting a property or a node.

You can not delete a property or a node in an overlay dtb.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: How delete node or property in overlayd dts?
  2018-08-15  1:26 ` Frank Rowand
@ 2018-08-17 17:47   ` Rob Herring
  2018-08-18 10:38     ` Zhang Bo
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-08-17 17:47 UTC (permalink / raw)
  To: zbsdta, Frank Rowand; +Cc: devicetree, linux-kernel

On Tue, Aug 14, 2018 at 7:26 PM Frank Rowand <frowand.list@gmail.com> wrote:
>
> On 08/14/18 07:46, 张波 wrote:
> > /delete-node/ /delete-prop/ could be used in dtsi files without device
> > tree overlay.
> >
> > but with device tree overlay,  /delete-node/ and  /delete-prop/ are not work.
> > How to delete property and node in overlay dts?
> >
> > for example,
> > in basel.dts have following node
> > node1 {
> >     property1;
> >     property3;
> >     node2 {
> >         property2;
> >     }
> > }
> >
> > in overlay.dts as following
> >  node1 {
> >     /delete-property/ property1;
> >     /delete-node/ node2;
> > }
> >
> > after overlay, property1 and node2 is not deleted.
> >
>
> The /delete-node/ and /delete-prop/ directives are only used by the
> dtc compiler within a single compilation.
>
> There is nothing in the format of a devicetree blob to represent the
> notion of deleting a property or a node.
>
> You can not delete a property or a node in an overlay dtb.

Though you can add/override 'status' with 'status = "disabled";' which
should be treated very similar to a node not being present. I say
similar because it's a source of bugs for the OS to fail to pay
attention to status property.

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: How delete node or property in overlayd dts?
  2018-08-17 17:47   ` Rob Herring
@ 2018-08-18 10:38     ` Zhang Bo
  2018-08-19  6:12       ` Frank Rowand
  0 siblings, 1 reply; 5+ messages in thread
From: Zhang Bo @ 2018-08-18 10:38 UTC (permalink / raw)
  To: Rob Herring, Frank Rowand; +Cc: devicetree, linux-kernel


在 2018/8/18 1:47, Rob Herring 写道:
> On Tue, Aug 14, 2018 at 7:26 PM Frank Rowand <frowand.list@gmail.com> wrote:
>> On 08/14/18 07:46, 张波 wrote:
>>> /delete-node/ /delete-prop/ could be used in dtsi files without device
>>> tree overlay.
>>>
>>> but with device tree overlay,  /delete-node/ and  /delete-prop/ are not work.
>>> How to delete property and node in overlay dts?
>>>
>>> for example,
>>> in basel.dts have following node
>>> node1 {
>>>      property1;
>>>      property3;
>>>      node2 {
>>>          property2;
>>>      }
>>> }
>>>
>>> in overlay.dts as following
>>>   node1 {
>>>      /delete-property/ property1;
>>>      /delete-node/ node2;
>>> }
>>>
>>> after overlay, property1 and node2 is not deleted.
>>>
>> The /delete-node/ and /delete-prop/ directives are only used by the
>> dtc compiler within a single compilation.
>>
>> There is nothing in the format of a devicetree blob to represent the
>> notion of deleting a property or a node.
>>
>> You can not delete a property or a node in an overlay dtb.
> Though you can add/override 'status' with 'status = "disabled";' which
> should be treated very similar to a node not being present. I say
> similar because it's a source of bugs for the OS to fail to pay
> attention to status property.

there is document in 
https://android.googlesource.com/kernel/msm/+/android-7.0.0_r0.11/Documentation/devicetree/overlay-notes.txt,

In above document, remove node or property by adding - operator before 
node or property. but I didn't find it in released kernel source code, 
Is there any update plan about this problem?

{

     property-a;       /* add property-a to the target */

     -proptery-b;     /* remove property-b from the target */

     -node-b {          /* remove an exiting node-b */

         ...

     }

}


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: How delete node or property in overlayd dts?
  2018-08-18 10:38     ` Zhang Bo
@ 2018-08-19  6:12       ` Frank Rowand
  0 siblings, 0 replies; 5+ messages in thread
From: Frank Rowand @ 2018-08-19  6:12 UTC (permalink / raw)
  To: Zhang Bo; +Cc: Rob Herring, devicetree, linux-kernel

On 08/18/18 03:38, Zhang Bo wrote:
> 
> 在 2018/8/18 1:47, Rob Herring 写道:
>> On Tue, Aug 14, 2018 at 7:26 PM Frank Rowand <frowand.list@gmail.com> wrote:
>>> On 08/14/18 07:46, 张波 wrote:
>>>> /delete-node/ /delete-prop/ could be used in dtsi files without device
>>>> tree overlay.
>>>>
>>>> but with device tree overlay,  /delete-node/ and  /delete-prop/ are not work.
>>>> How to delete property and node in overlay dts?
>>>>
>>>> for example,
>>>> in basel.dts have following node
>>>> node1 {
>>>>      property1;
>>>>      property3;
>>>>      node2 {
>>>>          property2;
>>>>      }
>>>> }
>>>>
>>>> in overlay.dts as following
>>>>   node1 {
>>>>      /delete-property/ property1;
>>>>      /delete-node/ node2;
>>>> }
>>>>
>>>> after overlay, property1 and node2 is not deleted.
>>>>
>>> The /delete-node/ and /delete-prop/ directives are only used by the
>>> dtc compiler within a single compilation.
>>>
>>> There is nothing in the format of a devicetree blob to represent the
>>> notion of deleting a property or a node.
>>>
>>> You can not delete a property or a node in an overlay dtb.
>> Though you can add/override 'status' with 'status = "disabled";' which
>> should be treated very similar to a node not being present. I say
>> similar because it's a source of bugs for the OS to fail to pay
>> attention to status property.
> 
> there is document in https://android.googlesource.com/kernel/msm/+/android-7.0.0_r0.11/Documentation/devicetree/overlay-notes.txt> 
> In above document, remove node or property by adding - operator before node or property. but I didn't find it in released kernel source code, Is there any update plan about this problem?
> 
> {
> 
>     property-a;       /* add property-a to the target */
> 
>     -proptery-b;     /* remove property-b from the target */
> 
>     -node-b {          /* remove an exiting node-b */
> 
>         ...
> 
>     }
> 
> }
> 
> 

As far as I can tell, this version of overlay-notes.txt has never been
in the mainline kernel source.

There is no plan to support such a syntax.

-Frank

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-08-19  6:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-14 14:46 How delete node or property in overlayd dts? 张波
2018-08-15  1:26 ` Frank Rowand
2018-08-17 17:47   ` Rob Herring
2018-08-18 10:38     ` Zhang Bo
2018-08-19  6:12       ` Frank Rowand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).