From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066D1C32750 for ; Fri, 2 Aug 2019 08:39:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1BEB2184E for ; Fri, 2 Aug 2019 08:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404360AbfHBIjp (ORCPT ); Fri, 2 Aug 2019 04:39:45 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:51256 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730941AbfHBIjp (ORCPT ); Fri, 2 Aug 2019 04:39:45 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 87B9E8EEDC29BFAD1BF8; Fri, 2 Aug 2019 16:39:43 +0800 (CST) Received: from [127.0.0.1] (10.177.96.96) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Fri, 2 Aug 2019 16:39:42 +0800 Subject: Re: [PATCH net-next] net: can: Fix compiling warning To: Oliver Hartkopp , , References: <20190802033643.84243-1-maowenan@huawei.com> <0050efdb-af9f-49b9-8d83-f574b3d46a2e@hartkopp.net> CC: , From: maowenan Message-ID: <78f7288e-08bc-41cd-d5b3-668d10903528@huawei.com> Date: Fri, 2 Aug 2019 16:39:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <0050efdb-af9f-49b9-8d83-f574b3d46a2e@hartkopp.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.96.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/8/2 16:10, Oliver Hartkopp wrote: > On 02/08/2019 05.36, Mao Wenan wrote: >> There are two warings in net/can, fix them by setting bcm_sock_no_ioctlcmd >> and raw_sock_no_ioctlcmd as static. >> >> net/can/bcm.c:1683:5: warning: symbol 'bcm_sock_no_ioctlcmd' was not declared. Should it be static? >> net/can/raw.c:840:5: warning: symbol 'raw_sock_no_ioctlcmd' was not declared. Should it be static? >> >> Fixes: 473d924d7d46 ("can: fix ioctl function removal") >> >> Signed-off-by: Mao Wenan > > Acked-by: Oliver Hartkopp > > Thanks Mao! > > Btw. what kind of compiler/make switches are you using so that I can see these warnings myself the next time? > I use ARCH=mips CROSS_COMPILE=mips-linux-gnu- . > Best regards, > Oliver > >> --- >> net/can/bcm.c | 2 +- >> net/can/raw.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/net/can/bcm.c b/net/can/bcm.c >> index bf1d0bbecec8..b8a32b4ac368 100644 >> --- a/net/can/bcm.c >> +++ b/net/can/bcm.c >> @@ -1680,7 +1680,7 @@ static int bcm_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, >> return size; >> } >> -int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, >> +static int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, >> unsigned long arg) >> { >> /* no ioctls for socket layer -> hand it down to NIC layer */ >> diff --git a/net/can/raw.c b/net/can/raw.c >> index da386f1fa815..a01848ff9b12 100644 >> --- a/net/can/raw.c >> +++ b/net/can/raw.c >> @@ -837,7 +837,7 @@ static int raw_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, >> return size; >> } >> -int raw_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, >> +static int raw_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, >> unsigned long arg) >> { >> /* no ioctls for socket layer -> hand it down to NIC layer */ >> > > . >