From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E5DC47082 for ; Tue, 8 Jun 2021 17:35:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 604A461360 for ; Tue, 8 Jun 2021 17:35:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233699AbhFHRhR (ORCPT ); Tue, 8 Jun 2021 13:37:17 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:56772 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233281AbhFHRhQ (ORCPT ); Tue, 8 Jun 2021 13:37:16 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C159D1FD2A; Tue, 8 Jun 2021 17:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623173722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ekpUS23lBpqTyQ4uJDG0/Y6FttsPCcNvOz09Cft9ijM=; b=vXQPLciAFd/sZ7El77HUtZFl7Fwo3I9Y4sFx4hliXZTNvc0hOXw4dMAQIloge3JaKIb7lb LWpRrYLY4+Hdeu9EzsppGH/zHjUi1tTVCxAhdltHifjOby2nZeFbQUG/7RgGykZ6qs1AwK E1TpSxziG7zyMbYbENFubpbFpwRrqiE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623173722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ekpUS23lBpqTyQ4uJDG0/Y6FttsPCcNvOz09Cft9ijM=; b=r1up/zcO4MfzJri+YTCOKHRc0H3RFlbA8bk5GTAgymgXKd35/4bTYU5/EDXUEAXm/MPtj5 s1QTuzCY0eDGMbBw== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 993E0118DD; Tue, 8 Jun 2021 17:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623173722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ekpUS23lBpqTyQ4uJDG0/Y6FttsPCcNvOz09Cft9ijM=; b=vXQPLciAFd/sZ7El77HUtZFl7Fwo3I9Y4sFx4hliXZTNvc0hOXw4dMAQIloge3JaKIb7lb LWpRrYLY4+Hdeu9EzsppGH/zHjUi1tTVCxAhdltHifjOby2nZeFbQUG/7RgGykZ6qs1AwK E1TpSxziG7zyMbYbENFubpbFpwRrqiE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623173722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ekpUS23lBpqTyQ4uJDG0/Y6FttsPCcNvOz09Cft9ijM=; b=r1up/zcO4MfzJri+YTCOKHRc0H3RFlbA8bk5GTAgymgXKd35/4bTYU5/EDXUEAXm/MPtj5 s1QTuzCY0eDGMbBw== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id QfrgJFqqv2CGdQAALh3uQQ (envelope-from ); Tue, 08 Jun 2021 17:35:22 +0000 To: Faiyaz Mohammed , Andy Shevchenko Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm , Linux Kernel Mailing List , Greg KH , glittao@gmail.com, vinmenon@codeaurora.org References: <1623141934-7699-1-git-send-email-faiyazm@codeaurora.org> From: Vlastimil Babka Subject: Re: [PATCH v11] mm: slub: move sysfs slab alloc/free interfaces to debugfs Message-ID: <78fc8848-bde8-769e-f8e9-6157d232a60f@suse.cz> Date: Tue, 8 Jun 2021 19:35:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/8/21 7:11 PM, Faiyaz Mohammed wrote: > > > On 6/8/2021 5:20 PM, Andy Shevchenko wrote: >> On Tue, Jun 8, 2021 at 11:45 AM Faiyaz Mohammed wrote: >>> >>> alloc_calls and free_calls implementation in sysfs have two issues, >>> one is PAGE_SIZE limitation of sysfs and other is it does not adhere >>> to "one value per file" rule. >>> >>> To overcome this issues, move the alloc_calls and free_calls >>> implementation to debugfs. >>> >>> Debugfs cache will be created if SLAB_STORE_USER flag is set. >>> >>> Rename the alloc_calls/free_calls to alloc_traces/free_traces, >>> to be inline with what it does. >>> >>> Signed-off-by: Faiyaz Mohammed >>> --- >> >> It seems you missed the version bump along with changelog. >> Note, some maintainers (actually quite many I think) are using tools >> to fetch up the patches and two patches with the same version is a >> problem. Hence I do not consider it a nit-pick. >> > Hmmm, I think to avoid same version problem I have to push same patch > with new version number and thank you for your patience. I *think* Andrew wouldn't have this issue, so maybe resend only if he says it's needed. On the other hand I did have troubles to apply the last version locally, patch (tool) complained of patch (file) being malformed at the end. Did you add or delete lines from it after generating the patch? I had to use the recountdiff tool to fix this. If you're going to resend, please make sure it's without the same issue. > Thanks and regards, > Mohammed Faiyaz >