From: "Clément Leger" <cleger@kalray.eu>
To: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-remoteproc <linux-remoteproc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remoteproc: Add support for predefined notifyids
Date: Wed, 15 Jan 2020 15:28:26 +0100 (CET) [thread overview]
Message-ID: <79048597.12371594.1579098506802.JavaMail.zimbra@kalray.eu> (raw)
In-Reply-To: <088ceab9-f135-6e70-dcf6-f75ec46110b1@st.com>
Hi Arnaud,
----- On 15 Jan, 2020, at 15:06, Arnaud Pouliquen arnaud.pouliquen@st.com wrote:
> Hi Clément,
>
> On 1/15/20 11:21 AM, Clement Leger wrote:
>> In order to support preallocated notify ids, if their value is
>> equal to FW_RSC_NOTIFY_ID_ANY, then do no allocate a notify id
>> dynamically but try to allocate the requested one. This is useful when
>> using custom ids to bind them to custom vendor resources. For instance,
>> it allow to assign a group of queues to a specific interrupti in order
>> to dispatch notifications.
>>
>> Signed-off-by: Clement Leger <cleger@kalray.eu>
>> ---
>> drivers/remoteproc/remoteproc_core.c | 27 +++++++++++++++++++--------
>> include/linux/remoteproc.h | 1 +
>> 2 files changed, 20 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/remoteproc/remoteproc_core.c
>> b/drivers/remoteproc/remoteproc_core.c
>> index 307df98347ba..b1485fcd0f11 100644
>> --- a/drivers/remoteproc/remoteproc_core.c
>> +++ b/drivers/remoteproc/remoteproc_core.c
>> @@ -351,14 +351,27 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
>> /*
>> * Assign an rproc-wide unique index for this vring
>> * TODO: assign a notifyid for rvdev updates as well
>> - * TODO: support predefined notifyids (via resource table)
>> */
>> - ret = idr_alloc(&rproc->notifyids, rvring, 0, 0, GFP_KERNEL);
>> - if (ret < 0) {
>> - dev_err(dev, "idr_alloc failed: %d\n", ret);
>> - return ret;
>> + if (rsc->vring[i].notifyid == FW_RSC_NOTIFY_ID_ANY) {
>> + ret = idr_alloc(&rproc->notifyids, rvring, 0, 0, GFP_KERNEL);
>> + if (ret < 0) {
>> + dev_err(dev, "idr_alloc failed: %d\n", ret);
>> + return ret;
>> + }
>> + notifyid = ret;
>> +
>> + /* Let the rproc know the notifyid of this vring.*/
>> + rsc->vring[i].notifyid = notifyid;
>> + } else {
>> + /* Reserve requested notify_id */
>> + notifyid = rsc->vring[i].notifyid;
>> + ret = idr_alloc(&rproc->notifyids, rvring, notifyid,
>> + notifyid + 1, GFP_KERNEL);
>> + if (ret < 0) {
>> + dev_err(dev, "idr_alloc failed: %d\n", ret);
>> + return ret;
>> + }
>> }
>> - notifyid = ret;
>>
>> /* Potentially bump max_notifyid */
>> if (notifyid > rproc->max_notifyid)
>> @@ -366,8 +379,6 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
>>
>> rvring->notifyid = notifyid;
>>
>> - /* Let the rproc know the notifyid of this vring.*/
>> - rsc->vring[i].notifyid = notifyid;
>> return 0;
>> }
> The rproc_free_vring function resets the notifyid to -1 on free.
> This could generate a side effect if the resource table is not reloaded.
Oh indeed, I did not thought of that. What would you recommend ?
If using -1 in free vring, notify ids will be reallocated at next
round.
I was also worried that it would break some existing user applications
which uses "0" as a notify id in vring but expect the id to be
allocated dynamically. With my modification, it means it will try to
use "0" as a predefined id, leading to allocation failure.
>
>>
>> diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
>> index 16ad66683ad0..dcae3394243e 100644
>> --- a/include/linux/remoteproc.h
>> +++ b/include/linux/remoteproc.h
>> @@ -123,6 +123,7 @@ enum fw_resource_type {
>> };
>>
>> #define FW_RSC_ADDR_ANY (-1)
>> +#define FW_RSC_NOTIFY_ID_ANY (-1)This define can also be used in
>> rproc_free_vring
Indeed.
Thanks for your review.
Regards,
Clément
>
> Regards,
> Arnaud
>>
>> /**
>> * struct fw_rsc_carveout - physically contiguous memory request
next prev parent reply other threads:[~2020-01-15 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 10:21 [PATCH] remoteproc: Add support for predefined notifyids Clement Leger
2020-01-15 14:06 ` Arnaud POULIQUEN
2020-01-15 14:28 ` Clément Leger [this message]
2020-01-15 15:09 ` Arnaud POULIQUEN
2020-01-15 15:11 ` Clément Leger
2020-01-17 22:52 ` Mathieu Poirier
2020-01-19 19:40 ` Clément Leger
2020-01-20 9:52 ` Arnaud POULIQUEN
2020-01-20 16:28 ` Mathieu Poirier
2020-01-20 19:10 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79048597.12371594.1579098506802.JavaMail.zimbra@kalray.eu \
--to=cleger@kalray.eu \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).