From: Waiman Long <longman@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Davidlohr Bueso <dave@stgolabs.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH-tip v2 00/12] locking/rwsem: Rwsem rearchitecture part 2
Date: Wed, 10 Apr 2019 08:38:24 -0400 [thread overview]
Message-ID: <79179601-6161-3745-b658-ae4d62a8ea0a@redhat.com> (raw)
In-Reply-To: <20190410100054.GA115532@gmail.com>
On 04/10/2019 06:00 AM, Ingo Molnar wrote:
> * Waiman Long <longman@redhat.com> wrote:
>
>> # of Threads Before Patch After Patch
>> ------------ ------------ -----------
>> 2 1,179 9,436
>> 4 1,505 8,268
>> 8 721 7,041
>> 16 575 7,652
>> 32 70 2,189
>> 64 39 534
>>
>> Waiman Long (12):
>> locking/rwsem: Implement a new locking scheme
>> locking/rwsem: Implement lock handoff to prevent lock starvation
>> locking/rwsem: Remove rwsem_wake() wakeup optimization
>> locking/rwsem: Make rwsem_spin_on_owner() return owner state
>> locking/rwsem: Ensure an RT task will not spin on reader
>> locking/rwsem: Wake up almost all readers in wait queue
>> locking/rwsem: Enable readers spinning on writer
>> locking/rwsem: Enable time-based spinning on reader-owned rwsem
>> locking/rwsem: Add more rwsem owner access helpers
>> locking/rwsem: Guard against making count negative
>> locking/rwsem: Merge owner into count on x86-64
>> locking/rwsem: Remove redundant computation of writer lock word
>>
>> kernel/locking/lock_events_list.h | 4 +
>> kernel/locking/rwsem-xadd.c | 635 +++++++++++++++++++-----------
>> kernel/locking/rwsem.c | 3 +-
>> kernel/locking/rwsem.h | 290 +++++++++++---
>> 4 files changed, 647 insertions(+), 285 deletions(-)
> Looks very nice!
>
> With both sets of patches applied they pass all x86 tests, but there's
> cross-build failures on powerpc32, sparc32 and UML:
>
> kernel/locking/rwsem.h:333:34: error: 'struct rw_semaphore' has no member named 'owner'
>
> Could you please send a delta patch against tip:WIP.locking/core, which
> is the work-in-progress tree? I'll backmerge the delta patch (and any
> other updates you might have meanwhil) to the one that introduces the
> breakage.
>
> Thanks,
>
> Ingo
Sure. I will look into that and fix failures.
Thanks,
Longman
prev parent reply other threads:[~2019-04-10 12:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 19:21 [PATCH-tip v2 00/12] locking/rwsem: Rwsem rearchitecture part 2 Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 01/12] locking/rwsem: Implement a new locking scheme Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 02/12] locking/rwsem: Implement lock handoff to prevent lock starvation Waiman Long
2019-04-10 15:07 ` Peter Zijlstra
2019-04-10 15:28 ` Waiman Long
2019-04-10 15:10 ` Peter Zijlstra
2019-04-10 15:29 ` Waiman Long
2019-04-10 18:44 ` Peter Zijlstra
2019-04-11 2:25 ` Waiman Long
2019-04-11 7:16 ` Peter Zijlstra
2019-04-05 19:21 ` [PATCH-tip v2 03/12] locking/rwsem: Remove rwsem_wake() wakeup optimization Waiman Long
2019-04-10 18:38 ` Davidlohr Bueso
2019-04-05 19:21 ` [PATCH-tip v2 04/12] locking/rwsem: Make rwsem_spin_on_owner() return owner state Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 05/12] locking/rwsem: Ensure an RT task will not spin on reader Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 06/12] locking/rwsem: Wake up almost all readers in wait queue Waiman Long
2019-04-10 16:50 ` Davidlohr Bueso
2019-04-10 17:08 ` Waiman Long
2019-04-10 17:22 ` Davidlohr Bueso
2019-04-10 17:31 ` Davidlohr Bueso
2019-04-10 17:54 ` Waiman Long
2019-04-10 17:53 ` Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 07/12] locking/rwsem: Enable readers spinning on writer Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 08/12] locking/rwsem: Enable time-based spinning on reader-owned rwsem Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 09/12] locking/rwsem: Add more rwsem owner access helpers Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 10/12] locking/rwsem: Guard against making count negative Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 11/12] locking/rwsem: Merge owner into count on x86-64 Waiman Long
2019-04-05 19:21 ` [PATCH-tip v2 12/12] locking/rwsem: Remove redundant computation of writer lock word Waiman Long
2019-04-05 23:27 ` [PATCH-tip v2 00/12] locking/rwsem: Rwsem rearchitecture part 2 Linus Torvalds
2019-04-10 10:00 ` Ingo Molnar
2019-04-10 12:38 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79179601-6161-3745-b658-ae4d62a8ea0a@redhat.com \
--to=longman@redhat.com \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).