From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091AbcICMjZ (ORCPT ); Sat, 3 Sep 2016 08:39:25 -0400 Received: from mout.web.de ([212.227.15.3]:49325 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434AbcICMjX (ORCPT ); Sat, 3 Sep 2016 08:39:23 -0400 Subject: [PATCH 16/17] s390/debug: Improve determination of sizes in debug_info_alloc() To: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , Martin Schwidefsky References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <79188cdc-317f-7abd-d543-7d4935a3c41d@users.sourceforge.net> Date: Sat, 3 Sep 2016 14:38:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qC42HOHxXVBDE5J9M7RKouTRNcOhnHWJr1LTBW3HDGK3DTOXb2o 0QXwKVaVTf7iqjsjyhr1kLb+BoaX85CHAuvUU+h/b+EJz5AXRff1fwZbkpMjZJxx4FaRvBR 9ojsKRXP/MiBXDarRHs9ld4ShFZn9IeA3ZlLa2i/UvKMbYzYfFJ9ziEue1XPNdDfNaVAh8V /sG0Hf6MXeGBAOu/TMPEw== X-UI-Out-Filterresults: notjunk:1;V01:K0:KlwYEBvH3uI=:VNIbrv9BfMRqkbmu449zl+ zRNPT7RPyPJNmbqXHdwvdO3WNhGbOwLqQmxQCCXOB8GV1OblFI5fxKLGhrYvuLth6Rnom/rdZ TZip6XJFSRmAdtSg0mjQqs/63zZMLafHfWgNnD7XxZZjjX2/Fx2Qe8ujVDO6UusFgNGrXdtJb nfZU6asofawjcI1n/+1p/YfkirUi3bmfntXBtGJlwaRdqGjFGz+Qt/A42g+V51+0Oco2bbi/E 5LOsA8+/MFq153DTMV7fc9vngNSqqHKF9cfVSKG2M6tY+Y3qtA5jmA8kmORyg7OgzL1JGLl+V ohI67Trdc/r7nPNdv3gWQDvVnZeU057HQ1vBlpm7jIBNvtedSMMzoukQOQ1gg7gsHBLgMy4w7 2mDwdygDvaZ+8XRJibHultdCs219AwgYOuqNGXXtFhphCaNCZ9e1Dgl5Mwo6yeRDaIGO/es/O K4cuyhDMQPZvcei5lmeg0bwHqaYyR4HyePm6HC3kRuyI5DV3G//OGQAiBy5jZs5FnJ5/4p4wU 5l2cJCSpP3sBATMNENCFwlY/fs9JaXDTF0DgEOtuDjQy5etJ0wa6Heu01MPSW8jIGHcF+MdZP s6atn7ZcKQssrTSUyYf8+GLKM7/9wunJT94rJ5JUROr3KIoob/Ojc0TH8N+XzGEYFA5xGUCrg SPVGcsaxF8t/IfD/ZXpaMTyC7T7bvqAZl2vFlxmdqKKQFKalV0RAeDLgr3qFJIg2Io8XpfvPJ iedO8yeKXUmNxByy3qtpJ1iYMbF1OHofFyRpPeKKo/Yn4olrXfEc7TT+Zw7rV1BUHXPcUTBQr r0vi/fC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 2 Sep 2016 14:39:00 +0200 * Replace two multiplications by references for an array in a local data structure as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. * Improve source code layout for one function call. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index ff8e705..408a8da 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c @@ -269,9 +269,8 @@ debug_info_alloc(const char *name, int pages_per_area, int nr_areas, rc->buf_size = buf_size; rc->entry_size = sizeof(debug_entry_t) + buf_size; strlcpy(rc->name, name, sizeof(rc->name)); - memset(rc->views, 0, DEBUG_MAX_VIEWS * sizeof(struct debug_view *)); - memset(rc->debugfs_entries, 0, DEBUG_MAX_VIEWS * - sizeof(struct dentry*)); + memset(rc->views, 0, sizeof(rc->views)); + memset(rc->debugfs_entries, 0, sizeof(rc->debugfs_entries)); atomic_set(&(rc->ref_count), 0); return rc; -- 2.9.3