From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, bjorn.andersson@linaro.org,
jassisinghbrar@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: mailbox: set correct #clock-cells
Date: Fri, 29 Apr 2022 22:47:43 +0200 [thread overview]
Message-ID: <791bb7a7-a717-7d86-eca4-3a270e6b3d0f@linaro.org> (raw)
In-Reply-To: <20220429114330.59026-5-robimarko@gmail.com>
On 29/04/2022 13:43, Robert Marko wrote:
> IPQ6018 and IPQ8074 require #clock-cells to be set to 1 as their APSS
> clock driver provides multiple clock outputs.
>
> So allow setting 1 as #clock-cells and check that its set to 1 for IPQ6018
> and IPQ8074, check others for 0 as its currently.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> .../mailbox/qcom,apcs-kpss-global.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
With the changes asked by Jassi:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-29 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 11:43 [PATCH 1/6] clk: qcom: clk-alpha-pll: add support for APSS PLL Robert Marko
2022-04-29 11:43 ` [PATCH 2/6] clk: qcom: Add DT bindings for IPQ8074 APSS clock controller Robert Marko
2022-04-29 20:45 ` Krzysztof Kozlowski
2022-04-29 21:56 ` Robert Marko
2022-04-30 11:38 ` Krzysztof Kozlowski
2022-04-29 11:43 ` [PATCH 3/6] clk: qcom: Add " Robert Marko
2022-04-29 11:43 ` [PATCH 4/6] mailbox: qcom-apcs-ipc: add IPQ8074 APSS clock controller support Robert Marko
2022-04-29 11:43 ` [PATCH 5/6] dt-bindings: mailbox: set correct #clock-cells Robert Marko
2022-04-29 15:39 ` Jassi Brar
2022-04-29 16:02 ` Robert Marko
2022-04-29 20:47 ` Krzysztof Kozlowski [this message]
2022-04-29 11:43 ` [PATCH 6/6] arm64: dts: ipq8074: update APCS node due to clock support Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=791bb7a7-a717-7d86-eca4-3a270e6b3d0f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).