* [PATCH 0/4] Enable eDP display on rk3399 evb.
@ 2020-03-05 11:39 Andy Yan
2020-03-05 11:39 ` [PATCH 1/4] arm64: dts: rockchip: remove dvs2 pinctrl for pmic " Andy Yan
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Andy Yan @ 2020-03-05 11:39 UTC (permalink / raw)
To: heiko, robh+dt, devicetree, linux-rockchip
Cc: linux-kernel, linux-arm-kernel, Andy Yan
When I try to test a patch for eDP on mainline, I found there is no
display suport for this board. So I try to add all the releated things
for it.
Andy Yan (4):
arm64: dts: rockchip: remove dvs2 pinctrl for pmic on rk3399 evb
arm64: dts: rockchip: Add pmic dt tree for rk3399 evb
arm64: dts: rockchip: remove enable-gpio of backlight on rk3399 evb
arm64: dts: rockchip: Enable eDP display on rk3399 evb
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 267 +++++++++++++++++++-
1 file changed, 261 insertions(+), 6 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/4] arm64: dts: rockchip: remove dvs2 pinctrl for pmic on rk3399 evb
2020-03-05 11:39 [PATCH 0/4] Enable eDP display on rk3399 evb Andy Yan
@ 2020-03-05 11:39 ` Andy Yan
2020-03-05 21:38 ` Heiko Stübner
2020-03-05 11:39 ` [PATCH 2/4] arm64: dts: rockchip: Add pmic dt tree for " Andy Yan
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Andy Yan @ 2020-03-05 11:39 UTC (permalink / raw)
To: heiko, robh+dt, devicetree, linux-rockchip
Cc: linux-kernel, linux-arm-kernel, Andy Yan
DVS2 of pmic is connected to GND, no pinctrl for it.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
index 77008dca45bc..eb501bb8f426 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
@@ -210,11 +210,6 @@
rockchip,pins =
<1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
};
-
- pmic_dvs2: pmic-dvs2 {
- rockchip,pins =
- <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_down>;
- };
};
usb2 {
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/4] arm64: dts: rockchip: Add pmic dt tree for rk3399 evb
2020-03-05 11:39 [PATCH 0/4] Enable eDP display on rk3399 evb Andy Yan
2020-03-05 11:39 ` [PATCH 1/4] arm64: dts: rockchip: remove dvs2 pinctrl for pmic " Andy Yan
@ 2020-03-05 11:39 ` Andy Yan
2020-03-05 23:46 ` Heiko Stuebner
2020-03-05 11:39 ` [PATCH 3/4] arm64: dts: rockchip: remove enable-gpio of backlight on " Andy Yan
2020-03-05 11:39 ` [PATCH 4/4] arm64: dts: rockchip: Enable eDP display " Andy Yan
3 siblings, 1 reply; 9+ messages in thread
From: Andy Yan @ 2020-03-05 11:39 UTC (permalink / raw)
To: heiko, robh+dt, devicetree, linux-rockchip
Cc: linux-kernel, linux-arm-kernel, Andy Yan
RK3399 EVB use 2 SYR837/8 and a RK808 for power supply,
Add regulator tree for it.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 221 ++++++++++++++++++++
1 file changed, 221 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
index eb501bb8f426..af6e23568504 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
@@ -134,6 +134,227 @@
status = "okay";
};
+&i2c0 {
+ status = "okay";
+ vdd_cpu_b: syr827@40 {
+ compatible = "silergy,syr827";
+ reg = <0x40>;
+ vin-supply = <&vcc5v0_sys>;
+ regulator-name = "vdd_cpu_b";
+ regulator-min-microvolt = <712500>;
+ regulator-max-microvolt = <1500000>;
+ regulator-ramp-delay = <1000>;
+ fcs,suspend-voltage-selector = <1>;
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-initial-state = <3>;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_gpu: syr828@41 {
+ compatible = "silergy,syr828";
+ reg = <0x41>;
+ vin-supply = <&vcc5v0_sys>;
+ regulator-name = "vdd_gpu";
+ regulator-min-microvolt = <712500>;
+ regulator-max-microvolt = <1500000>;
+ regulator-ramp-delay = <1000>;
+ fcs,suspend-voltage-selector = <1>;
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-initial-state = <3>;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ rk808: pmic@1b {
+ compatible = "rockchip,rk808";
+ reg = <0x1b>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmic_int_l>;
+ rockchip,system-power-controller;
+ wakeup-source;
+ #clock-cells = <1>;
+ clock-output-names = "rk808-clkout1", "rk808-clkout2";
+
+ vcc1-supply = <&vcc3v3_sys>;
+ vcc2-supply = <&vcc3v3_sys>;
+ vcc3-supply = <&vcc3v3_sys>;
+ vcc4-supply = <&vcc3v3_sys>;
+ vcc6-supply = <&vcc3v3_sys>;
+ vcc7-supply = <&vcc3v3_sys>;
+ vcc8-supply = <&vcc3v3_sys>;
+ vcc9-supply = <&vcc3v3_sys>;
+ vcc10-supply = <&vcc3v3_sys>;
+ vcc11-supply = <&vcc3v3_sys>;
+ vcc12-supply = <&vcc3v3_sys>;
+ vddio-supply = <&vcc1v8_pmu>;
+
+ regulators {
+ vdd_log: DCDC_REG1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-ramp-delay = <6001>;
+ regulator-name = "vdd_log";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <900000>;
+ };
+ };
+
+ vdd_cpu_l: DCDC_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-ramp-delay = <6001>;
+ regulator-name = "vdd_cpu_l";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_ddr: DCDC_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vcc_ddr";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+
+ vcc_1v8: DCDC_REG4 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc_1v8";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1800000>;
+ };
+ };
+
+ vcc1v8_dvp: LDO_REG1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc1v8_dvp";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc3v0_tp: LDO_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-name = "vcc3v0_tp";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc1v8_pmu: LDO_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc1v8_pmu";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1800000>;
+ };
+ };
+
+ vcc_sd: LDO_REG4 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-name = "vcc_sd";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3000000>;
+ };
+ };
+
+ vcca3v0_codec: LDO_REG5 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-name = "vcca3v0_codec";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_1v5: LDO_REG6 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-name = "vcc_1v5";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1500000>;
+ };
+ };
+
+ vcca1v8_codec: LDO_REG7 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcca1v8_codec";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_3v0: LDO_REG8 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-name = "vcc_3v0";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3000000>;
+ };
+ };
+
+ vcc3v3_s3: SWITCH_REG1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vcc3v3_s3";
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+
+ vcc3v3_s0: SWITCH_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-name = "vcc3v3_s0";
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+ };
+ };
+};
+
&pwm0 {
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/4] arm64: dts: rockchip: remove enable-gpio of backlight on rk3399 evb
2020-03-05 11:39 [PATCH 0/4] Enable eDP display on rk3399 evb Andy Yan
2020-03-05 11:39 ` [PATCH 1/4] arm64: dts: rockchip: remove dvs2 pinctrl for pmic " Andy Yan
2020-03-05 11:39 ` [PATCH 2/4] arm64: dts: rockchip: Add pmic dt tree for " Andy Yan
@ 2020-03-05 11:39 ` Andy Yan
2020-03-05 23:50 ` Heiko Stuebner
2020-03-05 11:39 ` [PATCH 4/4] arm64: dts: rockchip: Enable eDP display " Andy Yan
3 siblings, 1 reply; 9+ messages in thread
From: Andy Yan @ 2020-03-05 11:39 UTC (permalink / raw)
To: heiko, robh+dt, devicetree, linux-rockchip
Cc: linux-kernel, linux-arm-kernel, Andy Yan
There is no enable-gpio for backlight control on rk3399 evb,
actually GPIO1_B5 is for LCD panle enable. So remove it from backlight
dt node.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
index af6e23568504..d4e402b40d08 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
@@ -48,7 +48,6 @@
240 241 242 243 244 245 246 247
248 249 250 251 252 253 254 255>;
default-brightness-level = <200>;
- enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
pwms = <&pwm0 0 25000 0>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/4] arm64: dts: rockchip: Enable eDP display on rk3399 evb
2020-03-05 11:39 [PATCH 0/4] Enable eDP display on rk3399 evb Andy Yan
` (2 preceding siblings ...)
2020-03-05 11:39 ` [PATCH 3/4] arm64: dts: rockchip: remove enable-gpio of backlight on " Andy Yan
@ 2020-03-05 11:39 ` Andy Yan
2020-03-05 23:51 ` Heiko Stuebner
3 siblings, 1 reply; 9+ messages in thread
From: Andy Yan @ 2020-03-05 11:39 UTC (permalink / raw)
To: heiko, robh+dt, devicetree, linux-rockchip
Cc: linux-kernel, linux-arm-kernel, Andy Yan
Add eDP panle and enable relative dt node like vop/iommu
to enable eDP display on rk3399 evb.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 40 +++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
index d4e402b40d08..23e213c421d0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
@@ -51,6 +51,19 @@
pwms = <&pwm0 0 25000 0>;
};
+ edp_panel: edp-panel {
+ compatible ="lg,lp079qx1-sp0v";
+ backlight = <&backlight>;
+ power-supply = <&vcc3v3_s0>;
+ enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
+
+ port {
+ panel_in_edp: endpoint {
+ remote-endpoint = <&edp_out_panel>;
+ };
+ };
+ };
+
clkin_gmac: external-gmac-clock {
compatible = "fixed-clock";
clock-frequency = <125000000>;
@@ -113,6 +126,24 @@
};
+&edp {
+ status = "okay";
+ force-hpd;
+
+ ports {
+ edp_out: port@1 {
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ edp_out_panel: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&panel_in_edp>;
+ };
+ };
+ };
+};
+
&emmc_phy {
status = "okay";
};
@@ -439,3 +470,12 @@
};
};
};
+
+&vopb {
+ status = "okay";
+};
+
+&vopb_mmu {
+ status = "okay";
+};
+
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] arm64: dts: rockchip: remove dvs2 pinctrl for pmic on rk3399 evb
2020-03-05 11:39 ` [PATCH 1/4] arm64: dts: rockchip: remove dvs2 pinctrl for pmic " Andy Yan
@ 2020-03-05 21:38 ` Heiko Stübner
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Stübner @ 2020-03-05 21:38 UTC (permalink / raw)
To: Andy Yan
Cc: robh+dt, devicetree, linux-rockchip, linux-kernel, linux-arm-kernel
Am Donnerstag, 5. März 2020, 12:39:09 CET schrieb Andy Yan:
> DVS2 of pmic is connected to GND, no pinctrl for it.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
applied for 5.7
Thanks
Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/4] arm64: dts: rockchip: Add pmic dt tree for rk3399 evb
2020-03-05 11:39 ` [PATCH 2/4] arm64: dts: rockchip: Add pmic dt tree for " Andy Yan
@ 2020-03-05 23:46 ` Heiko Stuebner
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2020-03-05 23:46 UTC (permalink / raw)
To: Andy Yan
Cc: robh+dt, devicetree, linux-rockchip, linux-kernel, linux-arm-kernel
Am Donnerstag, 5. März 2020, 12:39:10 CET schrieb Andy Yan:
> RK3399 EVB use 2 SYR837/8 and a RK808 for power supply,
> Add regulator tree for it.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
I applied this for 5.7 after fixing quite a number of issues
- spaces instead of tabs in one syr
- odering of nodes and properties
- node names
Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/4] arm64: dts: rockchip: remove enable-gpio of backlight on rk3399 evb
2020-03-05 11:39 ` [PATCH 3/4] arm64: dts: rockchip: remove enable-gpio of backlight on " Andy Yan
@ 2020-03-05 23:50 ` Heiko Stuebner
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2020-03-05 23:50 UTC (permalink / raw)
To: Andy Yan
Cc: robh+dt, devicetree, linux-rockchip, linux-kernel, linux-arm-kernel
Am Donnerstag, 5. März 2020, 12:39:11 CET schrieb Andy Yan:
> There is no enable-gpio for backlight control on rk3399 evb,
> actually GPIO1_B5 is for LCD panle enable. So remove it from backlight
> dt node.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
applied for 5.7
Thanks
Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] arm64: dts: rockchip: Enable eDP display on rk3399 evb
2020-03-05 11:39 ` [PATCH 4/4] arm64: dts: rockchip: Enable eDP display " Andy Yan
@ 2020-03-05 23:51 ` Heiko Stuebner
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2020-03-05 23:51 UTC (permalink / raw)
To: Andy Yan
Cc: robh+dt, devicetree, linux-rockchip, linux-kernel, linux-arm-kernel
Am Donnerstag, 5. März 2020, 12:39:12 CET schrieb Andy Yan:
> Add eDP panle and enable relative dt node like vop/iommu
> to enable eDP display on rk3399 evb.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
applied for 5.7 - after removing the added blank line at the end
of the file
Thanks
Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-03-05 23:51 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 11:39 [PATCH 0/4] Enable eDP display on rk3399 evb Andy Yan
2020-03-05 11:39 ` [PATCH 1/4] arm64: dts: rockchip: remove dvs2 pinctrl for pmic " Andy Yan
2020-03-05 21:38 ` Heiko Stübner
2020-03-05 11:39 ` [PATCH 2/4] arm64: dts: rockchip: Add pmic dt tree for " Andy Yan
2020-03-05 23:46 ` Heiko Stuebner
2020-03-05 11:39 ` [PATCH 3/4] arm64: dts: rockchip: remove enable-gpio of backlight on " Andy Yan
2020-03-05 23:50 ` Heiko Stuebner
2020-03-05 11:39 ` [PATCH 4/4] arm64: dts: rockchip: Enable eDP display " Andy Yan
2020-03-05 23:51 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).