From: Dmitry Osipenko <digetx@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>, Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mfd: tps6586x: Handle interrupts on suspend
Date: Sun, 21 Oct 2018 00:18:02 +0300 [thread overview]
Message-ID: <79285505-02de-5616-0c95-87586e4a8919@gmail.com> (raw)
In-Reply-To: <1539955373-13735-1-git-send-email-jonathanh@nvidia.com>
On 10/19/18 4:22 PM, Jon Hunter wrote:
> From: Jonathan Hunter <jonathanh@nvidia.com>
>
> The tps6586x driver creates an irqchip that is used by its various child
> devices for managing interrupts. The tps6586x-rtc device is one of its
> children that uses the tps6586x irqchip. When using the tps6586x-rtc as
> a wake-up device from suspend, the following is seen:
>
> PM: Syncing filesystems ... done.
> Freezing user space processes ... (elapsed 0.001 seconds) done.
> OOM killer disabled.
> Freezing remaining freezable tasks ... (elapsed 0.000 seconds) done.
> Disabling non-boot CPUs ...
> Entering suspend state LP1
> Enabling non-boot CPUs ...
> CPU1 is up
> tps6586x 3-0034: failed to read interrupt status
> tps6586x 3-0034: failed to read interrupt status
>
> The reason why the tps6586x interrupt status cannot be read is because
> the tps6586x interrupt is not masked during suspend and when the
> tps6586x-rtc interrupt occurs, to wake-up the device, the interrupt is
> seen before the i2c controller has been resumed in order to read the
> tps6586x interrupt status.
>
> The tps6586x-rtc driver sets it's interrupt as a wake-up source during
> suspend, which gets propagated to the parent tps6586x interrupt.
> However, the tps6586x-rtc driver cannot disable it's interrupt during
> suspend otherwise we would never be woken up and so the tps6586x must
> disable it's interrupt instead.
>
> Prevent the tps6586x interrupt handler from executing on exiting suspend
> before the i2c controller has been resumed by disabling the tps6586x
> interrupt on entering suspend and re-enabling it on resuming from
> suspend.
>
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
Tested patch on linux-next and v4.14, works fine. Thank you!
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2018-10-20 21:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 13:22 [PATCH] mfd: tps6586x: Handle interrupts on suspend Jon Hunter
2018-10-20 21:18 ` Dmitry Osipenko [this message]
2018-10-22 9:52 ` Thierry Reding
2018-10-22 11:19 ` Dmitry Osipenko
2018-10-24 10:49 ` Jon Hunter
2018-10-24 12:44 ` Dmitry Osipenko
2018-10-24 14:19 ` Jon Hunter
2018-10-25 13:01 ` Dmitry Osipenko
2018-10-24 10:41 ` Jon Hunter
2018-10-29 9:53 ` Thierry Reding
2018-11-05 11:24 ` Jon Hunter
2018-11-13 7:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79285505-02de-5616-0c95-87586e4a8919@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).