From: Luca Ceresoli <luca@lucaceresoli.net>
To: Chunyou Tang <tangchunyou@163.com>, Joe Perches <joe@perches.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
akpm@linux-foundation.org, colin.king@canonical.com,
xndchn@gmail.com, j.neuschaefer@gmx.net,
naoki.hayama@lineo.co.jp, ebiggers@google.com, sjpark@amazon.de,
linux-kernel@vger.kernel.org, zhangwen@yulong.com,
tangchunyou@yulong.com
Subject: Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking
Date: Thu, 21 Jan 2021 09:41:39 +0100 [thread overview]
Message-ID: <7937a406-812e-0a41-12c5-41576737a44f@lucaceresoli.net> (raw)
In-Reply-To: <20210121112115.00005cb6@163.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=gb18030, Size: 1209 bytes --]
Hi,
On 21/01/21 04:21, Chunyou Tang wrote:
> On Wed, 20 Jan 2021 19:09:05 -0800
> Joe Perches <joe@perches.com> wrote:
>
>> On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote:
>>> On 1/20/21 6:07 PM, ChunyouTang wrote:
>>>> From: tangchunyou <tangchunyou@yulong.com>
>>>>
>>>> Increase direcly,maping,manger spelling error check
>>>
>>> Hi,
>>> I don't see all of those in the patch below.
>>> What happened?
>>
>> I think mostly it's just a poor commit message as
>> direcly and manger are already in spelling.txt
>>
>>>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
>> []
>>>> @@ -875,6 +875,7 @@ manger||manager
>>>> 0„2manoeuvering||maneuvering
>>>> 0„2manufaucturing||manufacturing
>>>> 0„2mappping||mapping
>>>> +maping||mapping
>>>> 0„2matchs||matches
>>>> 0„2mathimatical||mathematical
>>>> 0„2mathimatic||mathematic
>>
>
> yes,you are right,the commit message is bad,I change the commit message
>
> and resend it.
While doing that, also improve the subject (1st line of commit message)
by mentioning the typo you are adding. For example, as in previous commits:
scripts/spelling.txt: add "maping" typo
It's more informative and even shorter.
Thanks
--
Luca
next prev parent reply other threads:[~2021-01-21 8:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 2:07 [PATCH] scripts/spelling.txt: increase error-prone spell checking ChunyouTang
2021-01-21 3:02 ` Randy Dunlap
2021-01-21 3:09 ` Joe Perches
[not found] ` <20210121112115.00005cb6@163.com>
2021-01-21 8:41 ` Luca Ceresoli [this message]
2021-01-21 9:14 ` Naoki Hayama
2021-01-21 9:36 ` Joe Perches
2021-01-21 9:49 ` Naoki Hayama
2021-01-27 3:01 dingsenjie
2021-01-27 7:47 ` SeongJae Park
2021-01-27 6:00 zuoqilin1
2021-01-27 7:55 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7937a406-812e-0a41-12c5-41576737a44f@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=ebiggers@google.com \
--cc=j.neuschaefer@gmx.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naoki.hayama@lineo.co.jp \
--cc=rdunlap@infradead.org \
--cc=sjpark@amazon.de \
--cc=tangchunyou@163.com \
--cc=tangchunyou@yulong.com \
--cc=xndchn@gmail.com \
--cc=zhangwen@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).