* [PATCH] "blk: request botched" error on floppy write
@ 2003-07-19 18:37 Sean
2003-07-21 12:33 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Sean @ 2003-07-19 18:37 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
The floppy drive appears to be working for some people with the
2.6 kernel as is. However, there have also been reports of some
problems (see http://bugme.osdl.org/show_bug.cgi?id=654 )
The attached patch against 2.6.0-test1 fixes the problem on all the
machines i've tested.
Cheers,
Sean
[-- Attachment #2: floppy_req_botched.patch --]
[-- Type: application/octet-stream, Size: 387 bytes --]
--- test1/drivers/block/floppy.c.old Sat Jul 19 13:48:18 2003
+++ test1/drivers/block/floppy.c Sat Jul 19 13:52:07 2003
@@ -4261,6 +4261,7 @@
floppy_sizes[i] = MAX_DISK_SIZE << 1;
blk_init_queue(&floppy_queue, do_fd_request, &floppy_lock);
+ blk_queue_max_hw_segments(&floppy_queue, 1);
reschedule_timeout(MAXTIMEOUT, "floppy init", MAXTIMEOUT);
config_types();
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] "blk: request botched" error on floppy write
2003-07-19 18:37 [PATCH] "blk: request botched" error on floppy write Sean
@ 2003-07-21 12:33 ` Jens Axboe
2003-07-21 12:39 ` Mr. James W. Laferriere
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2003-07-21 12:33 UTC (permalink / raw)
To: Sean; +Cc: linux-kernel
On Sat, Jul 19 2003, Sean wrote:
> The floppy drive appears to be working for some people with the
> 2.6 kernel as is. However, there have also been reports of some
> problems (see http://bugme.osdl.org/show_bug.cgi?id=654 )
>
> The attached patch against 2.6.0-test1 fixes the problem on all the
> machines i've tested.
So floppy has a problem with clustered requests? Your patch doesn't fix
that bug, it masks it.
Question is, if we should just accept that and move on. I mean, who
really cares?
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] "blk: request botched" error on floppy write
2003-07-21 12:33 ` Jens Axboe
@ 2003-07-21 12:39 ` Mr. James W. Laferriere
2003-07-21 13:36 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Mr. James W. Laferriere @ 2003-07-21 12:39 UTC (permalink / raw)
To: Jens Axboe; +Cc: Sean, linux-kernel
Hello Jens , If it is fixable , ME !-) . Tnx , JimL
On Mon, 21 Jul 2003, Jens Axboe wrote:
> On Sat, Jul 19 2003, Sean wrote:
> > The floppy drive appears to be working for some people with the
> > 2.6 kernel as is. However, there have also been reports of some
> > problems (see http://bugme.osdl.org/show_bug.cgi?id=654 )
> >
> > The attached patch against 2.6.0-test1 fixes the problem on all the
> > machines i've tested.
>
> So floppy has a problem with clustered requests? Your patch doesn't fix
> that bug, it masks it.
>
> Question is, if we should just accept that and move on. I mean, who
> really cares?
>
>
--
+------------------------------------------------------------------+
| James W. Laferriere | System Techniques | Give me VMS |
| Network Engineer | P.O. Box 854 | Give me Linux |
| babydr@baby-dragons.com | Coudersport PA 16915 | only on AXP |
+------------------------------------------------------------------+
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] "blk: request botched" error on floppy write
2003-07-21 12:39 ` Mr. James W. Laferriere
@ 2003-07-21 13:36 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2003-07-21 13:36 UTC (permalink / raw)
To: Mr. James W. Laferriere; +Cc: Sean, linux-kernel
On Mon, Jul 21 2003, Mr. James W. Laferriere wrote:
> Hello Jens , If it is fixable , ME !-) . Tnx , JimL
So where's the fix and what is the bug?
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-07-21 13:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-19 18:37 [PATCH] "blk: request botched" error on floppy write Sean
2003-07-21 12:33 ` Jens Axboe
2003-07-21 12:39 ` Mr. James W. Laferriere
2003-07-21 13:36 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).