[PATCH] "blk: request botched" error on floppy write

[PATCH] "blk: request botched" error on floppy write

[Sean]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

The floppy drive appears to be working for some people with the 
2.6 kernel as is.  However, there have also been reports of some
problems (see http://bugme.osdl.org/show_bug.cgi?id=654 )

The attached patch against 2.6.0-test1 fixes the problem on all the 
machines i've tested.

Cheers,
Sean

[-- Attachment #2: floppy_req_botched.patch --]
[-- Type: application/octet-stream, Size: 387 bytes --]

--- test1/drivers/block/floppy.c.old	Sat Jul 19 13:48:18 2003
+++ test1/drivers/block/floppy.c	Sat Jul 19 13:52:07 2003
@@ -4261,6 +4261,7 @@
 			floppy_sizes[i] = MAX_DISK_SIZE << 1;
 
 	blk_init_queue(&floppy_queue, do_fd_request, &floppy_lock);
+	blk_queue_max_hw_segments(&floppy_queue, 1); 
 	reschedule_timeout(MAXTIMEOUT, "floppy init", MAXTIMEOUT);
 	config_types();
 

Re: [PATCH] "blk: request botched" error on floppy write

[Jens Axboe]

On Sat, Jul 19 2003, Sean wrote:
> The floppy drive appears to be working for some people with the 
> 2.6 kernel as is.  However, there have also been reports of some
> problems (see http://bugme.osdl.org/show_bug.cgi?id=654 )
> 
> The attached patch against 2.6.0-test1 fixes the problem on all the 
> machines i've tested.

So floppy has a problem with clustered requests? Your patch doesn't fix
that bug, it masks it.

Question is, if we should just accept that and move on. I mean, who
really cares?

-- 
Jens Axboe

Re: [PATCH] "blk: request botched" error on floppy write

[Mr. James W. Laferriere]

	Hello Jens ,  If it is fixable ,  ME !-) .  Tnx ,  JimL

On Mon, 21 Jul 2003, Jens Axboe wrote:
> On Sat, Jul 19 2003, Sean wrote:
> > The floppy drive appears to be working for some people with the
> > 2.6 kernel as is.  However, there have also been reports of some
> > problems (see http://bugme.osdl.org/show_bug.cgi?id=654 )
> >
> > The attached patch against 2.6.0-test1 fixes the problem on all the
> > machines i've tested.
>
> So floppy has a problem with clustered requests? Your patch doesn't fix
> that bug, it masks it.
>
> Question is, if we should just accept that and move on. I mean, who
> really cares?
>
>

-- 
       +------------------------------------------------------------------+
       | James   W.   Laferriere | System    Techniques | Give me VMS     |
       | Network        Engineer |     P.O. Box 854     |  Give me Linux  |
       | babydr@baby-dragons.com | Coudersport PA 16915 |   only  on  AXP |
       +------------------------------------------------------------------+

Re: [PATCH] "blk: request botched" error on floppy write

[Jens Axboe]

On Mon, Jul 21 2003, Mr. James W. Laferriere wrote:
> 	Hello Jens ,  If it is fixable ,  ME !-) .  Tnx ,  JimL

So where's the fix and what is the bug?

-- 
Jens Axboe