From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F5FC4338F for ; Wed, 25 Aug 2021 09:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5166E61165 for ; Wed, 25 Aug 2021 09:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239613AbhHYJ43 (ORCPT ); Wed, 25 Aug 2021 05:56:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234372AbhHYJ41 (ORCPT ); Wed, 25 Aug 2021 05:56:27 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A7E5C061757 for ; Wed, 25 Aug 2021 02:55:42 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id p38so51805693lfa.0 for ; Wed, 25 Aug 2021 02:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZuRtowUJOs608UZxn9IiIdQ8Fj+noUUsQnyhszsaqJE=; b=aMleZF1Ow+5j/0iRi+FlFa7P3Sg7PfcadR6MXWYarALpDZrCTqNTTpdxnvexOg0MqW lQGoN3wcK+qW31kCr5LAc0BxdgGQCnyev0zvT4n8Fwklb1dk8/dVzIKpMmoXmZk00TgJ 2kJgYL/LodXM/N3PpBi595zNEduT6E7u/TnIGMcEuinOAwLDqOJJHpj9+V2Yflp+nSPz JqdOeNFD7mbuaKMzPsXOfu76m/geatgY2nHMHpQevn6/shjF70l7tT1+LlFAGN8NOup2 CL2/ootCunbM5C7xEeqbTESrW9VeNC6QwAnXpODD7YcyMYtGIqNsAnd3kwIRxgsDSkNE K4zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZuRtowUJOs608UZxn9IiIdQ8Fj+noUUsQnyhszsaqJE=; b=uU4GK2gC5sC35VYbYvzeZ+lDaLcruG+2EMZdw1Ry9AqxmUQk29pL2advVC7ymOiUt6 wlbEXpdF/scio8LL+uI0I72biTMoUl0JTT5l1bWWzutxdIt38kMvkUCmeD8xRZ7IV/2b TGECWz32wx4rLaxu+es7TPxO6ZTAk3wEYnLLn9rdPjZP0lCwzZTHPibuEoQ6Rbkrmm0b zougjukD7wEUQaqMrUDyTSbQa9qA2dzdnySekmkt3MevnC239CS88jbhcCibBoEZz0DF 1GwVVFznMgnhDIZTbYRazLIEWN9aHqA6v7ZkXx+V+g/TxcDTcvjxAT7ssGkNc5GnBTwX 0A1w== X-Gm-Message-State: AOAM530VNS3Osjv7JicAN6HtWgETBnQjRdf46YHkMnIvAD8f2/aIXXZc rPlxhKNp/AYskN/9FYyyB56r7yi6C4dCXw== X-Google-Smtp-Source: ABdhPJyhX3b6BOyPPYnRXXJA2E42GbHdgsl+U0YvrwnaMecNP4GSgQ9mnoCBSfoWLB14MMinAXSoOg== X-Received: by 2002:ac2:592c:: with SMTP id v12mr26563923lfi.249.1629885340373; Wed, 25 Aug 2021 02:55:40 -0700 (PDT) Received: from [192.168.1.11] ([46.235.66.127]) by smtp.gmail.com with ESMTPSA id w18sm332803lfa.50.2021.08.25.02.55.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 02:55:40 -0700 (PDT) Subject: Re: [PATCH v3 4/6] staging: r8188eu: add error handling of rtw_read16 To: "Fabio M. De Francesco" , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <1665728.ljvk3MsED4@localhost.localdomain> <2227654.mbYB7oqmoa@localhost.localdomain> From: Pavel Skripkin Message-ID: <794dfd94-fe88-43ac-c4ec-9ff7df9db6de@gmail.com> Date: Wed, 25 Aug 2021 12:55:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <2227654.mbYB7oqmoa@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/25/21 12:48 PM, Fabio M. De Francesco wrote: > On Wednesday, August 25, 2021 10:22:16 AM CEST Pavel Skripkin wrote: >> On 8/25/21 7:35 AM, Fabio M. De Francesco wrote: >> > Dear Pavel, >> > >> > Please note that if and when my patch "Use usb_control_msg_recv / send () in >> > usbctrl_vendorreq ()" will be merged, "if (res! = len)" will always evaluate 'true' >> > and usb_read16 () will always return -EIO even if usbctrl_vendorreq () succeeds. >> > >> >> Yep, thank you, but it depends on which series will go in first :) >> >> There is a chance, that you will need to clean up this part, if mine >> will be merged before yours >> > > Ha-ha ... I know that beautiful rule: whoever breaks must fix! > However there should be another rule which says that > the old (me) takes precedence over the young (you) :-) > The main problem, that no one knows who is the "old". Greg can take patches in any order he wants, because they are naturally independent :) We only can say smth like "this one depends on this one" as reply to patch to inform Greg about the situation. > Seriously, thank you so much for your help and the "Reviewed by" > tag on my work. > You too :) We are doing same job here for the good of community and kernel itself With regards, Pavel Skripkin