From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rcar_fdp1: Make use of the helper function devm_platform_ioremap_resource()
Date: Wed, 1 Sep 2021 09:16:16 +0100 [thread overview]
Message-ID: <797f3440-1f3e-d68b-0a20-e190dc36ed5d@ideasonboard.com> (raw)
In-Reply-To: <20210901055525.7379-1-caihuoqing@baidu.com>
On 01/09/2021 06:55, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/media/platform/rcar_fdp1.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
> index 89aac60066d9..19de3c19bcca 100644
> --- a/drivers/media/platform/rcar_fdp1.c
> +++ b/drivers/media/platform/rcar_fdp1.c
> @@ -2256,7 +2256,6 @@ static int fdp1_probe(struct platform_device *pdev)
> struct fdp1_dev *fdp1;
> struct video_device *vfd;
> struct device_node *fcp_node;
> - struct resource *res;
> struct clk *clk;
> unsigned int i;
>
> @@ -2283,8 +2282,7 @@ static int fdp1_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, fdp1);
>
> /* Memory-mapped registers */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - fdp1->regs = devm_ioremap_resource(&pdev->dev, res);
> + fdp1->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(fdp1->regs))
> return PTR_ERR(fdp1->regs);
>
>
prev parent reply other threads:[~2021-09-01 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 5:55 [PATCH] media: rcar_fdp1: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 8:16 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=797f3440-1f3e-d68b-0a20-e190dc36ed5d@ideasonboard.com \
--to=kieran.bingham@ideasonboard.com \
--cc=caihuoqing@baidu.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).