From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1993BC4338F for ; Sun, 8 Aug 2021 04:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDB3F60F4C for ; Sun, 8 Aug 2021 04:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229916AbhHHEvF (ORCPT ); Sun, 8 Aug 2021 00:51:05 -0400 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.80]:21105 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbhHHEvE (ORCPT ); Sun, 8 Aug 2021 00:51:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1628398216; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=tqf6PlETAOXRJpPIr/nXcD0P8wQYQiHI4vR4nGLYXTg=; b=N85pf2/ocz0fkNh9TirmrPfOWEs2FxQbQKE7UUaB7dMm4YJHcRuUJfUFX/yEhotLtO ayy3Bj93gP6xkn+fgoTCnUWMaomYwx6vHn39xs6oo7tHlzzXoL1nBVpkY3jGBhhklm/B kXubmqe6CGMKPuZu0cdfolbZp6EtFXibCuBlZK6XjT5p3HXi2iAijQ2kq0L5BZ25JgZ3 qp+V274lhDYt24P5Ifnze6JRALG8jTYlernmDtkOXzNqdP9Ubd6srXSiTHge2HEcWoCL dr+nztDZyVTV6p4vF2JJAvOPYX1CorOT0E3k1pvtHaftXDVG2I5wVoNIOJ/1HRwZDIO1 vv5w== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHWElw43u3mM=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.31.0 DYNA|AUTH) with ESMTPSA id Q02727x784oDExT (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sun, 8 Aug 2021 06:50:13 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH v2 1/8] drm/bridge: synopsis: Add mode_fixup and bridge timings support From: "H. Nikolaus Schaller" In-Reply-To: Date: Sun, 8 Aug 2021 06:50:13 +0200 Cc: Paul Cercueil , Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jernej Skrabec , Ezequiel Garcia , Harry Wentland , Sam Ravnborg , Maxime Ripard , Hans Verkuil , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-mips@vger.kernel.org, linux-kernel , letux-kernel@openphoenux.org, Paul Boddie , Jonas Karlman , dri-devel Content-Transfer-Encoding: quoted-printable Message-Id: <79C56341-BB3E-4AFC-A595-6EE2ED603FC2@goldelico.com> References: <15187eccabf39561de226acd8be40b93503cac49.1628172477.git.hns@goldelico.com> To: Robert Foss X-Mailer: Apple Mail (2.3445.104.21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert, > Am 05.08.2021 um 16:32 schrieb Robert Foss : >=20 > Hey Nikolaus, >=20 > Thanks for submitting this series. >=20 > On Thu, 5 Aug 2021 at 16:08, H. Nikolaus Schaller = wrote: >>=20 >> From: Paul Boddie >>=20 >> static void dw_hdmi_bridge_mode_set(struct drm_bridge *bridge, >> const struct drm_display_mode = *orig_mode, >> const struct drm_display_mode = *mode) >> @@ -2883,6 +2896,7 @@ static const struct drm_bridge_funcs = dw_hdmi_bridge_funcs =3D { >> .atomic_disable =3D dw_hdmi_bridge_atomic_disable, >> .mode_set =3D dw_hdmi_bridge_mode_set, >> .mode_valid =3D dw_hdmi_bridge_mode_valid, >> + .mode_fixup =3D dw_hdmi_bridge_mode_fixup, >=20 > mode_fixup() has been deprecated[1] in favor of atomic_check(), care > has to be taken when switching to atomic_check() as it has access to > the full atomic commit. >=20 > Looking at this driver, it's using mode_set as well, which should be = fixed. >=20 > [1] = https://lore.kernel.org/dri-devel/20210722062246.2512666-8-sam@ravnborg.or= g/ We have moved code from mode_fixup() to atomic_check(). Was not difficult. v3 will come soon. BR and thanks, Nikolaus Schaller