From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4480EC433DF for ; Wed, 3 Jun 2020 07:02:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1603620674 for ; Wed, 3 Jun 2020 07:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591167723; bh=5+spvHFVv9/Zby40LDALwvi1QN6xquc/OnWOGsCbRRg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2Mtfbw9blsZrQAbuh1/kb21sqtoKSAbIRLex4jCEIW7ZyQkK11En9F3U0GKOPZBi0 edqKl+Vqx3IFtUSp2lBASxmlg+35Fkd+TsBIbvRuZDnM+Igqik1/Hm/0kzI1vNEFSO t7KNt+GGjmFc6pWS6KmRGOBahTzp5yqZTVrAiuzI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726351AbgFCHCC (ORCPT ); Wed, 3 Jun 2020 03:02:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:43408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbgFCHBH (ORCPT ); Wed, 3 Jun 2020 03:01:07 -0400 Received: from mail.kernel.org (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D72A20872; Wed, 3 Jun 2020 07:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591167665; bh=5+spvHFVv9/Zby40LDALwvi1QN6xquc/OnWOGsCbRRg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ex6liaXDWT0dsrR9Mht02ZWbAGkEwQhVriWidZ+IntRTb3MbIyFAy0FpnK6x/LZtG Zi/XKYU4z+8FgO3eHqbFmjrR8e+sEn0h9IeHffIhRBAtcYTSCABN24vTPKvB+CI4w6 xBGZB6UVGyz+8vuM/4IJbO6Tb+9QYeN1sX5ERvZM= Received: from mchehab by mail.kernel.org with local (Exim 4.93) (envelope-from ) id 1jgNOZ-004j8z-NE; Wed, 03 Jun 2020 09:01:03 +0200 From: Mauro Carvalho Chehab To: Linux Media Mailing List Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/15] media: atomisp: set DFS to MAX if sensor doesn't report fps Date: Wed, 3 Jun 2020 09:00:59 +0200 Message-Id: <79b4062a8efa176ffa0f1f898cf8de64807173ac.1591167358.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the sensor doesn't implement support for g_frame_interval, it won't return the expected fps rate. Instead of keeping DFS on its minimal value (which will likely not work), set it to the max. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c index 6c324815c0f6..845fa851029a 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -243,8 +243,12 @@ int atomisp_freq_scaling(struct atomisp_device *isp, } fps = atomisp_get_sensor_fps(asd); - if (fps == 0) - return -EINVAL; + if (fps == 0) { + dev_info(isp->dev, + "Sensor didn't report FPS. Using DFS max mode.\n"); + new_freq = dfs->highest_freq; + goto done; + } curr_rules.width = asd->fmt[asd->capture_pad].fmt.width; curr_rules.height = asd->fmt[asd->capture_pad].fmt.height; -- 2.26.2