From: Vineeth Remanan Pillai <vineethp@amazon.com>
To: Juergen Gross <jgross@suse.com>,
David Miller <davem@davemloft.net>, <boris.ostrovsky@oracle.com>,
<xen-devel@lists.xenproject.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <kamatam@amazon.com>, <aliguori@amazon.com>, <vineethp@amazon.com>
Subject: Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM
Date: Wed, 18 Jan 2017 09:02:17 -0800 [thread overview]
Message-ID: <79c6ecce-bfcb-ebaa-afd2-05c1d86004d7@amazon.com> (raw)
In-Reply-To: <ee87b2e4-de8c-7b9b-c4e5-854ffab2e554@suse.com>
On 01/15/2017 10:24 PM, Juergen Gross wrote:
> On 13/01/17 18:55, Remanan Pillai wrote:
>> From: Vineeth Remanan Pillai <vineethp@amazon.com>
>>
>> During an OOM scenario, request slots could not be created as skb
>> allocation fails. So the netback cannot pass in packets and netfront
>> wrongly assumes that there is no more work to be done and it disables
>> polling. This causes Rx to stall.
>>
>> The issue is with the retry logic which schedules the timer if the
>> created slots are less than NET_RX_SLOTS_MIN. The count of new request
>> slots to be pushed are calculated as a difference between new req_prod
>> and rsp_cons which could be more than the actual slots, if there are
>> unconsumed responses.
>>
>> The fix is to calculate the count of newly created slots as the
>> difference between new req_prod and old req_prod.
>>
>> Signed-off-by: Vineeth Remanan Pillai <vineethp@amazon.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Thanks Juergen.
David,
Could you please pick up this change for net-next if there no more
concerns..
Many Thanks,
Vineeth
>
>
> Thanks,
>
> Juergen
>
next prev parent reply other threads:[~2017-01-18 17:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 23:17 [PATCH] xen-netfront: Fix Rx stall during network stress and OOM Vineeth Remanan Pillai
2017-01-12 20:17 ` David Miller
2017-01-12 23:09 ` Vineeth Remanan Pillai
[not found] ` <1484330100-3960-1-git-send-email-vineethp@u480fcf3b67f557f68df1.ant.amazon.com>
2017-01-16 6:24 ` [PATCH v2] " Juergen Gross
2017-01-18 17:02 ` Vineeth Remanan Pillai [this message]
2017-01-18 20:08 ` David Miller
2017-01-18 20:10 ` David Miller
2017-01-18 20:24 ` Vineeth Remanan Pillai
[not found] <1484771149-12699-1-git-send-email-vineethp@u480fcf3b67f557f68df1.ant.amazon.com>
2017-01-19 16:35 ` Vineeth Remanan Pillai
2017-01-19 17:11 ` David Miller
2017-01-19 17:17 ` Vineeth Remanan Pillai
2017-01-19 18:10 ` David Miller
2017-01-20 19:09 ` David Miller
2017-01-29 23:09 ` Boris Ostrovsky
2017-01-30 16:47 ` Vineeth Remanan Pillai
2017-01-30 17:06 ` Boris Ostrovsky
2017-01-30 17:13 ` Vineeth Remanan Pillai
2017-01-31 16:47 ` Vineeth Remanan Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79c6ecce-bfcb-ebaa-afd2-05c1d86004d7@amazon.com \
--to=vineethp@amazon.com \
--cc=aliguori@amazon.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=jgross@suse.com \
--cc=kamatam@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).