* [PATCH 1/2] dt-bindings: Add vendor prefix for oceanic
@ 2019-02-26 6:02 Jagan Teki
2019-02-26 6:02 ` [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support Jagan Teki
0 siblings, 1 reply; 12+ messages in thread
From: Jagan Teki @ 2019-02-26 6:02 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland
Cc: Ryan Pannell, Michael Trimarchi, linux-arm-kernel, devicetree,
linux-kernel, linux-amarula, Jagan Teki
Add oceanic vendor prefix.
Oceanic Systems (UK) Ltd design and manufacture world-class marine
systems for control and monitoring vessels.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index f42e12eb9d64..5b551407f487 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -285,6 +285,7 @@ nuvoton Nuvoton Technology Corporation
nvd New Vision Display
nvidia NVIDIA
nxp NXP Semiconductors
+oceanic Oceanic Systems (UK) Ltd.
okaya Okaya Electric America, Inc.
oki Oki Electric Industry Co., Ltd.
olimex OLIMEX Ltd.
--
2.18.0.321.gffc6fa0e3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-02-26 6:02 [PATCH 1/2] dt-bindings: Add vendor prefix for oceanic Jagan Teki
@ 2019-02-26 6:02 ` Jagan Teki
2019-02-27 15:33 ` Maxime Ripard
0 siblings, 1 reply; 12+ messages in thread
From: Jagan Teki @ 2019-02-26 6:02 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland
Cc: Ryan Pannell, Michael Trimarchi, linux-arm-kernel, devicetree,
linux-kernel, linux-amarula, Jagan Teki
Oceanic A64-5inMFD is a 5 inch Multi function display baseboard
designed to mount SoPine SOM.
Key features:
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 2GB DDR3 RAM
- SD Slot
- SPI-NOR flash
- EMAC, RTL8211E
- MCP2515 CAN
- MIPI-DSI
- Goodix 911 CTP
- USB Host
- 12V DC power supply
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
arch/arm64/boot/dts/allwinner/Makefile | 1 +
.../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++++
2 files changed, 47 insertions(+)
create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
index a5fb1eaa8acf..ec39fe856117 100644
--- a/arch/arm64/boot/dts/allwinner/Makefile
+++ b/arch/arm64/boot/dts/allwinner/Makefile
@@ -2,6 +2,7 @@
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
new file mode 100644
index 000000000000..d73d1f55acb9
--- /dev/null
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
@@ -0,0 +1,46 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
+ * Copyright (C) 2019 Amarula Solutions B.V.
+ * Author: Jagan Teki <jagan@amarulasolutions.com>
+ */
+
+/dts-v1/;
+
+#include "sun50i-a64-sopine.dtsi"
+
+/ {
+ model = "Oceanic A64-5inMFD";
+ compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
+
+ aliases {
+ serial0 = &uart0;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+};
+
+&ehci0 {
+ status = "okay";
+};
+
+&ohci0 {
+ status = "okay";
+};
+
+&uart0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart0_pb_pins>;
+ status = "okay";
+};
+
+&usb_otg {
+ dr_mode = "host";
+ status = "okay";
+};
+
+&usbphy {
+ status = "okay";
+};
--
2.18.0.321.gffc6fa0e3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-02-26 6:02 ` [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support Jagan Teki
@ 2019-02-27 15:33 ` Maxime Ripard
2019-02-27 16:19 ` Jagan Teki
0 siblings, 1 reply; 12+ messages in thread
From: Maxime Ripard @ 2019-02-27 15:33 UTC (permalink / raw)
To: Jagan Teki
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Ryan Pannell,
Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel,
linux-amarula
[-- Attachment #1: Type: text/plain, Size: 2893 bytes --]
Hi,
On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote:
> Oceanic A64-5inMFD is a 5 inch Multi function display baseboard
> designed to mount SoPine SOM.
>
> Key features:
> - Allwinner A64 Cortex-A53
> - Mali-400MP2 GPU
> - AXP803 PMIC
> - 2GB DDR3 RAM
> - SD Slot
> - SPI-NOR flash
> - EMAC, RTL8211E
> - MCP2515 CAN
> - MIPI-DSI
> - Goodix 911 CTP
> - USB Host
> - 12V DC power supply
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> arch/arm64/boot/dts/allwinner/Makefile | 1 +
> .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++++
> 2 files changed, 47 insertions(+)
> create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
>
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> index a5fb1eaa8acf..ec39fe856117 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -2,6 +2,7 @@
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> new file mode 100644
> index 000000000000..d73d1f55acb9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> @@ -0,0 +1,46 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
> + * Copyright (C) 2019 Amarula Solutions B.V.
> + * Author: Jagan Teki <jagan@amarulasolutions.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-a64-sopine.dtsi"
> +
> +/ {
> + model = "Oceanic A64-5inMFD";
> + compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
The name of the DT is Oceanic 5inMFD, while you call the board
A64-5inMFD here, which name is the actual name?
> +
> + aliases {
> + serial0 = &uart0;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +};
> +
> +&ehci0 {
> + status = "okay";
> +};
> +
> +&ohci0 {
> + status = "okay";
> +};
> +
> +&uart0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_pb_pins>;
> + status = "okay";
> +};
> +
> +&usb_otg {
> + dr_mode = "host";
> + status = "okay";
> +};
> +
> +&usbphy {
> + status = "okay";
> +};
Is the OTG controller really is only capable of running in host mode?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-02-27 15:33 ` Maxime Ripard
@ 2019-02-27 16:19 ` Jagan Teki
2019-03-01 14:57 ` Maxime Ripard
0 siblings, 1 reply; 12+ messages in thread
From: Jagan Teki @ 2019-02-27 16:19 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Ryan Pannell,
Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel,
linux-amarula
On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Hi,
>
> On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote:
> > Oceanic A64-5inMFD is a 5 inch Multi function display baseboard
> > designed to mount SoPine SOM.
> >
> > Key features:
> > - Allwinner A64 Cortex-A53
> > - Mali-400MP2 GPU
> > - AXP803 PMIC
> > - 2GB DDR3 RAM
> > - SD Slot
> > - SPI-NOR flash
> > - EMAC, RTL8211E
> > - MCP2515 CAN
> > - MIPI-DSI
> > - Goodix 911 CTP
> > - USB Host
> > - 12V DC power supply
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > arch/arm64/boot/dts/allwinner/Makefile | 1 +
> > .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++++
> > 2 files changed, 47 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> > index a5fb1eaa8acf..ec39fe856117 100644
> > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > @@ -2,6 +2,7 @@
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
> > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > new file mode 100644
> > index 000000000000..d73d1f55acb9
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > @@ -0,0 +1,46 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
> > + * Copyright (C) 2019 Amarula Solutions B.V.
> > + * Author: Jagan Teki <jagan@amarulasolutions.com>
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sun50i-a64-sopine.dtsi"
> > +
> > +/ {
> > + model = "Oceanic A64-5inMFD";
> > + compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
>
> The name of the DT is Oceanic 5inMFD, while you call the board
> A64-5inMFD here, which name is the actual name?
Yes, this is something that we discussed during "Amarula A64-Relic"
naming convention.
Since these boards are not famous like teres-i we agreed to add vendor
name after sun50i-a64- followed by real board name.
Here A64 already covered during sun50i-a64- so the dts name simply the
<vendor_name>-<real_board_name>
>
> > +
> > + aliases {
> > + serial0 = &uart0;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
> > +};
> > +
> > +&ehci0 {
> > + status = "okay";
> > +};
> > +
> > +&ohci0 {
> > + status = "okay";
> > +};
> > +
> > +&uart0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&uart0_pb_pins>;
> > + status = "okay";
> > +};
> > +
> > +&usb_otg {
> > + dr_mode = "host";
> > + status = "okay";
> > +};
> > +
> > +&usbphy {
> > + status = "okay";
> > +};
>
> Is the OTG controller really is only capable of running in host mode?
Yes, USB on baseboard is similar like sopine-baseboard
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-02-27 16:19 ` Jagan Teki
@ 2019-03-01 14:57 ` Maxime Ripard
2019-03-01 16:57 ` Jagan Teki
0 siblings, 1 reply; 12+ messages in thread
From: Maxime Ripard @ 2019-03-01 14:57 UTC (permalink / raw)
To: Jagan Teki
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Ryan Pannell,
Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel,
linux-amarula
[-- Attachment #1: Type: text/plain, Size: 4027 bytes --]
On Wed, Feb 27, 2019 at 09:49:23PM +0530, Jagan Teki wrote:
> On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > Hi,
> >
> > On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote:
> > > Oceanic A64-5inMFD is a 5 inch Multi function display baseboard
> > > designed to mount SoPine SOM.
> > >
> > > Key features:
> > > - Allwinner A64 Cortex-A53
> > > - Mali-400MP2 GPU
> > > - AXP803 PMIC
> > > - 2GB DDR3 RAM
> > > - SD Slot
> > > - SPI-NOR flash
> > > - EMAC, RTL8211E
> > > - MCP2515 CAN
> > > - MIPI-DSI
> > > - Goodix 911 CTP
> > > - USB Host
> > > - 12V DC power supply
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > arch/arm64/boot/dts/allwinner/Makefile | 1 +
> > > .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++++
> > > 2 files changed, 47 insertions(+)
> > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> > > index a5fb1eaa8acf..ec39fe856117 100644
> > > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > > @@ -2,6 +2,7 @@
> > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
> > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
> > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
> > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
> > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
> > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
> > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > new file mode 100644
> > > index 000000000000..d73d1f55acb9
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > @@ -0,0 +1,46 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > +/*
> > > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
> > > + * Copyright (C) 2019 Amarula Solutions B.V.
> > > + * Author: Jagan Teki <jagan@amarulasolutions.com>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "sun50i-a64-sopine.dtsi"
> > > +
> > > +/ {
> > > + model = "Oceanic A64-5inMFD";
> > > + compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
> >
> > The name of the DT is Oceanic 5inMFD, while you call the board
> > A64-5inMFD here, which name is the actual name?
>
> Yes, this is something that we discussed during "Amarula A64-Relic"
> naming convention.
>
> Since these boards are not famous like teres-i we agreed to add vendor
> name after sun50i-a64- followed by real board name.
>
> Here A64 already covered during sun50i-a64- so the dts name simply the
> <vendor_name>-<real_board_name>
For the DT name, yeah, we want that pattern.
For the compatible and model, we want to use the model name.
> >
> > > +
> > > + aliases {
> > > + serial0 = &uart0;
> > > + };
> > > +
> > > + chosen {
> > > + stdout-path = "serial0:115200n8";
> > > + };
> > > +};
> > > +
> > > +&ehci0 {
> > > + status = "okay";
> > > +};
> > > +
> > > +&ohci0 {
> > > + status = "okay";
> > > +};
> > > +
> > > +&uart0 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart0_pb_pins>;
> > > + status = "okay";
> > > +};
> > > +
> > > +&usb_otg {
> > > + dr_mode = "host";
> > > + status = "okay";
> > > +};
> > > +
> > > +&usbphy {
> > > + status = "okay";
> > > +};
> >
> > Is the OTG controller really is only capable of running in host mode?
>
> Yes, USB on baseboard is similar like sopine-baseboard
Ok
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-03-01 14:57 ` Maxime Ripard
@ 2019-03-01 16:57 ` Jagan Teki
2019-03-05 15:59 ` Maxime Ripard
0 siblings, 1 reply; 12+ messages in thread
From: Jagan Teki @ 2019-03-01 16:57 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Ryan Pannell,
Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel,
linux-amarula
On Fri, Mar 1, 2019 at 8:27 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Wed, Feb 27, 2019 at 09:49:23PM +0530, Jagan Teki wrote:
> > On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > >
> > > Hi,
> > >
> > > On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote:
> > > > Oceanic A64-5inMFD is a 5 inch Multi function display baseboard
> > > > designed to mount SoPine SOM.
> > > >
> > > > Key features:
> > > > - Allwinner A64 Cortex-A53
> > > > - Mali-400MP2 GPU
> > > > - AXP803 PMIC
> > > > - 2GB DDR3 RAM
> > > > - SD Slot
> > > > - SPI-NOR flash
> > > > - EMAC, RTL8211E
> > > > - MCP2515 CAN
> > > > - MIPI-DSI
> > > > - Goodix 911 CTP
> > > > - USB Host
> > > > - 12V DC power supply
> > > >
> > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > ---
> > > > arch/arm64/boot/dts/allwinner/Makefile | 1 +
> > > > .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++++
> > > > 2 files changed, 47 insertions(+)
> > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > >
> > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> > > > index a5fb1eaa8acf..ec39fe856117 100644
> > > > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > > > @@ -2,6 +2,7 @@
> > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
> > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
> > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
> > > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
> > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
> > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
> > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
> > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > new file mode 100644
> > > > index 000000000000..d73d1f55acb9
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > @@ -0,0 +1,46 @@
> > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > +/*
> > > > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
> > > > + * Copyright (C) 2019 Amarula Solutions B.V.
> > > > + * Author: Jagan Teki <jagan@amarulasolutions.com>
> > > > + */
> > > > +
> > > > +/dts-v1/;
> > > > +
> > > > +#include "sun50i-a64-sopine.dtsi"
> > > > +
> > > > +/ {
> > > > + model = "Oceanic A64-5inMFD";
> > > > + compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
> > >
> > > The name of the DT is Oceanic 5inMFD, while you call the board
> > > A64-5inMFD here, which name is the actual name?
> >
> > Yes, this is something that we discussed during "Amarula A64-Relic"
> > naming convention.
> >
> > Since these boards are not famous like teres-i we agreed to add vendor
> > name after sun50i-a64- followed by real board name.
> >
> > Here A64 already covered during sun50i-a64- so the dts name simply the
> > <vendor_name>-<real_board_name>
>
> For the DT name, yeah, we want that pattern.
>
> For the compatible and model, we want to use the model name.
Entire model name after <vendor_name>, ?
model = "Oceanic A64-5inMFD";
compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
is this not sufficient?
Let me understand with respective few existing stuff.
model = "Amarula A64-Relic";
compatible = "amarula,a64-relic", "allwinner,sun50i-a64";
model = "Olimex A64 Teres-I"
compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64";
model = "FriendlyARM NanoPi A64";
compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";
model = "Olimex A64-Olinuxino";
compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64"
Would you comment, what is the different with respect to my change?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-03-01 16:57 ` Jagan Teki
@ 2019-03-05 15:59 ` Maxime Ripard
2019-03-05 16:07 ` Jagan Teki
0 siblings, 1 reply; 12+ messages in thread
From: Maxime Ripard @ 2019-03-05 15:59 UTC (permalink / raw)
To: Jagan Teki
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Ryan Pannell,
Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel,
linux-amarula
[-- Attachment #1: Type: text/plain, Size: 4879 bytes --]
On Fri, Mar 01, 2019 at 10:27:14PM +0530, Jagan Teki wrote:
> On Fri, Mar 1, 2019 at 8:27 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > On Wed, Feb 27, 2019 at 09:49:23PM +0530, Jagan Teki wrote:
> > > On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote:
> > > > > Oceanic A64-5inMFD is a 5 inch Multi function display baseboard
> > > > > designed to mount SoPine SOM.
> > > > >
> > > > > Key features:
> > > > > - Allwinner A64 Cortex-A53
> > > > > - Mali-400MP2 GPU
> > > > > - AXP803 PMIC
> > > > > - 2GB DDR3 RAM
> > > > > - SD Slot
> > > > > - SPI-NOR flash
> > > > > - EMAC, RTL8211E
> > > > > - MCP2515 CAN
> > > > > - MIPI-DSI
> > > > > - Goodix 911 CTP
> > > > > - USB Host
> > > > > - 12V DC power supply
> > > > >
> > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > ---
> > > > > arch/arm64/boot/dts/allwinner/Makefile | 1 +
> > > > > .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++++
> > > > > 2 files changed, 47 insertions(+)
> > > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> > > > > index a5fb1eaa8acf..ec39fe856117 100644
> > > > > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > > > > @@ -2,6 +2,7 @@
> > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
> > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
> > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
> > > > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
> > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
> > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
> > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > > new file mode 100644
> > > > > index 000000000000..d73d1f55acb9
> > > > > --- /dev/null
> > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > > @@ -0,0 +1,46 @@
> > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > +/*
> > > > > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
> > > > > + * Copyright (C) 2019 Amarula Solutions B.V.
> > > > > + * Author: Jagan Teki <jagan@amarulasolutions.com>
> > > > > + */
> > > > > +
> > > > > +/dts-v1/;
> > > > > +
> > > > > +#include "sun50i-a64-sopine.dtsi"
> > > > > +
> > > > > +/ {
> > > > > + model = "Oceanic A64-5inMFD";
> > > > > + compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
> > > >
> > > > The name of the DT is Oceanic 5inMFD, while you call the board
> > > > A64-5inMFD here, which name is the actual name?
> > >
> > > Yes, this is something that we discussed during "Amarula A64-Relic"
> > > naming convention.
> > >
> > > Since these boards are not famous like teres-i we agreed to add vendor
> > > name after sun50i-a64- followed by real board name.
> > >
> > > Here A64 already covered during sun50i-a64- so the dts name simply the
> > > <vendor_name>-<real_board_name>
> >
> > For the DT name, yeah, we want that pattern.
> >
> > For the compatible and model, we want to use the model name.
>
> Entire model name after <vendor_name>, ?
>
> model = "Oceanic A64-5inMFD";
> compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
>
> is this not sufficient?
>
> Let me understand with respective few existing stuff.
>
> model = "Amarula A64-Relic";
> compatible = "amarula,a64-relic", "allwinner,sun50i-a64";
>
> model = "Olimex A64 Teres-I"
> compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64";
This one is called the TERES-A64:
https://www.olimex.com/Products/DIY-Laptop/KITS/TERES-A64-WHITE/open-source-hardware
The laptop is the Teres-I, it can have an A64
> model = "FriendlyARM NanoPi A64";
> compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";
NanoPi A64 is the name of the board: http://nanopi.io/nanopi-a64.html
> model = "Olimex A64-Olinuxino";
> compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64"
A64-Olinuxino is the name of the board too:
https://www.olimex.com/Products/OLinuXino/A64/A64-OLinuXino/open-source-hardware
> Would you comment, what is the different with respect to my change?
If the name of the product is 5inMFD, then the model should be Oceanic
5inMFD, and its compatible oceanic,5inmfd
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-03-05 15:59 ` Maxime Ripard
@ 2019-03-05 16:07 ` Jagan Teki
2019-03-05 16:35 ` Ryan Pannell
0 siblings, 1 reply; 12+ messages in thread
From: Jagan Teki @ 2019-03-05 16:07 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Ryan Pannell,
Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel,
linux-amarula
On Tue, Mar 5, 2019 at 9:29 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Fri, Mar 01, 2019 at 10:27:14PM +0530, Jagan Teki wrote:
> > On Fri, Mar 1, 2019 at 8:27 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > >
> > > On Wed, Feb 27, 2019 at 09:49:23PM +0530, Jagan Teki wrote:
> > > > On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote:
> > > > > > Oceanic A64-5inMFD is a 5 inch Multi function display baseboard
> > > > > > designed to mount SoPine SOM.
> > > > > >
> > > > > > Key features:
> > > > > > - Allwinner A64 Cortex-A53
> > > > > > - Mali-400MP2 GPU
> > > > > > - AXP803 PMIC
> > > > > > - 2GB DDR3 RAM
> > > > > > - SD Slot
> > > > > > - SPI-NOR flash
> > > > > > - EMAC, RTL8211E
> > > > > > - MCP2515 CAN
> > > > > > - MIPI-DSI
> > > > > > - Goodix 911 CTP
> > > > > > - USB Host
> > > > > > - 12V DC power supply
> > > > > >
> > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > ---
> > > > > > arch/arm64/boot/dts/allwinner/Makefile | 1 +
> > > > > > .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++++
> > > > > > 2 files changed, 47 insertions(+)
> > > > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > index a5fb1eaa8acf..ec39fe856117 100644
> > > > > > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > @@ -2,6 +2,7 @@
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
> > > > > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
> > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > > > new file mode 100644
> > > > > > index 000000000000..d73d1f55acb9
> > > > > > --- /dev/null
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > > > @@ -0,0 +1,46 @@
> > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > > +/*
> > > > > > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
> > > > > > + * Copyright (C) 2019 Amarula Solutions B.V.
> > > > > > + * Author: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > + */
> > > > > > +
> > > > > > +/dts-v1/;
> > > > > > +
> > > > > > +#include "sun50i-a64-sopine.dtsi"
> > > > > > +
> > > > > > +/ {
> > > > > > + model = "Oceanic A64-5inMFD";
> > > > > > + compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
> > > > >
> > > > > The name of the DT is Oceanic 5inMFD, while you call the board
> > > > > A64-5inMFD here, which name is the actual name?
> > > >
> > > > Yes, this is something that we discussed during "Amarula A64-Relic"
> > > > naming convention.
> > > >
> > > > Since these boards are not famous like teres-i we agreed to add vendor
> > > > name after sun50i-a64- followed by real board name.
> > > >
> > > > Here A64 already covered during sun50i-a64- so the dts name simply the
> > > > <vendor_name>-<real_board_name>
> > >
> > > For the DT name, yeah, we want that pattern.
> > >
> > > For the compatible and model, we want to use the model name.
> >
> > Entire model name after <vendor_name>, ?
> >
> > model = "Oceanic A64-5inMFD";
> > compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
> >
> > is this not sufficient?
> >
> > Let me understand with respective few existing stuff.
> >
> > model = "Amarula A64-Relic";
> > compatible = "amarula,a64-relic", "allwinner,sun50i-a64";
> >
> > model = "Olimex A64 Teres-I"
> > compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64";
>
> This one is called the TERES-A64:
> https://www.olimex.com/Products/DIY-Laptop/KITS/TERES-A64-WHITE/open-source-hardware
>
> The laptop is the Teres-I, it can have an A64
>
> > model = "FriendlyARM NanoPi A64";
> > compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";
>
> NanoPi A64 is the name of the board: http://nanopi.io/nanopi-a64.html
>
> > model = "Olimex A64-Olinuxino";
> > compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64"
>
> A64-Olinuxino is the name of the board too:
> https://www.olimex.com/Products/OLinuXino/A64/A64-OLinuXino/open-source-hardware
>
> > Would you comment, what is the different with respect to my change?
>
> If the name of the product is 5inMFD, then the model should be Oceanic
> 5inMFD, and its compatible oceanic,5inmfd
Oceanic seems to have some multiple Multi Function Devices, ie reason
we prefer the product as 'A64-5inMFD' since it is A64 based. In this
case the model and compatible should be fine I think?
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-03-05 16:07 ` Jagan Teki
@ 2019-03-05 16:35 ` Ryan Pannell
2019-03-06 9:27 ` Maxime Ripard
0 siblings, 1 reply; 12+ messages in thread
From: Ryan Pannell @ 2019-03-05 16:35 UTC (permalink / raw)
To: Jagan Teki, Maxime Ripard
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Michael Trimarchi,
linux-arm-kernel, devicetree, linux-kernel, linux-amarula
We don't mind if it has to be:
compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";
However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";
Perhaps this solves the issue. Please let me know thoughts.
Ryan Pannell
Development Team Lead
Oceanic Systems (UK) Ltd
-----Original Message-----
From: Jagan Teki <jagan@amarulasolutions.com>
Sent: 05 March 2019 16:08
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Chen-Yu Tsai <wens@csie.org>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Ryan Pannell <ryan@osukl.com>; Michael Trimarchi <michael@amarulasolutions.com>; linux-arm-kernel <linux-arm-kernel@lists.infradead.org>; devicetree <devicetree@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>; linux-amarula@amarulasolutions.com
Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
On Tue, Mar 5, 2019 at 9:29 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Fri, Mar 01, 2019 at 10:27:14PM +0530, Jagan Teki wrote:
> > On Fri, Mar 1, 2019 at 8:27 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > >
> > > On Wed, Feb 27, 2019 at 09:49:23PM +0530, Jagan Teki wrote:
> > > > On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote:
> > > > > > Oceanic A64-5inMFD is a 5 inch Multi function display
> > > > > > baseboard designed to mount SoPine SOM.
> > > > > >
> > > > > > Key features:
> > > > > > - Allwinner A64 Cortex-A53
> > > > > > - Mali-400MP2 GPU
> > > > > > - AXP803 PMIC
> > > > > > - 2GB DDR3 RAM
> > > > > > - SD Slot
> > > > > > - SPI-NOR flash
> > > > > > - EMAC, RTL8211E
> > > > > > - MCP2515 CAN
> > > > > > - MIPI-DSI
> > > > > > - Goodix 911 CTP
> > > > > > - USB Host
> > > > > > - 12V DC power supply
> > > > > >
> > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > > > > ---
> > > > > > arch/arm64/boot/dts/allwinner/Makefile | 1 +
> > > > > > .../allwinner/sun50i-a64-oceanic-5inmfd.dts | 46 +++++++++++++++++++
> > > > > > 2 files changed, 47 insertions(+) create mode 100644
> > > > > > arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > b/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > index a5fb1eaa8acf..ec39fe856117 100644
> > > > > > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > @@ -2,6 +2,7 @@
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb
> > > > > > sun50i-a64-bananapi-m64-icn6211.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
> > > > > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
> > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb diff
> > > > > > --git
> > > > > > a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dt
> > > > > > s
> > > > > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dt
> > > > > > s
> > > > > > new file mode 100644
> > > > > > index 000000000000..d73d1f55acb9
> > > > > > --- /dev/null
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmf
> > > > > > +++ d.dts
> > > > > > @@ -0,0 +1,46 @@
> > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > > +/*
> > > > > > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
> > > > > > + * Copyright (C) 2019 Amarula Solutions B.V.
> > > > > > + * Author: Jagan Teki <jagan@amarulasolutions.com> */
> > > > > > +
> > > > > > +/dts-v1/;
> > > > > > +
> > > > > > +#include "sun50i-a64-sopine.dtsi"
> > > > > > +
> > > > > > +/ {
> > > > > > + model = "Oceanic A64-5inMFD";
> > > > > > + compatible = "oceanic,a64-5inmfd",
> > > > > > +"allwinner,sun50i-a64";
> > > > >
> > > > > The name of the DT is Oceanic 5inMFD, while you call the board
> > > > > A64-5inMFD here, which name is the actual name?
> > > >
> > > > Yes, this is something that we discussed during "Amarula A64-Relic"
> > > > naming convention.
> > > >
> > > > Since these boards are not famous like teres-i we agreed to add
> > > > vendor name after sun50i-a64- followed by real board name.
> > > >
> > > > Here A64 already covered during sun50i-a64- so the dts name
> > > > simply the <vendor_name>-<real_board_name>
> > >
> > > For the DT name, yeah, we want that pattern.
> > >
> > > For the compatible and model, we want to use the model name.
> >
> > Entire model name after <vendor_name>, ?
> >
> > model = "Oceanic A64-5inMFD";
> > compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
> >
> > is this not sufficient?
> >
> > Let me understand with respective few existing stuff.
> >
> > model = "Amarula A64-Relic";
> > compatible = "amarula,a64-relic", "allwinner,sun50i-a64";
> >
> > model = "Olimex A64 Teres-I"
> > compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64";
>
> This one is called the TERES-A64:
> https://www.olimex.com/Products/DIY-Laptop/KITS/TERES-A64-WHITE/open-s
> ource-hardware
>
> The laptop is the Teres-I, it can have an A64
>
> > model = "FriendlyARM NanoPi A64";
> > compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";
>
> NanoPi A64 is the name of the board: http://nanopi.io/nanopi-a64.html
>
> > model = "Olimex A64-Olinuxino";
> > compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64"
>
> A64-Olinuxino is the name of the board too:
> https://www.olimex.com/Products/OLinuXino/A64/A64-OLinuXino/open-sourc
> e-hardware
>
> > Would you comment, what is the different with respect to my change?
>
> If the name of the product is 5inMFD, then the model should be Oceanic
> 5inMFD, and its compatible oceanic,5inmfd
Oceanic seems to have some multiple Multi Function Devices, ie reason we prefer the product as 'A64-5inMFD' since it is A64 based. In this case the model and compatible should be fine I think?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-03-05 16:35 ` Ryan Pannell
@ 2019-03-06 9:27 ` Maxime Ripard
2019-03-06 9:36 ` Jagan Teki
0 siblings, 1 reply; 12+ messages in thread
From: Maxime Ripard @ 2019-03-06 9:27 UTC (permalink / raw)
To: Ryan Pannell
Cc: Jagan Teki, Chen-Yu Tsai, Rob Herring, Mark Rutland,
Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel,
linux-amarula
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Tue, Mar 05, 2019 at 04:35:04PM +0000, Ryan Pannell wrote:
> We don't mind if it has to be:
> compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";
>
> However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
> compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";
>
> Perhaps this solves the issue. Please let me know thoughts.
Yep, that works for me
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-03-06 9:27 ` Maxime Ripard
@ 2019-03-06 9:36 ` Jagan Teki
2019-03-06 10:18 ` Ryan Pannell
0 siblings, 1 reply; 12+ messages in thread
From: Jagan Teki @ 2019-03-06 9:36 UTC (permalink / raw)
To: Maxime Ripard
Cc: Ryan Pannell, Chen-Yu Tsai, Rob Herring, Mark Rutland,
Michael Trimarchi, linux-arm-kernel, devicetree, linux-kernel,
linux-amarula
On Wed, Mar 6, 2019 at 2:57 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Tue, Mar 05, 2019 at 04:35:04PM +0000, Ryan Pannell wrote:
> > We don't mind if it has to be:
> > compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";
> >
> > However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
> > compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";
> >
> > Perhaps this solves the issue. Please let me know thoughts.
>
> Yep, that works for me
A64 instead of part-number 5205 seems less confused isn't it? or we
need to give more priority with real hardware definition?
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
2019-03-06 9:36 ` Jagan Teki
@ 2019-03-06 10:18 ` Ryan Pannell
0 siblings, 0 replies; 12+ messages in thread
From: Ryan Pannell @ 2019-03-06 10:18 UTC (permalink / raw)
To: Jagan Teki, Maxime Ripard
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Michael Trimarchi,
linux-arm-kernel, devicetree, linux-kernel, linux-amarula
Jagan,
The compatible is for the real hardware name as Maxime previously explained. The platform is described in the latter part.
Please use:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";
Thanks,
Ryan Pannell
Development Team Lead
Oceanic Systems (UK) Ltd
-----Original Message-----
From: Jagan Teki <jagan@amarulasolutions.com>
Sent: 06 March 2019 09:36
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Ryan Pannell <ryan@osukl.com>; Chen-Yu Tsai <wens@csie.org>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Michael Trimarchi <michael@amarulasolutions.com>; linux-arm-kernel <linux-arm-kernel@lists.infradead.org>; devicetree <devicetree@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>; linux-amarula@amarulasolutions.com
Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
On Wed, Mar 6, 2019 at 2:57 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Tue, Mar 05, 2019 at 04:35:04PM +0000, Ryan Pannell wrote:
> > We don't mind if it has to be:
> > compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";
> >
> > However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
> > compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";
> >
> > Perhaps this solves the issue. Please let me know thoughts.
>
> Yep, that works for me
A64 instead of part-number 5205 seems less confused isn't it? or we need to give more priority with real hardware definition?
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-03-06 10:18 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 6:02 [PATCH 1/2] dt-bindings: Add vendor prefix for oceanic Jagan Teki
2019-02-26 6:02 ` [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support Jagan Teki
2019-02-27 15:33 ` Maxime Ripard
2019-02-27 16:19 ` Jagan Teki
2019-03-01 14:57 ` Maxime Ripard
2019-03-01 16:57 ` Jagan Teki
2019-03-05 15:59 ` Maxime Ripard
2019-03-05 16:07 ` Jagan Teki
2019-03-05 16:35 ` Ryan Pannell
2019-03-06 9:27 ` Maxime Ripard
2019-03-06 9:36 ` Jagan Teki
2019-03-06 10:18 ` Ryan Pannell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).