From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A3DAC0650F for ; Thu, 8 Aug 2019 09:58:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD0342186A for ; Thu, 8 Aug 2019 09:58:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="GsnP6R7C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732110AbfHHJ6J (ORCPT ); Thu, 8 Aug 2019 05:58:09 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.54]:25376 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728289AbfHHJ6J (ORCPT ); Thu, 8 Aug 2019 05:58:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1565258287; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=1/f0k/H0a7K76vFEtcQN8S5GHIKWdhY5l6OaGUoHAj8=; b=GsnP6R7CEXEcVT/yM/KXuWTk0p0HvHOJeecDbCnQwgVJsTEpXuaCTgnA8vwr43oG/Y x0H2A+IfBWhQl5xkuntFSVVqtrhFzERiqtwi4CqemGRB5B5bLGgFrP2SotX7Nsp8au3B rI3FKEFsOEzavmRjzITFzNkHf6Podvac7+9xNuW4/1qBJoe3TyVn2ZDDtyW0FFPMfR0e JHdVlJ2NLZIZG2r6RVGPOFeMr8jW+lVVrmF+CNOLAiQIEsTHOgXACGCpp+ULt0WUvh3I /E6VoqF2YQFbDU/rEKHw6IN1AYxawYFM2h30LwIoFCFeMj4T2wb+da74u0vviShHgA7i bZ2A== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGH/vrwDCv1g==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 44.24 DYNA|AUTH) with ESMTPSA id j00b6dv789vvaoi (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Thu, 8 Aug 2019 11:57:57 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [Bug] v5.3-rc3: arm: omap5: omapdss: omap_fbdev_init fails with lpae config and reports dma_mask error From: "H. Nikolaus Schaller" In-Reply-To: <20190808072431.GA29852@lst.de> Date: Thu, 8 Aug 2019 11:57:56 +0200 Cc: Tomi Valkeinen , Tony Lindgren , Roger Quadros , Vignesh Raghavendra , Linux-OMAP , Linux Kernel Mailing List , kernel@pyra-handheld.com, Discussions about the Letux Kernel Content-Transfer-Encoding: quoted-printable Message-Id: <7B845956-A04D-40D8-A433-5812576A72E8@goldelico.com> References: <14A6738F-75C6-4479-8B15-FD7395EFC55E@goldelico.com> <20190808072431.GA29852@lst.de> To: Christoph Hellwig X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, > Am 08.08.2019 um 09:24 schrieb Christoph Hellwig : >=20 > Hi Nikolaus, >=20 > please try the patch below: >=20 > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c = b/drivers/gpu/drm/omapdrm/omap_fbdev.c > index 561c4812545b..2c8abf07e617 100644 > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > @@ -232,6 +232,8 @@ void omap_fbdev_init(struct drm_device *dev) > if (!priv->num_pipes) > return; >=20 > + dma_coerce_mask_and_coherent(dev->dev, DMA_BIT_MASK(32)); > + > fbdev =3D kzalloc(sizeof(*fbdev), GFP_KERNEL); > if (!fbdev) > goto fail; Yes, it fixes the issue! BR and thanks, Nikolaus=