From: Vijay Khemka <vijaykhemka@fb.com>
To: "minyard@acm.org" <minyard@acm.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"openipmi-developer@lists.sourceforge.net"
<openipmi-developer@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cminyard@mvista.com" <cminyard@mvista.com>,
"asmaa@mellanox.com" <asmaa@mellanox.com>,
"joel@jms.id.au" <joel@jms.id.au>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
Sai Dasari <sdasari@fb.com>
Subject: Re: [PATCH 2/2] drivers: ipmi: Modify max length of IPMB packet
Date: Tue, 12 Nov 2019 19:56:34 +0000 [thread overview]
Message-ID: <7BC487D6-6ACA-46CE-A751-8367FEDEE647@fb.com> (raw)
In-Reply-To: <20191112124845.GE2882@minyard.net>
On 11/12/19, 4:48 AM, "Corey Minyard" <tcminyard@gmail.com on behalf of minyard@acm.org> wrote:
On Mon, Nov 11, 2019 at 06:36:10PM -0800, Vijay Khemka wrote:
> As per IPMB specification, maximum packet size supported is 255,
> modified Max length to 240 from 128 to accommodate more data.
I couldn't find this in the IPMB specification.
IIRC, the maximum on I2C is 32 byts, and table 6-9 in the IPMI spec,
under "IPMB Output" states: The IPMB standard message length is
specified as 32 bytes, maximum, including slave address.
We are using IPMI OEM messages and our response size is around 150 bytes
For some of responses. That's why I had set it to 240 bytes.
I'm not sure where 128 came from, but maybe it should be reduced to 31.
-corey
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> drivers/char/ipmi/ipmb_dev_int.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c
> index 2419b9a928b2..7f9198bbce96 100644
> --- a/drivers/char/ipmi/ipmb_dev_int.c
> +++ b/drivers/char/ipmi/ipmb_dev_int.c
> @@ -19,7 +19,7 @@
> #include <linux/spinlock.h>
> #include <linux/wait.h>
>
> -#define MAX_MSG_LEN 128
> +#define MAX_MSG_LEN 240
> #define IPMB_REQUEST_LEN_MIN 7
> #define NETFN_RSP_BIT_MASK 0x4
> #define REQUEST_QUEUE_MAX_LEN 256
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-11-12 19:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191112023610.3644314-1-vijaykhemka@fb.com>
2019-11-12 12:36 ` [PATCH 1/2] drivers: ipmi: Support raw i2c packet in IPMB Corey Minyard
2019-11-12 14:19 ` Asmaa Mnebhi
2019-11-12 17:57 ` Vijay Khemka
2019-11-12 18:41 ` Corey Minyard
2019-11-12 20:13 ` Vijay Khemka
[not found] ` <20191112023610.3644314-2-vijaykhemka@fb.com>
2019-11-12 12:48 ` [PATCH 2/2] drivers: ipmi: Modify max length of IPMB packet Corey Minyard
2019-11-12 19:56 ` Vijay Khemka [this message]
2019-11-12 20:29 ` Corey Minyard
2019-11-12 20:48 ` Asmaa Mnebhi
2019-11-12 22:06 ` Asmaa Mnebhi
2019-11-12 23:19 ` Vijay Khemka
2019-11-13 0:51 ` [Openipmi-developer] " Corey Minyard
2019-11-13 17:40 ` Vijay Khemka
2019-11-13 17:52 ` Asmaa Mnebhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7BC487D6-6ACA-46CE-A751-8367FEDEE647@fb.com \
--to=vijaykhemka@fb.com \
--cc=arnd@arndb.de \
--cc=asmaa@mellanox.com \
--cc=cminyard@mvista.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=sdasari@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).