From: Andreas Dilger <adilger@dilger.ca>
To: Alejandro Colomar <colomar.6.4.3@gmail.com>
Cc: Benjamin LaHaise <bcrl@kvack.org>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fs/aio.c: Cosmetic
Date: Mon, 2 Nov 2020 17:50:46 -0700 [thread overview]
Message-ID: <7CCB9FA6-DE85-4E3F-B3F1-7144F01589D4@dilger.ca> (raw)
In-Reply-To: <20201102215809.17312-1-colomar.6.4.3@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
On Nov 2, 2020, at 2:58 PM, Alejandro Colomar <colomar.6.4.3@gmail.com> wrote:
> Changes:
> - Consistently use 'unsigned int', instead of 'unsigned'.
> - Add a blank line after variable declarations.
> - Move variable declarations to the top of functions.
> - Add a blank line at the top of functions if there are no declarations.
I'd agree that the other changes are following kernel coding style, but
I've never heard of leaving a blank line at the start of functions without
any local variables. I don't see anything in process/coding-style.rst to
support this change, nor are the majority of variable-less functions
formatted this way, and it seems to just be a waste of vertical space.
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
next prev parent reply other threads:[~2020-11-03 0:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 15:05 [PATCH] fs/aio.c: Cosmetic Alejandro Colomar
2020-11-02 15:24 ` Alejandro Colomar
2020-11-02 21:58 ` [PATCH v2] " Alejandro Colomar
2020-11-03 0:50 ` Andreas Dilger [this message]
2020-11-03 3:22 ` Joe Perches
2020-11-03 9:50 ` [PATCH v3] " Alejandro Colomar
2020-11-20 22:06 ` [PATCH v4] " Alejandro Colomar
2020-11-21 1:22 ` Randy Dunlap
2020-11-21 11:41 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7CCB9FA6-DE85-4E3F-B3F1-7144F01589D4@dilger.ca \
--to=adilger@dilger.ca \
--cc=bcrl@kvack.org \
--cc=colomar.6.4.3@gmail.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).