Re: [PATCH v3 2/2] tracing: remove igrab() iput() call from uprobes.c

[Song Liu <songliubraving@fb.com>]

> On Apr 23, 2018, at 3:03 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> 
> On Fri, Apr 20, 2018 at 6:56 PM, Song Liu <songliubraving@fb.com> wrote:
>> Caller of uprobe_register is required to keep the inode and containing
>> mount point referenced.
>> 
>> Cc: Steven Rostedt <rostedt@goodmis.org>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Howard McLauchlan <hmclauchlan@fb.com>
>> Cc: Josef Bacik <jbacik@fb.com>
>> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>> Cc: Miklos Szeredi <miklos@szeredi.hu>
>> Signed-off-by: Song Liu <songliubraving@fb.com>
>> ---
>> kernel/events/uprobes.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>> 
>> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
>> index ce6848e..20486bb 100644
>> --- a/kernel/events/uprobes.c
>> +++ b/kernel/events/uprobes.c
>> @@ -491,7 +491,6 @@ static struct uprobe *alloc_uprobe(struct inode *inode, loff_t offset)
>>        if (!uprobe)
>>                return NULL;
>> 
>> -       uprobe->inode = igrab(inode);
> 
> Where has the assignment gone?
> 
> Testing your changes would not hurt...
> 
> Thanks,
> Miklos

Oops.. I tested the trace_uprobe to uprobe part of it, but didn't test
the uprobe itself. (Tested) fix coming soon.

Song