From: Zi Yan <ziy@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yang Shi <shy828301@gmail.com>, Linux MM <linux-mm@kvack.org>,
Rik van Riel <riel@surriel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] mm/compaction: count pages and stop correctly during page isolation.
Date: Thu, 29 Oct 2020 21:20:16 -0400 [thread overview]
Message-ID: <7DC14FB8-8DA4-4DB4-BB0B-3409CA8D6DD9@nvidia.com> (raw)
In-Reply-To: <20201029172822.da31fa5ab34c3a795361768f@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On 29 Oct 2020, at 20:28, Andrew Morton wrote:
> On Thu, 29 Oct 2020 17:31:28 -0400 Zi Yan <ziy@nvidia.com> wrote:
>
>>>
>>> Shall you add Fixes tag to commit
>>> 1da2f328fa643bd72197dfed0c655148af31e4eb? And may cc stable.
>>
>> Sure.
>>
>> Fixes: 1da2f328fa64 (“mm,thp,compaction,cma: allow THP migration for CMA allocations”)
>>
>> stable cc'ed.
>
> A think a cc:stable really requires a description of the end-user
> visible effects of the bug. Could you please provide that?
Sure.
For example, in a system with 16GB memory and an 8GB CMA region reserved by hugetlb_cma,
if we first allocate 10GB THPs and mlock them (so some THPs are allocated in the CMA
region and mlocked), reserving 6 1GB hugetlb pages via
/sys/kernel/mm/hugepages/hugepages-1048576kB/nr_hugepages will get stuck (looping
in too_many_isolated function) until we kill either task. With the patch applied,
oom will kill the application with 10GB THPs and let hugetlb page reservation finish.
—
Best Regards,
Yan Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2020-10-30 1:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 20:04 [PATCH] mm/compaction: count pages and stop correctly during page isolation Zi Yan
2020-10-29 21:14 ` Yang Shi
2020-10-29 21:31 ` Zi Yan
2020-10-30 0:28 ` Andrew Morton
2020-10-30 1:20 ` Zi Yan [this message]
2020-10-30 9:43 ` Michal Hocko
2020-10-30 12:20 ` Zi Yan
2020-10-30 13:36 ` Michal Hocko
2020-10-30 14:35 ` Zi Yan
2020-10-30 14:49 ` Michal Hocko
2020-10-30 14:53 ` Zi Yan
2020-10-30 14:55 ` Vlastimil Babka
2020-10-30 18:33 ` Yang Shi
2020-10-30 18:39 ` Zi Yan
2020-10-30 18:55 ` Yang Shi
2020-11-02 13:03 ` Vlastimil Babka
2020-11-02 16:39 ` Yang Shi
2020-10-30 14:50 ` Vlastimil Babka
2020-10-30 15:18 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7DC14FB8-8DA4-4DB4-BB0B-3409CA8D6DD9@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=shy828301@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).