From: "Nakajima, Jun" <jun.nakajima@intel.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>,
"Saxena, Sunil" <sunil.saxena@intel.com>,
"Mallick, Asit K" <asit.k.mallick@intel.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: RE: [PATCH] idle using PNI monitor/mwait (take 2)
Date: Fri, 5 Sep 2003 13:41:07 -0700 [thread overview]
Message-ID: <7F740D512C7C1046AB53446D3720017304AF0D@scsmsx402.sc.intel.com> (raw)
We are doing this as defensive programming (because of bogus device
drivers, for example), like the other idle routines (default_idle, and
poll_idle) always do.
BTW, I'm not sure that local_irq_disable() is really required below (as
you know, "sti" is hiding in safe_halt()).
void default_idle(void)
{
if (!hlt_counter && current_cpu_data.hlt_works_ok) {
=> local_irq_disable();
if (!need_resched())
safe_halt();
else
local_irq_enable();
}
}
Thanks,
Jun
> -----Original Message-----
> From: Andrew Morton [mailto:akpm@osdl.org]
> Sent: Friday, September 05, 2003 10:14 AM
> To: Nakajima, Jun
> Cc: linux-kernel@vger.kernel.org; Saxena, Sunil; Mallick, Asit K;
> Pallipadi, Venkatesh
> Subject: Re: [PATCH] idle using PNI monitor/mwait (take 2)
>
> "Nakajima, Jun" <jun.nakajima@intel.com> wrote:
> >
> > Attached is a patch that enables PNI (Prescott New Instructions)
> > monitor/mwait in the kernel idle.
>
> Thanks, looks good.
>
> Why is there a local_irq_enable() on entry to mwait_idle()?
next reply other threads:[~2003-09-05 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-05 20:41 Nakajima, Jun [this message]
2003-09-05 21:14 ` [PATCH] idle using PNI monitor/mwait (take 2) Jamie Lokier
2003-09-05 22:03 ` Jamie Lokier
-- strict thread matches above, loose matches on Subject: below --
2003-09-06 1:03 Nakajima, Jun
2003-09-06 9:58 ` Jamie Lokier
2003-09-05 2:19 Nakajima, Jun
2003-09-05 17:14 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F740D512C7C1046AB53446D3720017304AF0D@scsmsx402.sc.intel.com \
--to=jun.nakajima@intel.com \
--cc=akpm@osdl.org \
--cc=asit.k.mallick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sunil.saxena@intel.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).