From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754945AbbBEHFk (ORCPT ); Thu, 5 Feb 2015 02:05:40 -0500 Received: from TYO202.gate.nec.co.jp ([210.143.35.52]:37403 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbbBEHFi (ORCPT ); Thu, 5 Feb 2015 02:05:38 -0500 From: Hiroshi Shimamoto To: Jeff Kirsher CC: Alexander Duyck , "Skidmore, Donald C" , =?utf-8?B?QmrDuHJuIE1vcms=?= , "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "Choi, Sy Jong" , "linux-kernel@vger.kernel.org" , David Laight , Hayato Momma Subject: RE: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode Thread-Topic: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode Thread-Index: AQHQQHogrRNJgEEIH0OMgxRCuFdfe5zhJvNw Date: Thu, 5 Feb 2015 06:10:34 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05E21852@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05E1908D@BPXM14GP.gisp.nec.co.jp> <1423054641.2589.59.camel@jtkirshe-mobl> In-Reply-To: <1423054641.2589.59.camel@jtkirshe-mobl> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t1575m5A023004 > Subject: Re: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode > > On Fri, 2015-01-30 at 11:37 +0000, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto > > > > The limitation of the number of multicast address for VF is not enough > > for the large scale server with SR-IOV feature. > > IPv6 requires the multicast MAC address for each IP address to handle > > the Neighbor Solicitation message. > > We couldn't assign over 30 IPv6 addresses to a single VF interface. > > > > The easy way to solve this is enabling multicast promiscuous mode. > > It is good to have a functionality to enable multicast promiscuous > > mode > > for each VF from VF driver. > > > > This patch introduces the new mbox API, IXGBE_VF_SET_MC_PROMISC, to > > enable/disable multicast promiscuous mode in VF. If multicast > > promiscuous > > mode is enabled the VF can receive all multicast packets. > > > > With this patch, the ixgbevf driver automatically enable multicast > > promiscuous mode when the number of multicast addresses is over than > > 30 > > if possible. > > > > This also bump the API version up to 1.2 to check whether the API, > > IXGBE_VF_SET_MC_PROMISC is available. > > > > Signed-off-by: Hiroshi Shimamoto > > Reviewed-by: Hayato Momma > > CC: Choi, Sy Jong > > --- > > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 + > > drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 4 + > > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 89 > > ++++++++++++++++++++++- > > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 13 +++- > > drivers/net/ethernet/intel/ixgbevf/mbx.h | 4 + > > drivers/net/ethernet/intel/ixgbevf/vf.c | 29 +++++++- > > drivers/net/ethernet/intel/ixgbevf/vf.h | 1 + > > 7 files changed, 137 insertions(+), 4 deletions(-) > > Hiroshi, I tried to apply your patches to my queue but they do not apply > cleanly and they are in a DOS file format, not UNIX. I also noted > several checkpatch.pl issues with your patches, so please fix those up > as well. I'm sorry to bother you. Will fix. > > Can you please fix up your patches based on my tree: > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/queue.git Yes. I haven't noticed your tree. Will resend patches against it. thanks, Hiroshi > > This my queue of all community patches against the Intel LAN drivers and > will be where I queue up your patches while they are under review and > testing. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I