From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: "jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>,
Or Gerlitz <gerlitz.or@gmail.com>
Cc: "vyasevic@redhat.com" <vyasevic@redhat.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"Choi, Sy Jong" <sy.jong.choi@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David Laight" <David.Laight@aculab.com>,
"Hayato Momma" <h-momma@ce.jp.nec.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Edward Cree" <ecree@solarflare.com>,
"Bjørn Mork" <bjorn@mork.no>
Subject: Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control
Date: Tue, 10 Mar 2015 01:42:22 +0000 [thread overview]
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05E53671@BPXM14GP.gisp.nec.co.jp> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1320 bytes --]
> On 03/08/2015 02:15 PM, Or Gerlitz wrote:
> > On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher
> > <jeffrey.t.kirsher@intel.com> wrote:
> > [...]
> >> We discussed this during NetConf last week, and Don is correct that a
> >> custom sysfs interface is not the way we want to handle this. We agreed
> >> upon a generic interface so that any NIC is able to turn on or off VF
> >> multicast promiscuous mode.
> >
> > Jeff, please make sure to either respond to my comments on the V2
> > thread (or better) address them for the V3 post.
> >
> >
> > http://marc.info/?l=linux-netdev&m=142441852518152&w=2
> > http://marc.info/?l=linux-netdev&m=142441867218183&w=2
>
> I agree with you that the patch descriptions should be cleaned up and
> "beefed" up for that matter.
>
> If/when I look to push his series of patches, I will make sure that your
> concerns are addressed so that we can get a accurate changelog.
I see that the patchset should have better explanation in changelog.
I will rewrite it and submit again.
Jeff, are you planning to drop the patchset from your tree?
I just concerned which tree I should create patches against for.
thanks,
Hiroshi
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2015-03-10 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 1:42 Hiroshi Shimamoto [this message]
2015-03-10 1:52 ` [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control Jeff Kirsher
2015-03-10 2:48 ` Jeff Kirsher
2015-03-10 3:01 ` Hiroshi Shimamoto
-- strict thread matches above, loose matches on Subject: below --
2015-03-08 21:15 Or Gerlitz
2015-03-09 7:27 ` [E1000-devel] " Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F861DC0615E0C47A872E6F3C5FCDDBD05E53671@BPXM14GP.gisp.nec.co.jp \
--to=h-shimamoto@ct.jp.nec.com \
--cc=David.Laight@aculab.com \
--cc=bjorn@mork.no \
--cc=e1000-devel@lists.sourceforge.net \
--cc=ecree@solarflare.com \
--cc=gerlitz.or@gmail.com \
--cc=h-momma@ce.jp.nec.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sy.jong.choi@intel.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).