From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932113AbcFNQrs (ORCPT ); Tue, 14 Jun 2016 12:47:48 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:35983 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbcFNQrq (ORCPT ); Tue, 14 Jun 2016 12:47:46 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH] Linux VM workaround for Knights Landing A/D leak From: Nadav Amit In-Reply-To: <1465919919-2093-1-git-send-email-lukasz.anaczkowski@intel.com> Date: Tue, 14 Jun 2016 09:47:41 -0700 Cc: LKML , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , ak@linux.intel.com, kirill.shutemov@linux.intel.com, mhocko@suse.com, Andrew Morton , "H. Peter Anvin" , harish.srinivasappa@intel.com, lukasz.odzioba@intel.com Content-Transfer-Encoding: 7bit Message-Id: <7FB15233-B347-4A87-9506-A9E10D331292@gmail.com> References: <1465919919-2093-1-git-send-email-lukasz.anaczkowski@intel.com> To: Lukasz Anaczkowski X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lukasz Anaczkowski wrote: > From: Andi Kleen > +void fix_pte_leak(struct mm_struct *mm, unsigned long addr, pte_t *ptep) > +{ Here there should be a call to smp_mb__after_atomic() to synchronize with switch_mm. I submitted a similar patch, which is still pending (hint). > + if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids) { > + trace_tlb_flush(TLB_LOCAL_SHOOTDOWN, TLB_FLUSH_ALL); > + flush_tlb_others(mm_cpumask(mm), mm, addr, > + addr + PAGE_SIZE); > + mb(); > + set_pte(ptep, __pte(0)); > + } > +} Regards, Nadav