From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEF7C4727C for ; Tue, 22 Sep 2020 04:21:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1533923A1E for ; Tue, 22 Sep 2020 04:21:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728464AbgIVEVh (ORCPT ); Tue, 22 Sep 2020 00:21:37 -0400 Received: from mga18.intel.com ([134.134.136.126]:51222 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726790AbgIVEVf (ORCPT ); Tue, 22 Sep 2020 00:21:35 -0400 IronPort-SDR: K6TEJh7RtMb86KxJ4/qzQvUTvJ7VFUkyueumbIcLtPexDJB0zur4nKX1FUX/r2AEDGG8VkD8a/ WrjT6rCU9t6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="148282267" X-IronPort-AV: E=Sophos;i="5.77,289,1596524400"; d="scan'208";a="148282267" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 21:21:34 -0700 IronPort-SDR: iGxqjyRDLUS1y98vuXY8eB3HROqQQ4TcOPMlcRFeWQUSzH3Sc5k0/f4+pxVJaWvaOtF3W41RWe v5S0VYXI3NBw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,289,1596524400"; d="scan'208";a="348343830" Received: from linux.intel.com ([10.54.29.200]) by orsmga007.jf.intel.com with ESMTP; 21 Sep 2020 21:21:35 -0700 Received: from [10.213.147.65] (vramuthx-MOBL1.gar.corp.intel.com [10.213.147.65]) by linux.intel.com (Postfix) with ESMTP id 644AD580812; Mon, 21 Sep 2020 21:21:32 -0700 (PDT) Reply-To: vadivel.muruganx.ramuthevar@linux.intel.com Subject: Re: [PATCH -next] phy: fix USB_LGM_PHY warning & build errors To: Randy Dunlap , LKML , USB list Cc: Li Yin , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman References: From: "Ramuthevar, Vadivel MuruganX" Message-ID: <7a0129e7-b023-29ad-963f-345bb762b35e@linux.intel.com> Date: Tue, 22 Sep 2020 12:21:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, Thank you for the report, surely will fix it. Regards Vadivel On 21/9/2020 11:45 pm, Randy Dunlap wrote: > Ping. Still seeing this in linux-next. > > On 9/17/20 10:51 AM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix a Kconfig warning that is causing lots of build errors >> when USB_SUPPORT is not set. >> >> USB_PHY depends on USB_SUPPORT but "select" doesn't care about >> dependencies, so this driver should also depend on USB_SUPPORT. >> It should not select USB_SUPPORT. >> >> WARNING: unmet direct dependencies detected for USB_PHY >> Depends on [n]: USB_SUPPORT [=n] >> Selected by [m]: >> - USB_LGM_PHY [=m] >> >> Signed-off-by: Randy Dunlap >> Cc: Li Yin >> Cc: Vadivel Murugan R >> Cc: Kishon Vijay Abraham I >> Cc: Vinod Koul >> --- >> drivers/phy/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- linux-next-20200917.orig/drivers/phy/Kconfig >> +++ linux-next-20200917/drivers/phy/Kconfig >> @@ -51,6 +51,7 @@ config PHY_XGENE >> >> config USB_LGM_PHY >> tristate "INTEL Lightning Mountain USB PHY Driver" >> + depends on USB_SUPPORT >> select USB_PHY >> select REGULATOR >> select REGULATOR_FIXED_VOLTAGE >> > >