From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753599AbcLBXgo (ORCPT ); Fri, 2 Dec 2016 18:36:44 -0500 Received: from mail-bl2nam02on0086.outbound.protection.outlook.com ([104.47.38.86]:3184 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750903AbcLBXgm (ORCPT ); Fri, 2 Dec 2016 18:36:42 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Subject: Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select' To: Arnd Bergmann , "David S. Miller" References: <20161202230451.1639318-1-arnd@arndb.de> CC: Felix Manlunas , Thomas Gleixner , David Daney , Satanand Burla , Raghu Vatsavayi , Nicolas Pitre , Sunil Goutham , , From: David Daney Message-ID: <7a02d341-3e1f-edcf-c062-d8a93f44efbb@caviumnetworks.com> Date: Fri, 2 Dec 2016 15:20:30 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161202230451.1639318-1-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: BN1PR07CA0047.namprd07.prod.outlook.com (10.255.193.22) To CY1PR07MB2136.namprd07.prod.outlook.com (10.164.112.14) X-MS-Office365-Filtering-Correlation-Id: a0a1d067-0849-46b9-2cc9-08d41b09d1d4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY1PR07MB2136; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;3:2BJmcjxK3MxzhNfT+IKj6YurWRU0dgktg+/xRPZkC6wa3Ew8vcj6cyon2W9mhweuSNVw8+Fl/Q7y2h8Mdvv+9E44vUVNP7sBhATTjvRYFmLzHj/0qPrK7s4KVMzTdMfc3mHMcZMkzFIqPn9mqClZ8NmZZiK7hcfsBi/TvVFSqpw1LbE2rGMn9Ydmrr19dLenc/usDswQlZfdAoyp/Ir5T/iPToHtsw1RN6mqV0TCnSN+QnbMa2D1uHhjyUtHVfBIgiz40MXiT/I+AIGV5qPAMw==;25:1EtLIlcOFJkb6L0rbgEI2rOLEVeJm6QLVyhVyVjozwyRc3xuATnxIYdfZdaw4E7HrmBEPUe0gDq8yl0z8hMvtr4/XAuy8y6ceHf8qsS+N8Xj+WFMKnUUNYTiySRVg4uJMDALnZTKgjDeAxSGVSuO3Ia/HfXFjCug8XEgjDsJrJ/XCU8ympMUuQfWtOnXjYhtz5FaZhSfxQyoNlVhwEDb0xHiIP9GyApAv0huFAfEeZ/Jhxkulr2eUEvKwDgrj+rNBgXFFR+uOSQn4bfIJrrptdXQEN8APdMY2yLxuz/Qx0ceQBncvfCthpL5lxrf5E/bgFA6yCstUHyD4eDpmjHU1WsZRTNTNE1eB8SRppIBjNC5YYwmCgVRztSTUW8YPcTVqpYedFjcRSzRLB4TXS6fZ5pZQFaL0fbEokNpfvuEpMR7PG9SFKgNz7opzLHwZL6mxQLs1PH+iwsq04YKU/0dhQ== X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;31:REtrrxzVe8G8jLXczOCxT5BC2k//QseET0QxEoHcx2ORylCZmqtJJUAhF8cS8wnwrQIYKWOR5qC35TH+9YOBs43tspeKWML/w4YfbpnVgCh0d1zt37dP7wQIoZPwiFc6O1/Q82pnhPPtM5JfdwgmhfZ8A/hDJ3PZFXt82TfHTE8IbdA3ZCIh4qQWV7J9ZHAPAe7URYr4SWwgK3ktWr2XWFIffxbisCFZWTZ24KeDSq7LFjxEnY4y82al0topRzpweQ1n1z5RmYFxGcSFriSWHw==;20:Omiaq9JmWb6hFIoNAf/TGO8Ngizk78J0/O+WLCCHs41ZMTsJ5PyHamDy/dX0WdVmFSUW02CWJ+5OaXluZlw7ZjVWWlL/o1N7gsvGNWWqK0ZMx4xwPjUXi6RfqmBOb3meBNSxP/LJw7xHzNloVWQfuuxDMRcxi1s7DvMG65BMuy4fOBcN4J5LDqklbJJcx8ainX5jse296IZGa3NbGhfuXaS8sH65Fth4MoJ+VeGqVCObd0ARex5qw8XE5xmiq8iam8f5jDw24kDsBiqMYC84rs3dDSYh5LAgap6t55jh7HmN//1Q6UAnYCT9LBg9+umq8ETCVZ8/n64fjnwCgxDRZzyg0yDdI63k4Cu4nwA1jHUkigddFgwFsLBw3eP6/IkttGkxngqKsYxoQq0TSVc5hDhBkpnlFAruqycnHjZC1kwENwrlavJ4ymH3cuh8EDMvBRRKl6pVV0NjIvLjKn7kkM+RDb7kwWwixxN5tQ5a28eC4IsHNFdguYubrTTxE01RZqkmienk3Kssg5ywfWlWJDnLfe2coS9DnR+6izHE+zdCIj7QtHo88FyNVLHVk1XIEtL6Bxxbeoz5EzQJAygkuKg8Gu/fGkSN0dc2lfzs5Fs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(158342451672863); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(20161123558021)(6072148);SRVR:CY1PR07MB2136;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2136; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;4:KcOiP/0a9Uj0H1bdM0+N0ILTmtBnGNcuXG8Q6XJGIe2464uQZZM6B3spAWJ8qiY1JYpEC4SWTpnXHD8ARVgqLtHe0mTA3xWZarNP2C5eChZt4qOcJSUfMUJTc1QUUMZ49mgdDwTi2xULv0rqUZVmyb3oWQCj/CuFiIcT22JiHCQrE++bmQF5o86t6ABCxawohILHONQ558S6KojPVJ1iRSPzMUx2LCr+zD9zxlv5lfShwwKjG/sK0paLwI+qXDnCWBNyRUTckYWyO9u/JU+Nk3ksrx4d79qkLvEXNOTcU/0+FsrUb872x+4tDCftglpM+lcy6SuNmqX9VtMzXYTMBy+GxEs2u4GdvMBw/ED/F37XFd519cDHxpytV0JUk0MakSvLI+g0E7c5SjpDHDK0KxBMngjq8O5920l87v92vH4R76fp4cpv+pU2Yvcu8CDrxR+AYgNlBUvyXSV6SEWZH3ABSddwmgSHeWdjc/WI0+N1o299xy4fAfwnBOkuy5Wq95soCaoABS/f+/ANt3EPm+S5I05sDM5g7Y0PvJZnGDFXr5AQgu9ewv55DrJsN8vK5nFEUgirI0kc9lCjLvuMhFWy8PPhVO+MB6zsueg07eZGJihEdtvPU1B0sF/3Z3VLKY+kKKrDGUtQLbbfSe3WLQ== X-Forefront-PRVS: 0144B30E41 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(24454002)(377454003)(8676002)(97736004)(66066001)(65956001)(33646002)(47776003)(50986999)(65806001)(76176999)(68736007)(54356999)(65826007)(5660300001)(36756003)(230700001)(5001770100001)(81166006)(101416001)(6506006)(6512006)(81156014)(92566002)(189998001)(69596002)(31696002)(106356001)(4001350100001)(31686004)(23746002)(42186005)(53416004)(105586002)(2906002)(83506001)(64126003)(4326007)(6486002)(305945005)(38730400001)(50466002)(733004)(39410400001)(39450400002)(7846002)(7736002)(229853002)(2950100002)(3846002)(6116002)(42882006);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2136;H:ddl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR07MB2136;23:MkWFccqNR5EJ2tBHO4aOkBEjmhqV6G9SrKK8A?= =?Windows-1252?Q?wuLAw8Jyx7AoMeACVUSE28DXym5EtIBzoDAX/hQtPUd/RooEgYAk+cPz?= =?Windows-1252?Q?VJ0LHoCVMXWooueN0TBZB3JHBIHNA+yyIu285Yp6kmWOUqrzHXjY63wN?= =?Windows-1252?Q?0CloRh47uQxkLBCjF48nWgXe7csqlcW9rGUCfPdBJGlmPU505ni90jnx?= =?Windows-1252?Q?MlHRkwv6uaFXUhYrzUxnk1nu+VYoyMwWhSktjQbwLNnvYLnd0wU2k2PG?= =?Windows-1252?Q?zn3XUVQB/NPYMHZbn8LRxX+mSdEqNWf+h3TOpnn7DGEO9KqTBeg/SfBx?= =?Windows-1252?Q?aEf6cN7V9n/qZI35MLg8DLeO04HIVRUjOaINAjoFS7bqCXg2OV7v9OKq?= =?Windows-1252?Q?lsSNonAVDQzclNI28EWUyXjwyMjsX2ldoEOQNK3XE9r8hIH4nBos1oQ7?= =?Windows-1252?Q?x/VU3b4ozMaF6Y7di+L3Zfx4v0GLdOuax8UuEVuEWkzvRlRDW5H2CuQt?= =?Windows-1252?Q?CKU9YewzjJVEL4iXjlr0kPoAwbZrQ0rrG/4RxeuEjjy7qiAbScFUXcSI?= =?Windows-1252?Q?LlyIBHfSKTAvIfQ3poMelzAq3StDnfwiwvHrtBUKDAw5n71TBttVGK0S?= =?Windows-1252?Q?eOQ6tJj51xwo/8MqkyQWLiGeAyI1pJvLh3YBHK8MzgJsZEtuVuIO/LM9?= =?Windows-1252?Q?29ehzG3XwhtycGltjfxMRmdQPjAF9VbnxEoKtzgpPPl+tNfYbeTx5k1D?= =?Windows-1252?Q?O1MRkJYOdpIypbvNzNBYUZubUmf8ZznPVFo7RjJG+L4ot4ythDKiRhQ0?= =?Windows-1252?Q?WD2GCIVgnRh2j7nQmevGlQcXc3nEkebrQdZR+dZL/pVzx3h29gGdCD05?= =?Windows-1252?Q?CX8PwWH0gPiTgiVpKm7Kn/niBwhfmDXJl6jRVYRJuMXoe+xC8T5J7XmY?= =?Windows-1252?Q?KYbeUuRuAFoDyd4tVb9D9eLSnI1iTLoyzog5ZNT6HZ6AVfsGK684jGft?= =?Windows-1252?Q?ud3JyqbFycUoHaZJuwKd0Druk6TB+w4yQIRQLZMdwZndfeyX74ayGari?= =?Windows-1252?Q?cDzPuYLs0GOGoXztQ8Q+XLODlx92OP8cZtT4NvU7xC/f6iS3C289oKu8?= =?Windows-1252?Q?IEgJJlsNqBMmK6v1MJHqqvaezYkjeKbjNQB1MCVpMcKE8fIpDIVilJIJ?= =?Windows-1252?Q?ozv5dkmJRpUD8mjCoSD53SBtjflt+e8Zq68/r4W8htqlXxCwFXMxOktW?= =?Windows-1252?Q?Ye77x8BNaulCgoodrkachr+bXfimZDTQvHHMaPHNlh4SSiTh4glTOq8Y?= =?Windows-1252?Q?IMq/EHg6Jq0hRK6uOXO+yxju+o/9PLk1ysBXq0P+LezXF+zxfrJ4GQep?= =?Windows-1252?Q?GpaNqWqp0d68zPa6txR75c/tdrvCEud1wWVlfqXXEGGzQ4rMekSTOHoI?= =?Windows-1252?Q?0dsSJH2ZKktExwVYxuw7mXGEasoUl1jfgNSb5h5wUw6JpGLgsCUAYMpf?= =?Windows-1252?Q?ccY3sg=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;6:kPdte1NyQV3dzmjfkIqKQ0bWyW4RxwGVCg18M5/J6FeYesCQe9Qe57G/qzgRs1LxakPg76Es7buYES4Fz0i56tNhcSJmgCaC3D0Q6tfOWU27JsOczv61/8j6i17fZh9zq6IRDqQekF40j2sgPXYto4vQesXOks/iHNVtoLlpuUvpGCKiZ+GaN/wJP2sfcm9LfwRlLGRV5Rh4/AImeZ770iKaqOpqsvxao2u4V0SOUVtu8Gn3+hf6131PjQa4ZO20rGh3AVHEGef+myEcNqhu3NMprm+YywOBdx6z6fOa0kw78dRkzzJiMOYz2IWgvpE2V6TvsVWH8LUQ7u/Cti5jvniAgAK9OrXy8mWITNIDt2m7mAadKGS/rw7ikBF6+011wFRDQsYcWxrhAqhlRG88jux2GOjmA2YpLnBGT/Z/6jvJYbbEqRno1PZmTw1+wBRQnM6B9uvt5m9EecHZKO0GHg==;5:UwE4iqOF/uCvCJR2pLOejcsW+bHJ1991LlaF/IiHlAblPzkAk1O+3BwlZ7uwO3AEbOaLSJxcaZ/Gu2lj3R+QS95nfYD4xvQ/QXStZOCoLHc3s3IoqMQwXNlPewudcW2KtseaCM6uB/8w+r1KhiQaWt4muq2ZNomzbsEXugHF2Hw=;24:01RyPeWJCWeI7uNUNP3Zi9WmBOrVixkOpTuHeQ4Rj8q8lzkubejcCCH1OlvR6CT5yflWjcIbttCJOWljstCqmMkCrbCDhIjTnMy38yF+mL8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;7:kmDdVI72hbvrdyakDipIZRIeAaH8S2CzkUg/y/Ukg33ZWhPk9oOFV+kndmbIRtjJyjpaQ9WXjtinhTVzzOcWkYBbfnHcc8eSdD43wa/1VEaOCjZTOFL1a+SArHuZPoP08huEvv2h/TUqdl5y6VoWuHznSnIFXlvCb8J/1ZylQKMAuIcU44sXR6OzCw5m9bL/+05FV73mmWRY92kg3VIhjemFukFzWLQjU+lp3iDiEG5LcsfPWfoJ9WddvEns3HXcjSwTJHlolqpbVly74Amsq53uisuMONg5xqAXIiiET/hcTE3MgtoJRonUha8ewN9yK2j0nGouZHBc4e3p/GPn42pMkQCvD8BzQ22Cxm2P5dunUtCzinl0ZOOYVsH/oIlB+gqZ8/s2SUZnVpbI7fvyDWmg+gSTgDhLEDLsczwlFjtJxjVFyvLH8lFu14YpvNwFsBtzLXd09XALwL0w34Cxzw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2016 23:20:33.9538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2136 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/02/2016 03:04 PM, Arnd Bergmann wrote: > ptp now depends on the optional POSIX_TIMERS setting and fails to build > if we select it without that: > > warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct dependencies (NET && POSIX_TIMERS) > warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct dependencies (NET && POSIX_TIMERS) > ERROR: "posix_clock_unregister" [drivers/ptp/ptp.ko] undefined! > ERROR: "posix_clock_register" [drivers/ptp/ptp.ko] undefined! > ERROR: "pps_unregister_source" [drivers/ptp/ptp.ko] undefined! > ERROR: "pps_event" [drivers/ptp/ptp.ko] undefined! > ERROR: "pps_register_source" [drivers/ptp/ptp.ko] undefined! > > It seems that two patches have collided here, the build failure > is a result of the combination. Changing the new option to 'imply' > as well fixes it. > > Fixes: 111fc64a237f ("liquidio CN23XX: VF registration") > Fixes: d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") > Signed-off-by: Arnd Bergmann I didn't know about this new "imply" thing. This seems like a plausible fix, so... Acked-by: David Daney Thanks for fixing this up. > --- > drivers/net/ethernet/cavium/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig > index bbc8bd16cb97..dcbce6cac63e 100644 > --- a/drivers/net/ethernet/cavium/Kconfig > +++ b/drivers/net/ethernet/cavium/Kconfig > @@ -77,7 +77,7 @@ config OCTEON_MGMT_ETHERNET > config LIQUIDIO_VF > tristate "Cavium LiquidIO VF support" > depends on 64BIT && PCI_MSI > - select PTP_1588_CLOCK > + imply PTP_1588_CLOCK > ---help--- > This driver supports Cavium LiquidIO Intelligent Server Adapter > based on CN23XX chips. >