linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@linux.alibaba.com>
To: Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	Vlastimil Babka <vbabka@suse.cz>,
	David Rientjes <rientjes@google.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()
Date: Tue, 2 Jun 2020 19:28:30 +0800	[thread overview]
Message-ID: <7a02e2f6-6fa8-3727-1718-887c0d1dc1cb@linux.alibaba.com> (raw)
In-Reply-To: <alpine.LSU.2.11.2006012022440.1288@eggly.anvils>



在 2020/6/2 下午12:05, Hugh Dickins 写道:
> Cc'ing Alex Shi, because I noticed this when trying his v11 per-memcg
> lru_lock series (which appears to be a big improvement over earlier
> versions, thanks in particular to Johannes's memcg swap simplifications);
> and Alex's 12/16 makes a change on top of Konstantin's latter check,
> which will now just be reverted. I'm not yet confident in Alex's
> isolate_migratepages_block(), in part because this muddle.

Hi Hugh,

Yes, this could make a very tricky change on compaction behavior. I will update
the patchset after next update.

Thanks a lot for notice this! And looking forward to more comments on per memcg
lru_lock patchset! :)

Thanks
Alex

      parent reply	other threads:[~2020-06-02 11:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 14:05 [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount() Konstantin Khlebnikov
2020-05-13 18:32 ` Andrew Morton
2020-05-13 19:28   ` Konstantin Khlebnikov
2020-05-13 21:35     ` Vlastimil Babka
2020-05-23  1:34 ` Andrew Morton
2020-05-23 13:55   ` Konstantin Khlebnikov
2020-05-24  1:01 ` Hugh Dickins
2020-05-24 11:21   ` Konstantin Khlebnikov
2020-05-24 19:12     ` Hugh Dickins
2020-06-02  4:05   ` Hugh Dickins
2020-06-02  4:13     ` Andrew Morton
2020-06-02 11:28     ` Alex Shi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a02e2f6-6fa8-3727-1718-887c0d1dc1cb@linux.alibaba.com \
    --to=alex.shi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).