From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E1EEC7EE25 for ; Thu, 8 Jun 2023 07:02:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235217AbjFHHCG (ORCPT ); Thu, 8 Jun 2023 03:02:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234645AbjFHHB6 (ORCPT ); Thu, 8 Jun 2023 03:01:58 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 243DE2D73; Thu, 8 Jun 2023 00:01:30 -0700 (PDT) Received: from loongson.cn (unknown [113.200.148.30]) by gateway (Coremail) with SMTP id _____8Cx+enCfIFk8nEAAA--.1710S3; Thu, 08 Jun 2023 15:01:22 +0800 (CST) Received: from [10.130.0.149] (unknown [113.200.148.30]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Ax6OS_fIFkKNIGAA--.22132S3; Thu, 08 Jun 2023 15:01:20 +0800 (CST) Subject: Re: [PATCH v2] perf symbol: Add LoongArch case in get_plt_sizes() To: Huacai Chen References: <1684835873-15956-1-git-send-email-yangtiezhu@loongson.cn> Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Leo Yan , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, loongson-kernel@lists.loongnix.cn From: Tiezhu Yang Message-ID: <7a085947-9011-ebc9-a97d-7a62c755a978@loongson.cn> Date: Thu, 8 Jun 2023 15:01:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8Ax6OS_fIFkKNIGAA--.22132S3 X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7KrW8Ww4rAr15GF4UGrWkKrX_yoW8AF4fpr 13CF45KF1Dtr13G3Wxt395ZF4Igrs3CFyIgrySqFWjkFs7uw1IgrWxAry5CFyrXF1kWa4I vr1Du343uF18trXCm3ZEXasCq-sJn29KB7ZKAUJUUUUk529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUPab4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2kKe7AKxVWUtVW8ZwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07 AIYIkI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWU tVWrXwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI4 8JMxk0xIA0c2IEe2xFo4CEbIxvr21lc7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vI r41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1l4IxYO2xFxVAFwI0_Jw0_GFylx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUstxhDU UUU Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On 05/23/2023 06:26 PM, Huacai Chen wrote: > Acked-by: Huacai Chen > > On Tue, May 23, 2023 at 5:57 PM Tiezhu Yang wrote: >> >> We can see the following definitions in bfd/elfnn-loongarch.c: >> >> #define PLT_HEADER_INSNS 8 >> #define PLT_HEADER_SIZE (PLT_HEADER_INSNS * 4) >> >> #define PLT_ENTRY_INSNS 4 >> #define PLT_ENTRY_SIZE (PLT_ENTRY_INSNS * 4) >> >> so plt header size is 32 and plt entry size is 16 on LoongArch, >> let us add LoongArch case in get_plt_sizes(). >> >> Link: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=bfd/elfnn-loongarch.c >> Signed-off-by: Tiezhu Yang >> --- >> >> v2: Add EM_LOONGARCH definition to avoid build error >> >> tools/perf/util/symbol-elf.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c >> index b2ed9cc..b3dbf6c 100644 >> --- a/tools/perf/util/symbol-elf.c >> +++ b/tools/perf/util/symbol-elf.c >> @@ -35,6 +35,10 @@ >> #define EM_AARCH64 183 /* ARM 64 bit */ >> #endif >> >> +#ifndef EM_LOONGARCH >> +#define EM_LOONGARCH 258 >> +#endif >> + >> #ifndef ELF32_ST_VISIBILITY >> #define ELF32_ST_VISIBILITY(o) ((o) & 0x03) >> #endif >> @@ -411,6 +415,10 @@ static bool get_plt_sizes(struct dso *dso, GElf_Ehdr *ehdr, GElf_Shdr *shdr_plt, >> *plt_header_size = 32; >> *plt_entry_size = 16; >> return true; >> + case EM_LOONGARCH: >> + *plt_header_size = 32; >> + *plt_entry_size = 16; >> + return true; >> case EM_SPARC: >> *plt_header_size = 48; >> *plt_entry_size = 12; >> -- >> 2.1.0 Are you OK with this change? Could you please pick it up in your tree? Thanks, Tiezhu