From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kees Cook <keescook@chromium.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-rtc@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc: sun6i: Use struct_size() in kzalloc()
Date: Thu, 23 Aug 2018 17:01:11 -0500 [thread overview]
Message-ID: <7a213f7c-354c-06d5-7b14-fc69e9bb8a31@embeddedor.com> (raw)
In-Reply-To: <CAGXu5jKPOVRk5DbFMKu0BV_K-ES+j+6_aApjyo0X8zXBfTYDnw@mail.gmail.com>
On 8/23/18 3:56 PM, Kees Cook wrote:
>>
>> - clk_data = kzalloc(sizeof(*clk_data) + (sizeof(*clk_data->hws) * 2),
>> - GFP_KERNEL);
>> + clk_data = kzalloc(struct_size(clk_data, hws, 2), GFP_KERNEL);
>> if (!clk_data) {
>> kfree(rtc);
>> return;
>
> This looks like entirely correct to me, but I'm surprised the
> Coccinelle script didn't discover this. I guess the isomorphisms don't
> cover the parenthesis?
>
Apparently.
If I manually remove the ()s, the cocci script successfully generates a patch.
--
Gustavo
next prev parent reply other threads:[~2018-08-23 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 18:51 [PATCH] rtc: sun6i: Use struct_size() in kzalloc() Gustavo A. R. Silva
2018-08-23 20:56 ` Kees Cook
2018-08-23 22:01 ` Gustavo A. R. Silva [this message]
2018-08-23 21:56 ` Kees Cook
2018-08-27 21:02 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a213f7c-354c-06d5-7b14-fc69e9bb8a31@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).