linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Slark Xiao" <slark_xiao@163.com>
To: "Bjorn Helgaas" <helgaas@kernel.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH v2] PCI: Add vendor ID for Quectel and Cinterion
Date: Mon, 31 Oct 2022 17:08:18 +0800 (CST)	[thread overview]
Message-ID: <7a4b4099.3628.1842d4c7cc5.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <20221028160621.GA892468@bhelgaas>

















At 2022-10-29 00:06:21, "Bjorn Helgaas" <helgaas@kernel.org> wrote:
>On Fri, Oct 28, 2022 at 10:37:11AM +0800, Slark Xiao wrote:
>> In MHI driver, there are some companies product still do not have their
>>  own PCI vendor macro. So we add it here to make the code neat. Ref ID
>>  could be found in link https://pcisig.com/membership/member-companies
>>  and https://pciids.sourceforge.net/pci.ids . Thales use Cinterion as
>> their IOT modem card's trademark. So you will find 0x1269 belongs to
>> Thales. Actually, Cinterion belongs to Gemalto, and Gemalto belongs to
>>  Thales.
>
>There should not be spaces at the beginning of these lines.
>
>Don't bother with the sourceforge URL; I don't think that's really
>useful here.
 The space issue will be fixed in next patch.
>
>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> ---
>>  include/linux/pci_ids.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>> 
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index b362d90eb9b0..9e2b6286f53f 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -1765,6 +1765,8 @@
>>  #define PCI_VENDOR_ID_SATSAGEM		0x1267
>>  #define PCI_DEVICE_ID_SATSAGEM_NICCY	0x1016
>>  
>> +#define PCI_VENDOR_ID_CINTERION		0x1269	/* Celluar Modules*/
>
>This should identify the *vendor*, not a trademark for a specific
>product line.  And it should correspond somehow with the PCI-SIG
>registration.  So I think PCI_VENDOR_ID_THALES would be more
>appropriate here.
>
Yeah, currently it's used by IOT modules which support PCIE. But we
can't know if they will use this VID for other non-IOT modules product.
Thales would be better.

>I think the best thing here would be two patches.  One patch would add
>PCI_VENDOR_ID_THALES to pci_ids.h and also add a use of it in the MHI
>driver.  The second patch would do the same for PCI_VENDOR_ID_QUECTEL.
>
>Then each one is logically self-contained.
I must make sure these ids are applied, then I could commit the changes in MHI
driver side. Otherwise it will cause build error.
So I combine QUECTEL with THALES as a single patch. Shall I separate it from
each other? 1 for PCI IDs, and another for MHI change. It would be better, I think.
>
>>  #define PCI_VENDOR_ID_ENSONIQ		0x1274
>>  #define PCI_DEVICE_ID_ENSONIQ_CT5880	0x5880
>>  #define PCI_DEVICE_ID_ENSONIQ_ES1370	0x5000
>> @@ -2585,6 +2587,8 @@
>>  #define PCI_VENDOR_ID_TEKRAM		0x1de1
>>  #define PCI_DEVICE_ID_TEKRAM_DC290	0xdc29
>>  
>> +#define PCI_VENDOR_ID_QUECTEL		0x1eac
>> +
>>  #define PCI_VENDOR_ID_TEHUTI		0x1fc9
>>  #define PCI_DEVICE_ID_TEHUTI_3009	0x3009
>>  #define PCI_DEVICE_ID_TEHUTI_3010	0x3010
>> -- 
>> 2.34.1
>> 

  reply	other threads:[~2022-10-31  9:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28  2:37 [PATCH v2] PCI: Add vendor ID for Quectel and Cinterion Slark Xiao
2022-10-28  3:51 ` Bagas Sanjaya
2022-10-28  3:57   ` Slark Xiao
2022-10-28  4:00     ` Bagas Sanjaya
2022-10-28 16:06 ` Bjorn Helgaas
2022-10-31  9:08   ` Slark Xiao [this message]
2022-10-31 14:58     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a4b4099.3628.1842d4c7cc5.Coremail.slark_xiao@163.com \
    --to=slark_xiao@163.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).