From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7D9C433B4 for ; Fri, 30 Apr 2021 07:47:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66F896144B for ; Fri, 30 Apr 2021 07:47:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231504AbhD3Hsf (ORCPT ); Fri, 30 Apr 2021 03:48:35 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:27842 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230445AbhD3Hr6 (ORCPT ); Fri, 30 Apr 2021 03:47:58 -0400 Received: from [192.168.1.18] ([86.243.172.93]) by mwinf5d87 with ME id yvn72400521Fzsu03vn7oy; Fri, 30 Apr 2021 09:47:08 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 30 Apr 2021 09:47:08 +0200 X-ME-IP: 86.243.172.93 Subject: Re: [PATCH][next] PCI: mediatek-gen3: Add missing null pointer check To: Colin King , Ryder Lee , Jianjun Wang , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Matthias Brugger , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210429110040.63119-1-colin.king@canonical.com> From: Christophe JAILLET Message-ID: <7a512e3a-2897-ac12-ac6e-06be28735279@wanadoo.fr> Date: Fri, 30 Apr 2021 09:47:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210429110040.63119-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 29/04/2021 à 13:00, Colin King a écrit : > From: Colin Ian King > > The call to platform_get_resource_byname can potentially return null, so > add a null pointer check to avoid a null pointer dereference issue. > > Addresses-Coverity: ("Dereference null return") > Fixes: 441903d9e8f0 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192") > Signed-off-by: Colin Ian King > --- > drivers/pci/controller/pcie-mediatek-gen3.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c > index 20165e4a75b2..3c5b97716d40 100644 > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > @@ -721,6 +721,8 @@ static int mtk_pcie_parse_port(struct mtk_pcie_port *port) > int ret; > > regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "pcie-mac"); > + if (!regs) > + return -EINVAL; > port->base = devm_ioremap_resource(dev, regs); > if (IS_ERR(port->base)) { > dev_err(dev, "failed to map register base\n"); > Nitpick: Using 'devm_platform_ioremap_resource_byname' is slightly less verbose and should please Coverity. Also, which git repo are you using? On linux-next ([1)], your proposed patch is already part of "PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192". [1]: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/pci/controller/pcie-mediatek-gen3.c CJ