* [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register()
@ 2022-05-02 5:14 Bagas Sanjaya
2022-05-02 16:28 ` Russ Weight
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2022-05-02 5:14 UTC (permalink / raw)
To: linux-doc
Cc: Bagas Sanjaya, Stephen Rothwell, Russ Weight, Luis Chamberlain,
Greg Kroah-Hartman, Rafael J. Wysocki, Linux Kernel Mailing List,
Linux Next Mailing List
Stephen Rothwell reported kernel-doc warning:
drivers/base/firmware_loader/sysfs_upload.c:285: warning: Function parameter or member 'module' not described in 'firmware_upload_register'
Fix the warning by describing the 'module' parameter.
Fixes: 97730bbb242cde ("firmware_loader: Add firmware-upload support")
Link: https://lore.kernel.org/linux-next/20220502083658.266d55f8@canb.auug.org.au/
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Russ Weight <russell.h.weight@intel.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
This patch is based on driver-core-next tree.
drivers/base/firmware_loader/sysfs_upload.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/firmware_loader/sysfs_upload.c
index 8cdcf3516c7e94..87044d52322aa2 100644
--- a/drivers/base/firmware_loader/sysfs_upload.c
+++ b/drivers/base/firmware_loader/sysfs_upload.c
@@ -266,6 +266,7 @@ int fw_upload_start(struct fw_sysfs *fw_sysfs)
/**
* firmware_upload_register() - register for the firmware upload sysfs API
+ * @module: kernel module of this device
* @parent: parent device instantiating firmware upload
* @name: firmware name to be associated with this device
* @ops: pointer to structure of firmware upload ops
base-commit: f8ae07f4b8bfde0f33761e1a1aaee45a4e85e9d6
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register()
2022-05-02 5:14 [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register() Bagas Sanjaya
@ 2022-05-02 16:28 ` Russ Weight
2022-05-03 12:12 ` Greg Kroah-Hartman
2022-05-03 20:05 ` Luis Chamberlain
2 siblings, 0 replies; 4+ messages in thread
From: Russ Weight @ 2022-05-02 16:28 UTC (permalink / raw)
To: Bagas Sanjaya, linux-doc
Cc: Stephen Rothwell, Luis Chamberlain, Greg Kroah-Hartman,
Rafael J. Wysocki, Linux Kernel Mailing List,
Linux Next Mailing List
On 5/1/22 22:14, Bagas Sanjaya wrote:
> Stephen Rothwell reported kernel-doc warning:
>
> drivers/base/firmware_loader/sysfs_upload.c:285: warning: Function parameter or member 'module' not described in 'firmware_upload_register'
>
> Fix the warning by describing the 'module' parameter.
>
> Fixes: 97730bbb242cde ("firmware_loader: Add firmware-upload support")
> Link: https://lore.kernel.org/linux-next/20220502083658.266d55f8@canb.auug.org.au/
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Russ Weight <russell.h.weight@intel.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> This patch is based on driver-core-next tree.
>
> drivers/base/firmware_loader/sysfs_upload.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/firmware_loader/sysfs_upload.c
> index 8cdcf3516c7e94..87044d52322aa2 100644
> --- a/drivers/base/firmware_loader/sysfs_upload.c
> +++ b/drivers/base/firmware_loader/sysfs_upload.c
> @@ -266,6 +266,7 @@ int fw_upload_start(struct fw_sysfs *fw_sysfs)
>
> /**
> * firmware_upload_register() - register for the firmware upload sysfs API
> + * @module: kernel module of this device
> * @parent: parent device instantiating firmware upload
> * @name: firmware name to be associated with this device
> * @ops: pointer to structure of firmware upload ops
>
> base-commit: f8ae07f4b8bfde0f33761e1a1aaee45a4e85e9d6
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register()
2022-05-02 5:14 [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register() Bagas Sanjaya
2022-05-02 16:28 ` Russ Weight
@ 2022-05-03 12:12 ` Greg Kroah-Hartman
2022-05-03 20:05 ` Luis Chamberlain
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2022-05-03 12:12 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: linux-doc, Stephen Rothwell, Russ Weight, Luis Chamberlain,
Rafael J. Wysocki, Linux Kernel Mailing List,
Linux Next Mailing List
On Mon, May 02, 2022 at 12:14:56PM +0700, Bagas Sanjaya wrote:
> Stephen Rothwell reported kernel-doc warning:
>
> drivers/base/firmware_loader/sysfs_upload.c:285: warning: Function parameter or member 'module' not described in 'firmware_upload_register'
>
> Fix the warning by describing the 'module' parameter.
>
> Fixes: 97730bbb242cde ("firmware_loader: Add firmware-upload support")
> Link: https://lore.kernel.org/linux-next/20220502083658.266d55f8@canb.auug.org.au/
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
This should be "Reported-by:" I'll fix it up when I apply it to my tree
now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register()
2022-05-02 5:14 [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register() Bagas Sanjaya
2022-05-02 16:28 ` Russ Weight
2022-05-03 12:12 ` Greg Kroah-Hartman
@ 2022-05-03 20:05 ` Luis Chamberlain
2 siblings, 0 replies; 4+ messages in thread
From: Luis Chamberlain @ 2022-05-03 20:05 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: linux-doc, Stephen Rothwell, Russ Weight, Greg Kroah-Hartman,
Rafael J. Wysocki, Linux Kernel Mailing List,
Linux Next Mailing List
On Mon, May 02, 2022 at 12:14:56PM +0700, Bagas Sanjaya wrote:
> Stephen Rothwell reported kernel-doc warning:
>
> drivers/base/firmware_loader/sysfs_upload.c:285: warning: Function parameter or member 'module' not described in 'firmware_upload_register'
>
> Fix the warning by describing the 'module' parameter.
>
> Fixes: 97730bbb242cde ("firmware_loader: Add firmware-upload support")
> Link: https://lore.kernel.org/linux-next/20220502083658.266d55f8@canb.auug.org.au/
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Russ Weight <russell.h.weight@intel.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-03 20:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02 5:14 [PATCH] firmware_loader: describe 'module' parameter of firmware_upload_register() Bagas Sanjaya
2022-05-02 16:28 ` Russ Weight
2022-05-03 12:12 ` Greg Kroah-Hartman
2022-05-03 20:05 ` Luis Chamberlain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).