From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934273AbcJTL1U (ORCPT ); Thu, 20 Oct 2016 07:27:20 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:38461 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934152AbcJTL1T (ORCPT ); Thu, 20 Oct 2016 07:27:19 -0400 X-AuditID: cbfec7ef-f79e76d000005b57-14-5808aa113432 Subject: Re: [alsa-devel] [RFC PATCH 2/2] ASoC: samsung: Print a one-time message if the snow driver's probe defers To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Sangbeom Kim , Takashi Iwai , Liam Girdwood , Krzysztof Kozlowski , Mark Brown From: Sylwester Nawrocki Message-id: <7a730a84-ce97-2148-87d9-64211a1aaa6b@samsung.com> Date: Thu, 20 Oct 2016 13:27:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: <06ba6563-2792-cb08-694e-4582618ae7fb@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG++8cz86Wi+M0ezFNGA4xyCYUHEqkUmKRhGDQ2JcceZqSt3ac NL9oWt5S5y0cQ8gkS+fMOYfWIJGZbmR5SZcSmxAaRXkpNFsFlvMo+e338n+e9+F5+ZOY+GFA GJmZk89oclRZEkKI94/+Gj8WZCIVspJ2Pj0z5eDR9z8sEvTSsplHT0xY+PTGTAWPnra3EPRU xzqPtvzsRmdIuWWthJA/N3r5cqupkpDb9FtUazMheY/NjcvXrEdS+EphfDqTlVnAaI4npAkz Vsoa+HmVgbfmWuOLkVdQhQQkUCfg7fsKnONQmJzvIaqQkBRTjxHMdm3uDGsIKgdqeLuOdV/X f9U7y92d4ROCBns15lcFU1owfW/edoRQJ+F39+cAvwjzr7J8rdkOJKg4qBmpRX4WUQnwSN9G +BmnpGB1l24tIsmDlAL0r6M5SRD4Gue3rQIqETwTC9uMUTIwNA3zOI6EPvMy5s8CapAPXoMX 9+8BKgKsQxjXIAlsTfUEx8HwxWnjcxwO0433cM6rR+AylyJuMCDwlNft9D8Nw86pAC7tADT0 N2NcgAgqysScRA4PDHcQx2fB/eo2zl1ohAeLrd1EHYo07ilk3FPCuKdEK8JMKITRstlqho2L ZVXZrDZHHXstN9uKtj7O2KZz9Rn6WHrZgSgSSQJFGeN8hThAVcDqsh0ISEwSIlK2kwqxKF2l K2Q0uVc12iyGdaDDJC45JHrROnNFTKlV+cwNhsljNLuvPFIQVozUTzt9hR1M6qVeV2o43bKk E3vMF0rGUqKqfX+kYaFJusEkvL7zx6Y42qg6l9wrI2MXOqLbLoYPRNjHY1+6ZW+KXHMj0rHJ DZnFYWOTB9YDQ9LKi5z5o32rlhU2amlRff7mrEf5ZH/F36GR5G89iR6X/dR1X11MXMQ+ZYw0 WoKzGaq4o5iGVf0DFYpjaDQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t/xq7pvVnJEGLzbzWJx5eIhJoupD5+w Wbx5u4bJ4vz5DewW3650MFlc3jWHzeLiii9MFhu+r2V04PDY8LmJzWPnrLvsHptWdbJ5bOkH svq2rGL0WL/lKovH501yAexRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4h QUoKZYk5pUCekQEacHAOcA9W0rdLcMt41zaJvaCTp+LGApsGxrucXYycHBICJhJffqxmg7DF JC7cWw9kc3EICSxhlLj2bjMzhPOcUeLPq/8sIFXCAqUSqz5OZwKxRQRMJX6tfcEKUXSUSaJ9 1mNGEIdZ4DOjRPOJe+wgVWwChhK9R/sYQWxeATuJJf2LwPaxCKhKbLrazAxiiwpESNx62MEC USMo8WPyPTCbU8BZ4s75x0A2B9BQPYn7F7VAwswC8hKb17xlnsAoMAtJxyyEqllIqhYwMq9i FEktLc5Nzy020itOzC0uzUvXS87P3cQIjLxtx35u2cHY9S74EKMAB6MSD2/GOfYIIdbEsuLK 3EOMEhzMSiK8UUs5IoR4UxIrq1KL8uOLSnNSiw8xmgK9MJFZSjQ5H5gU8kriDU0MzS0NjYwt LMyNjJTEead+uBIuJJCeWJKanZpakFoE08fEwSnVwHhRau1Hh6D5M+7lx8x+s+z1Heurulce FtcKHH0v6i1kf2OebXf+rfWLc1h+/BDcef3ur9UP7zG1r1/p9MH6Y425RmR630c725yrduee yH+RTv4nv/v6g7vNsgvucurbH5ZaZJkV/9xgTULT82/llyPeLPY7mDT5yM+Pd3apzdy24iDf BwnR5U8WKLEUZyQaajEXFScCAPnS8lrSAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161020112711eucas1p1e7c1bc60d5e99e10d117577a8fd4bd17 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161019181043eucas1p2d52e28825ae57bbfd19c6d290c6ceb05 X-RootMTR: 20161019181043eucas1p2d52e28825ae57bbfd19c6d290c6ceb05 References: <1476897666-13974-1-git-send-email-javier@osg.samsung.com> <1476897666-13974-3-git-send-email-javier@osg.samsung.com> <29147d0b-ecf7-726a-b12b-f93d548f0c99@samsung.com> <06ba6563-2792-cb08-694e-4582618ae7fb@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/20/2016 12:41 PM, Javier Martinez Canillas wrote: > I see no relevant changes in exynos_defconfig between v4.7..v4.8 and > also no changes in drivers/Makefile that could cause things to be > initialized on a different order. I remember this commit 6eb1c9496b81680f2cd2e0eda06c531317e2e28d clk: probe common clock drivers earlier going in recently, but it's rather dubious it could cause such trouble. Anyway, I'd try to add some debug prints to samsung_i2s_probe() to see what's the issue with the CPU DAI registration. > But I thought the patches had merits on its own since probe deferral > can make a driver probe many times and the error logs were noisy. I > wasn't sure though and that's why are marked as RFC. In general I wouldn't be disabling those err logs unless proper EPROBE_DEFER handling is added on related error paths and we can differentiate between probe deferral and real unrecoverable errors and can disable logging only for EPROBE_DEFER cases. >> As far as the error log is concerned, I would just not print anything >> in snow_probe() when register_card() returns EPROBE_DEFER. >> > > I believe it may be useful to know that a driver's probe is deferring > due a missing dependency but have no strong opinion and can remove the > message. I'd rather rely on core code to inform about missing resources when registering components. Otherwise booting unnecessarily takes more time when there is more probe deferring logs printed on the console. -- Thanks, Sylwester