From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] usb: dwc2: Check for null res pointer
Date: Mon, 20 Dec 2021 09:44:58 +0000 [thread overview]
Message-ID: <7a7df3b5-b059-b109-ab98-8046ce73261d@synopsys.com> (raw)
In-Reply-To: <20211220080926.883605-1-jiasheng@iscas.ac.cn>
Hi Jiasheng,
On 12/20/2021 12:09 PM, Jiasheng Jiang wrote:
> The return value of platform_get_resource() needs to be checked.
> To avoid use of error pointer in case of the failure of alloc.
>
> Fixes: 348becdcc319 ("usb: dwc2: fix "iomem 0x00000000" message")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2
>
> *Change 1. Correct the commit message.
> ---
> drivers/usb/dwc2/hcd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2a7828971d05..517743555b9c 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -5191,6 +5191,11 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
> hcd->has_tt = 1;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + retval = -EINVAL;
> + goto error1;
> + }
> +
> hcd->rsrc_start = res->start;
> hcd->rsrc_len = resource_size(res);
>
This patch already in code. Please check follow patch:
commit 856e6e8e0f9300befa87dde09edb578555c99a82
Author: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue Aug 31 16:42:36 2021 +0800
usb: dwc2: check return value after calling platform_get_resource()
Thanks,
Minas
prev parent reply other threads:[~2021-12-20 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 8:09 [PATCH v2] usb: dwc2: Check for null res pointer Jiasheng Jiang
2021-12-20 9:44 ` Minas Harutyunyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a7df3b5-b059-b109-ab98-8046ce73261d@synopsys.com \
--to=minas.harutyunyan@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).