From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
sam@ravnborg.org
Cc: daniel@ffwll.ch, Laurent.pinchart@ideasonboard.com,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR
Date: Mon, 18 Oct 2021 09:40:03 +0200 [thread overview]
Message-ID: <7a921d1d-84b4-c3e4-8f7c-10db5ad42ecf@baylibre.com> (raw)
In-Reply-To: <CAFBinCBwO0CJMPA3K6e8OxXcinzrA5LrSqaKu1XtZPWLXT8Krw@mail.gmail.com>
Hi,
On 16/10/2021 00:34, Martin Blumenstingl wrote:
> Hi Neil, Hi Sam,
>
> On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> [...]
>> +static const struct drm_bridge_funcs meson_encoder_cvbs_bridge_funcs = {
>> + .attach = meson_encoder_cvbs_attach,
>> + .enable = meson_encoder_cvbs_enable,
>> + .disable = meson_encoder_cvbs_disable,
>> + .mode_valid = meson_encoder_cvbs_mode_valid,
>> + .get_modes = meson_encoder_cvbs_get_modes,
>> + .atomic_enable = meson_encoder_cvbs_atomic_enable,
> I did some testing on boards where u-boot doesn't initialize the video outputs.
> It seems that meson_encoder_cvbs_enable() is never called with this patch.
> meson_encoder_cvbs_atomic_enable() is called though.
>
> From what I can see in drm_bridge.c [0] this is even expected.
> Does this mean that we need to move all logic from .enable to
> .atomic_enable (and same with .disable -> moving that logic to
> .atomic_disable)?
>
> The same comment applies to the HDMI patch.
Good point, I'll fix that for both patches !
Neil
>
>
> Best regards,
> Martin
>
>
> [0] https://elixir.bootlin.com/linux/v5.15-rc5/source/drivers/gpu/drm/drm_bridge.c#L717
>
prev parent reply other threads:[~2021-10-18 7:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 14:11 [PATCH v2 0/6] drm/meson: rework encoders to pass ATTACH_NO_CONNECTOR Neil Armstrong
2021-10-15 14:11 ` [PATCH v2 1/6] drm/bridge: display-connector: implement bus fmts callbacks Neil Armstrong
2021-10-15 14:11 ` [PATCH v2 2/6] drm/meson: remove useless recursive components matching Neil Armstrong
2021-10-15 21:59 ` Martin Blumenstingl
2021-10-15 14:11 ` [PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi Neil Armstrong
2021-10-15 22:01 ` Martin Blumenstingl
2021-10-18 13:58 ` Laurent Pinchart
2021-10-15 14:11 ` [PATCH v2 4/6] drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR Neil Armstrong
2021-10-15 22:07 ` Martin Blumenstingl
2021-10-18 7:50 ` Neil Armstrong
2021-10-15 14:11 ` [PATCH v2 5/6] drm/meson: rename venc_cvbs to encoder_cvbs Neil Armstrong
2021-10-15 22:07 ` Martin Blumenstingl
2021-10-15 14:11 ` [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR Neil Armstrong
2021-10-15 22:07 ` Martin Blumenstingl
2021-10-15 22:34 ` Martin Blumenstingl
2021-10-18 7:40 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a921d1d-84b4-c3e4-8f7c-10db5ad42ecf@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).